Merge lp:~marcobiscaro2112/unity/fixes-748299 into lp:unity

Proposed by Marco Biscaro
Status: Merged
Merged at revision: 1109
Proposed branch: lp:~marcobiscaro2112/unity/fixes-748299
Merge into: lp:unity
Diff against target: 32 lines (+0/-12)
2 files modified
src/DeviceLauncherIcon.cpp (+0/-11)
src/DeviceLauncherIcon.h (+0/-1)
To merge this branch: bzr merge lp:~marcobiscaro2112/unity/fixes-748299
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli Approve
Review via email: mp+57064@code.launchpad.net

Description of the change

Since commit 1032, the method ActivateLauncherIcon is called from LauncherIcon.cpp (so, there is no need to call it again on DeviceLauncherIcon.cpp).

To post a comment you must log in.
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Approved! code looks good

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/DeviceLauncherIcon.cpp'
2--- src/DeviceLauncherIcon.cpp 2011-03-29 15:24:14 +0000
3+++ src/DeviceLauncherIcon.cpp 2011-04-09 23:55:46 +0000
4@@ -104,17 +104,6 @@
5 return nux::Color (0xFF333333);
6 }
7
8-void
9-DeviceLauncherIcon::OnMouseClick (int button)
10-{
11- SimpleLauncherIcon::OnMouseClick (button);
12-
13- if (button == 1)
14- {
15- ActivateLauncherIcon ();
16- }
17-}
18-
19 std::list<DbusmenuMenuitem *>
20 DeviceLauncherIcon::GetMenus ()
21 {
22
23=== modified file 'src/DeviceLauncherIcon.h'
24--- src/DeviceLauncherIcon.h 2011-03-29 14:36:45 +0000
25+++ src/DeviceLauncherIcon.h 2011-04-09 23:55:46 +0000
26@@ -37,7 +37,6 @@
27 void UpdateVisibility ();
28
29 protected:
30- void OnMouseClick (int button);
31 std::list<DbusmenuMenuitem *> GetMenus ();
32 void UpdateDeviceIcon ();
33