Merge lp:~marcobiscaro2112/unity/fixes-733349 into lp:unity
Status: | Superseded | ||||
---|---|---|---|---|---|
Proposed branch: | lp:~marcobiscaro2112/unity/fixes-733349 | ||||
Merge into: | lp:unity | ||||
Diff against target: |
228 lines (+89/-11) 7 files modified
src/BamfLauncherIcon.cpp (+49/-5) src/BamfLauncherIcon.h (+2/-0) src/Launcher.cpp (+14/-0) src/Launcher.h (+5/-0) src/LauncherIcon.cpp (+0/-3) src/unityshell.cpp (+4/-2) unityshell.xml.in (+15/-1) |
||||
To merge this branch: | bzr merge lp:~marcobiscaro2112/unity/fixes-733349 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Mirco Müller (community) | 2011-05-18 | Disapprove on 2011-05-25 | |
Review via email:
|
Description of the change
Implementation of what was discussed here: https:/
This option is disabled by default, and can be enabled through ccsm.
Mirco Müller (macslow) wrote : | # |
Marco Biscaro (marcobiscaro2112) wrote : | # |
I understand this point of view, but disagree in this case.
At moment, there are 78 people which manifested as affected by this bug. And I'm sure that are many more. If we add this functionality now, there is a lot of time to people test it before oneiric (and even more time before the next LTS).
Otherwise, if we keep this thought in mind, unity will not evolve: it will not turn better, it will not turn more customizable, it will not turn more familiar. And it's this that users expect. :)
Please, consider this.
Magnes (magnesus2) wrote : | # |
Where is the "the design and user-interaction discussion" and how can we participate? Why people that are affected by this bug are not part of it? Why are you trowing out ready solution that doesn't break anything and is turned off by default?
- 1189. By Marco Biscaro on 2011-12-20
-
Reverted changes
- 1190. By Marco Biscaro on 2011-12-20
-
Merge with trunk
- 1191. By Marco Biscaro on 2011-12-20
-
Implementing minimization when launcher icon is clicked (LP: #733349).
Reference: https:/
/bugs.launchpad .net/ayatana- design/ +bug/733349/ comments/ 58
Unmerged revisions
- 1191. By Marco Biscaro on 2011-12-20
-
Implementing minimization when launcher icon is clicked (LP: #733349).
Reference: https:/
/bugs.launchpad .net/ayatana- design/ +bug/733349/ comments/ 58 - 1190. By Marco Biscaro on 2011-12-20
-
Merge with trunk
- 1189. By Marco Biscaro on 2011-12-20
-
Reverted changes
- 1188. By Marco Biscaro on 2011-05-18
-
Implementing minimization when launcher icon is clicked (LP: #733349).
Reference: https:/
/bugs.launchpad .net/ayatana- design/ +bug/733349/ comments/ 58
While the code looks ok, compiles and works as advertised, it will not be approved - thus merged into trunk - as long as the design and user-interaction discussion does not agree with this. At least this is something that can be considered to be part of a future user-testing session and see how this behaviour is received compared to the current one.
On a general note... adding numerous options, which divert from the default, causes the introduction of code-paths note exercised as much as others (default) ones. Thus code-rot is a potential danger here... where options could cause unknown/ undiscovered side-effects, because they just have not been tested as much.