Merge lp:~marcobiscaro2112/unity/fixes-733349 into lp:unity
Proposed by
Marco Biscaro
Status: | Superseded | ||||
---|---|---|---|---|---|
Proposed branch: | lp:~marcobiscaro2112/unity/fixes-733349 | ||||
Merge into: | lp:unity | ||||
Diff against target: |
228 lines (+89/-11) 7 files modified
src/BamfLauncherIcon.cpp (+49/-5) src/BamfLauncherIcon.h (+2/-0) src/Launcher.cpp (+14/-0) src/Launcher.h (+5/-0) src/LauncherIcon.cpp (+0/-3) src/unityshell.cpp (+4/-2) unityshell.xml.in (+15/-1) |
||||
To merge this branch: | bzr merge lp:~marcobiscaro2112/unity/fixes-733349 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Mirco Müller (community) | Disapprove | ||
Review via email: mp+61473@code.launchpad.net |
Description of the change
Implementation of what was discussed here: https:/
This option is disabled by default, and can be enabled through ccsm.
To post a comment you must log in.
Unmerged revisions
- 1191. By Marco Biscaro
-
Implementing minimization when launcher icon is clicked (LP: #733349).
Reference: https:/
/bugs.launchpad .net/ayatana- design/ +bug/733349/ comments/ 58 - 1190. By Marco Biscaro
-
Merge with trunk
- 1189. By Marco Biscaro
-
Reverted changes
- 1188. By Marco Biscaro
-
Implementing minimization when launcher icon is clicked (LP: #733349).
Reference: https:/
/bugs.launchpad .net/ayatana- design/ +bug/733349/ comments/ 58
While the code looks ok, compiles and works as advertised, it will not be approved - thus merged into trunk - as long as the design and user-interaction discussion does not agree with this. At least this is something that can be considered to be part of a future user-testing session and see how this behaviour is received compared to the current one.
On a general note... adding numerous options, which divert from the default, causes the introduction of code-paths note exercised as much as others (default) ones. Thus code-rot is a potential danger here... where options could cause unknown/ undiscovered side-effects, because they just have not been tested as much.