Code review comment for lp:~marco-gallotta/ibid/ascii-501638

Revision history for this message
marcog (marco-gallotta) wrote :

Fixed

> ibid/plugins/ascii.py:6: 'socket' imported but unused
> ibid/plugins/ascii.py:8: 'stderr' imported but unused
> ibid/plugins/ascii.py:129: redefinition of unused 'stderr' from line 8
> ibid/plugins/ascii.py:129: 'stderr' imported but unused
>
> Also, "Sorry, that string is too long!". Can you make that "Sorry that's too
> long, nobody will be able to read it"
>
> Users don't know about "strings" and they don't need the exclamation mark

review: Needs Resubmitting

« Back to merge proposal