Merge lp:~marcinello/ubuntu-rssreader-app/fix-1297463 into lp:~ubuntu-shorts-dev/ubuntu-rssreader-app/trunk

Proposed by Marcin on 2014-04-01
Status: Merged
Approved by: Joey Chan on 2014-04-02
Approved revision: 197
Merged at revision: 197
Proposed branch: lp:~marcinello/ubuntu-rssreader-app/fix-1297463
Merge into: lp:~ubuntu-shorts-dev/ubuntu-rssreader-app/trunk
Diff against target: 15 lines (+2/-3)
1 file modified
shorts-app.qml (+2/-3)
To merge this branch: bzr merge lp:~marcinello/ubuntu-rssreader-app/fix-1297463
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve on 2014-04-02
Roman Shchekin 2014-04-01 Approve on 2014-04-01
Review via email:

Commit message

Changed default window size to match other core apps on desktop.

Description of the change

Changed default window size to match other core apps on desktop.

To post a comment you must log in.
Roman Shchekin (mrqtros) wrote :

Looks fine.

review: Approve

FAILED: Autolanding.
No commit message was specified in the merge proposal. Hit 'Add commit message' on the merge proposal web page or follow the link below. You can approve the merge proposal yourself to rerun.

review: Needs Fixing (continuous-integration)
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'shorts-app.qml'
2--- shorts-app.qml 2014-03-08 15:27:10 +0000
3+++ shorts-app.qml 2014-04-01 16:54:06 +0000
4@@ -23,9 +23,8 @@
5 applicationName: "com.ubuntu.shorts"
6 anchorToKeyboard: true
9- width:
10- height:
11+ width:
12+ height:
14 // comment mainview_0 start
15 // this signal will be triggered when size changed


People subscribed via source and target branches