Merge lp:~marcinello/ubuntu-calendar-app/fix-1297463 into lp:ubuntu-calendar-app

Proposed by Marcin on 2014-03-30
Status: Merged
Approved by: Kunal Parmar on 2014-04-01
Approved revision: 225
Merged at revision: 227
Proposed branch: lp:~marcinello/ubuntu-calendar-app/fix-1297463
Merge into: lp:ubuntu-calendar-app
Diff against target: 12 lines (+1/-1)
1 file modified
calendar.qml (+1/-1)
To merge this branch: bzr merge lp:~marcinello/ubuntu-calendar-app/fix-1297463
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve on 2014-04-01
Alan Pope 🍺🐧🐱 πŸ¦„ 2014-03-30 Approve on 2014-03-31
Review via email: mp+213381@code.launchpad.net

Commit message

Simply changed default window size to match music-app, calendar-app does not use ConditionalLayout at the moment

Description of the change

Simply changed default window size to match music-app, calendar-app does not use ConditionalLayout at the moment

To post a comment you must log in.
Kunal Parmar (pkunal-parmar) wrote :

I have few question not related to this changes but general direction.

Does SDK resizes app to phone's screen dimension when on phone ?

And Is SDK planning to provide some hint when its on desktop and when its on Phone and launch app with certain default dimension ?

The app appears "full size" on the phone and tablet - that is, it takes up the entire screen (indicator aside). The exception to this is on a tablet where the app is confined to the sidestage, where the application will sit in a phone-sized "window".

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'calendar.qml'
2--- calendar.qml 2014-03-26 14:39:17 +0000
3+++ calendar.qml 2014-03-30 13:40:11 +0000
4@@ -51,7 +51,7 @@
5 objectName: "calendar"
6 applicationName: "com.ubuntu.calendar"
7
8- width: units.gu(45)
9+ width: units.gu(100)
10 height: units.gu(80)
11
12 headerColor: "#266249"

Subscribers

People subscribed via source and target branches

to status/vote changes: