Merge lp:~mar-kolya/compiz/fix-for-1186426 into lp:compiz/0.9.10

Proposed by kolya
Status: Merged
Approved by: Sam Spilsbury
Approved revision: 3733
Merged at revision: 3732
Proposed branch: lp:~mar-kolya/compiz/fix-for-1186426
Merge into: lp:compiz/0.9.10
Diff against target: 12 lines (+1/-1)
1 file modified
plugins/staticswitcher/src/staticswitcher.cpp (+1/-1)
To merge this branch: bzr merge lp:~mar-kolya/compiz/fix-for-1186426
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Sam Spilsbury Approve
MC Return Approve
Review via email: mp+166912@code.launchpad.net

Commit message

When static switcher is enabled and has an option to show application icon turned on the icons are expected to be ~1/3 of a thumbnail (48px). Instead they are displayed in 512px size and completely cover everything. This change addresses this issue. See LP #1173914.

Description of the change

This change partly reverts change introduced by 1173914 in order to fix a regression in staticswitcher.

The problem: when static switcher is enabled and has an option to show application icon turned on the icons are expected to be ~1/3 of a thumbnail (48px). Instead they are displayed in 512px size and completely cover everything.

To post a comment you must log in.
Revision history for this message
MC Return (mc-return) wrote :

Sorry, I did not notice introducing this bug.
+1 for fixing it.

review: Approve
Revision history for this message
MC Return (mc-return) wrote :

Please add a commit message above also. Thanks :)

Revision history for this message
kolya (mar-kolya) wrote :

> Please add a commit message above also. Thanks :)

Done.

I hope you won't mind me asking stupid question: it looks like I've accidentally pushed a change to debian/changelog into this branch. Shall I add a commit reverting it or is it fine as is?

Revision history for this message
MC Return (mc-return) wrote :

I think it would be better to revert this change indeed as the changelog will be updated automatically AFAIK...

Revision history for this message
MC Return (mc-return) wrote :

In the mid-term all of those values should be made configurable via CCSM, so one could set up ideal previewsize, bordersize and icon size individually...

lp:~mar-kolya/compiz/fix-for-1186426 updated
3733. By kolya

Revert accidental debian/changelog change

Revision history for this message
Sam Spilsbury (smspillaz) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/staticswitcher/src/staticswitcher.cpp'
2--- plugins/staticswitcher/src/staticswitcher.cpp 2013-05-12 08:24:06 +0000
3+++ plugins/staticswitcher/src/staticswitcher.cpp 2013-06-01 00:12:26 +0000
4@@ -27,7 +27,7 @@
5
6 COMPIZ_PLUGIN_20090315 (staticswitcher, StaticSwitchPluginVTable)
7
8-const unsigned short MAX_ICON_SIZE = 512;
9+const unsigned short ICON_SIZE = 48;
10
11 const unsigned short PREVIEWSIZE = 150;
12 const unsigned short BORDER = 10;

Subscribers

People subscribed via source and target branches