Merge lp:~mapreri/inkscape/reproducible-builds into lp:~inkscape.dev/inkscape/trunk

Proposed by Mattia Rizzolo
Status: Merged
Merged at revision: 15224
Proposed branch: lp:~mapreri/inkscape/reproducible-builds
Merge into: lp:~inkscape.dev/inkscape/trunk
Diff against target: 25 lines (+2/-2)
2 files modified
src/extension/internal/emf-print.cpp (+1/-1)
src/main.cpp (+1/-1)
To merge this branch: bzr merge lp:~mapreri/inkscape/reproducible-builds
Reviewer Review Type Date Requested Status
Bryce Harrington (community) Approve
Mc Approve
Review via email: mp+310228@code.launchpad.net

Description of the change

IMHO, that information serves no practical purpose at all, and can be safely dropped, gaining instead a much better thing (reproducible builds).

To post a comment you must log in.
Revision history for this message
Mc (mc...) wrote :

I also think a reproducible build benefits outweighs the information of compile date (we keep revno)

review: Approve
Revision history for this message
Bryce Harrington (bryce) wrote :

I think the build date is a useful bit of data but it's a good point that bitwise reproducible builds would be a more useful feature. There's other ways to keep track of the build date besides this.

review: Approve
Revision history for this message
Mattia Rizzolo (mapreri) wrote :

Great, thank you!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/extension/internal/emf-print.cpp'
2--- src/extension/internal/emf-print.cpp 2016-07-14 11:17:21 +0000
3+++ src/extension/internal/emf-print.cpp 2016-11-07 20:48:43 +0000
4@@ -205,7 +205,7 @@
5 } else {
6 p = ansi_uri;
7 }
8- snprintf(buff, sizeof(buff) - 1, "Inkscape %s (%s)\1%s\1", Inkscape::version_string, __DATE__, p);
9+ snprintf(buff, sizeof(buff) - 1, "Inkscape %s \1%s\1", Inkscape::version_string, p);
10 uint16_t *Description = U_Utf8ToUtf16le(buff, 0, NULL);
11 int cbDesc = 2 + wchar16len(Description); // also count the final terminator
12 (void) U_Utf16leEdit(Description, '\1', '\0'); // swap the temporary \1 characters for nulls
13
14=== modified file 'src/main.cpp'
15--- src/main.cpp 2016-11-06 15:33:01 +0000
16+++ src/main.cpp 2016-11-07 20:48:43 +0000
17@@ -2159,7 +2159,7 @@
18 }
19 #endif // WITH_YAML
20 case SP_ARG_VERSION: {
21- printf("Inkscape %s (%s)\n", Inkscape::version_string, __DATE__);
22+ printf("Inkscape %s\n", Inkscape::version_string);
23 exit(0);
24 break;
25 }