Merge lp:~manzurmm/update-manager/update-manager into lp:update-manager

Proposed by Manzur
Status: Merged
Approved by: Michael Terry
Approved revision: 2752
Merged at revision: 2755
Proposed branch: lp:~manzurmm/update-manager/update-manager
Merge into: lp:update-manager
Diff against target: 12 lines (+2/-0)
1 file modified
UpdateManager/Core/MetaRelease.py (+2/-0)
To merge this branch: bzr merge lp:~manzurmm/update-manager/update-manager
Reviewer Review Type Date Requested Status
Michael Terry Approve
Review via email: mp+309095@code.launchpad.net

Description of the change

This change adds error message when `do-release-upgrade` is not able to reach METARELEASE_URI. Currently, it just prints 'No new release found' message, which can be confusing.

To post a comment you must log in.
Revision history for this message
Michael Terry (mterry) wrote :

Thanks, Manzur! This looks fine to add, will merge to trunk.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'UpdateManager/Core/MetaRelease.py'
2--- UpdateManager/Core/MetaRelease.py 2016-04-07 21:26:01 +0000
3+++ UpdateManager/Core/MetaRelease.py 2016-10-23 22:15:21 +0000
4@@ -361,6 +361,8 @@
5 # generic network error
6 except (URLError, BadStatusLine, socket.timeout) as e:
7 self._debug("result of meta-release download: '%s'" % e)
8+ print("Failed to connect to %s. Check your Internet connection "
9+ "or proxy settings" % self.METARELEASE_URI)
10 # now check the information we have
11 if self.metarelease_information is not None:
12 self._debug("have self.metarelease_information")

Subscribers

People subscribed via source and target branches

to status/vote changes: