Code review comment for lp:~manishsinha/zeitgeist/fix-blacklist-api

Revision history for this message
Manish Sinha (मनीष सिन्हा) (manishsinha) wrote :

> A quick comment: How's the Changed signal supposed to work, ie. how do you
> know if the templates are being added or removed? Why not have two separated
> signals (TemplatesAdded, TemplatesRemoved)?

+1 for this idea.

> I also don't buy this "blacklister" stuff. What's the point of it?

Well, that is for knowing which application set the blacklist. Kamstrup proposed that idea

« Back to merge proposal