Merge lp:~mandel/unity-scope-click/udm-rebuild into lp:unity-scope-click

Proposed by Manuel de la Peña
Status: Merged
Approved by: Manuel de la Peña
Approved revision: 243
Merge reported by: dobey
Merged at revision: not available
Proposed branch: lp:~mandel/unity-scope-click/udm-rebuild
Merge into: lp:unity-scope-click
Diff against target: 41 lines (+10/-2)
3 files modified
debian/changelog (+6/-0)
debian/control (+2/-2)
libclickscope/tests/mock_ubuntu_download_manager.h (+2/-0)
To merge this branch: bzr merge lp:~mandel/unity-scope-click/udm-rebuild
Reviewer Review Type Date Requested Status
dobey (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Alejandro J. Cura (community) Approve
Manuel de la Peña (community) Needs Fixing
Review via email: mp+225487@code.launchpad.net

Commit message

Update the udm dependency.

To post a comment you must log in.
Revision history for this message
Alejandro J. Cura (alecu) wrote :

+1

review: Approve
Revision history for this message
dobey (dobey) wrote :

I think you need to not increase the version requirement on the -dev, but instead just add a new changelog entry that is "* No change rebuild for new ubuntu-download-manager." using dch -i for example.

review: Needs Fixing
Revision history for this message
dobey (dobey) :
review: Approve
Revision history for this message
Manuel de la Peña (mandel) wrote :

This need another review because we needed to change the mock object.

review: Needs Fixing
Revision history for this message
Alejandro J. Cura (alecu) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
dobey (dobey) :
review: Approve
Revision history for this message
Manuel de la Peña (mandel) wrote :

Approving, the fact that jenkins fails is because the deps is no updated just yet.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2014-07-04 08:51:52 +0000
3+++ debian/changelog 2014-07-07 16:59:05 +0000
4@@ -1,3 +1,9 @@
5+unity-scope-click (0.1+14.10.20140704-0ubuntu2) UNRELEASED; urgency=medium
6+
7+ * Update the mock objects of the test to use the new ubuntu-download-manager.
8+
9+ -- Manuel de la Pena <manuel.delapena@canonical.com> Thu, 03 Jul 2014 16:33:54 +0200
10+
11 unity-scope-click (0.1+14.10.20140704-0ubuntu1) utopic; urgency=medium
12
13 [ Alejandro J. Cura (alecu) ]
14
15=== modified file 'debian/control'
16--- debian/control 2014-06-23 15:00:28 +0000
17+++ debian/control 2014-07-07 16:59:05 +0000
18@@ -9,8 +9,8 @@
19 libboost-locale-dev,
20 libglib2.0-dev (>= 2.32),
21 libjsoncpp-dev,
22- libubuntu-download-manager-client-dev (>= 0.3+14.10.20140430-0ubuntu1),
23- libubuntu-download-manager-common-dev (>= 0.3+14.10.20140430-0ubuntu1),
24+ libubuntu-download-manager-client-dev (>= 0.6),
25+ libubuntu-download-manager-common-dev (>= 0.6),
26 libubuntuoneauth-2.0-dev,
27 libunity-api-dev (>= 7.80.7),
28 libunity-scopes-dev (>= 0.5.0),
29
30=== modified file 'libclickscope/tests/mock_ubuntu_download_manager.h'
31--- libclickscope/tests/mock_ubuntu_download_manager.h 2014-05-26 14:27:31 +0000
32+++ libclickscope/tests/mock_ubuntu_download_manager.h 2014-07-07 16:59:05 +0000
33@@ -65,6 +65,8 @@
34
35 MOCK_CONST_METHOD0(isError, bool());
36 MOCK_CONST_METHOD0(error, Error*());
37+ MOCK_METHOD0(headers, QMap<QString, QString>());
38+ MOCK_METHOD1(setHeaders, void(QMap<QString, QString>));
39 };
40
41 class MockError : public Ubuntu::DownloadManager::Error

Subscribers

People subscribed via source and target branches