Merge lp:~mandel/ubuntuone-windows-installer/version_autoincrease into lp:ubuntuone-windows-installer/beta

Proposed by Manuel de la Peña
Status: Merged
Approved by: Rodrigo Moya
Approved revision: 23
Merged at revision: 48
Proposed branch: lp:~mandel/ubuntuone-windows-installer/version_autoincrease
Merge into: lp:ubuntuone-windows-installer/beta
Diff against target: 392 lines (+70/-112)
21 files modified
build.number (+1/-0)
main.build (+27/-2)
src/Canonical.UbuntuOne.Client.Test/Canonical.UbuntuOne.Client.Test.csproj (+3/-0)
src/Canonical.UbuntuOne.Client.Test/Properties/AssemblyInfo.cs (+0/-13)
src/Canonical.UbuntuOne.Client.Views/Canonical.UbuntuOne.Client.Views.csproj (+3/-0)
src/Canonical.UbuntuOne.Client.Views/Properties/AssemblyInfo.cs (+0/-12)
src/Canonical.UbuntuOne.Client/Canonical.UbuntuOne.Client.csproj (+3/-0)
src/Canonical.UbuntuOne.Client/Properties/AssemblyInfo.cs (+0/-12)
src/Canonical.UbuntuOne.Common.Tests/Canonical.UbuntuOne.Common.Tests.csproj (+3/-0)
src/Canonical.UbuntuOne.Common.Tests/Properties/AssemblyInfo.cs (+0/-13)
src/Canonical.UbuntuOne.Common/Canonical.UbuntuOne.Common.csproj (+3/-0)
src/Canonical.UbuntuOne.Common/Properties/AssemblyInfo.cs (+0/-13)
src/Canonical.UbuntuOne.ProcessDispatcher.Tests/Canonical.UbuntuOne.ProcessDispatcher.Tests.csproj (+3/-0)
src/Canonical.UbuntuOne.ProcessDispatcher.Tests/Properties/AssemblyInfo.cs (+0/-13)
src/Canonical.UbuntuOne.ProcessDispatcher/Canonical.UbuntuOne.ProcessDispatcher.csproj (+3/-0)
src/Canonical.UbuntuOne.ProcessDispatcher/Properties/AssemblyInfo.cs (+0/-8)
src/ServiceTestApp/Properties/AssemblyInfo.cs (+0/-13)
src/ServiceTestApp/ServiceTestApp.csproj (+3/-0)
src/UbuntuOneClient/Properties/AssemblyInfo.cs (+0/-13)
src/UbuntuOneClient/UbuntuOneClient.csproj (+3/-0)
src/Version.cs (+15/-0)
To merge this branch: bzr merge lp:~mandel/ubuntuone-windows-installer/version_autoincrease
Reviewer Review Type Date Requested Status
Rodrigo Moya (community) Approve
John Lenton (community) Approve
Review via email: mp+31359@code.launchpad.net

Description of the change

Provides an update in the build script that will generate the version by using the number of months since start of project * 100 + current day in month as build number.

The start of the project is the date this lp project was created.

To post a comment you must log in.
Revision history for this message
John Lenton (chipaca) wrote :

Some silly typos:
«pass the number fo the current build»
«Generatesa a new version»
the /**/ in include is wrong (but you've just fixed it, right?)

So approve... with the above nits.

review: Approve
21. By Manuel de la Peña

Remove double *

Revision history for this message
John Lenton (chipaca) wrote :

also, note the branch now conflicts

22. By Manuel de la Peña

Fix typos.

23. By Manuel de la Peña

Merge with trunk.

Revision history for this message
Manuel de la Peña (mandel) wrote :

In case any one does find surprising the fact that Version.cs is present in the bzr tree. This is done to ensure that developers will have no issues and compilation errors with IDEs that use the MSBuild project files.

IDEs (VS2008, VS2010 and Mono) will load the project and if Version.cs is not present will fail the compilation, but Version.cs has to be inthe MsBuild project file because it is the one use by nant to perform the compilation.

Revision history for this message
Rodrigo Moya (rodrigo-moya) wrote :

Looks good

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'build.number'
2--- build.number 1970-01-01 00:00:00 +0000
3+++ build.number 2010-08-02 18:01:01 +0000
4@@ -0,0 +1,1 @@
5+1.0.0.0
6\ No newline at end of file
7
8=== modified file 'main.build'
9--- main.build 2010-07-30 09:44:09 +0000
10+++ main.build 2010-08-02 18:01:01 +0000
11@@ -2,8 +2,10 @@
12
13 <!-- the enviroment property allows to select which enviroment we are compiling to -->
14 <property name="enviroment" value="debug" />
15+ <!-- property that allows to pass where to place the build results -->
16 <property name="build_results" value="install/build_results" />
17-
18+ <!-- property that allows to pass the number for the current build. -->
19+ <property name="build" value="0" />
20 <target name="clean"
21 description="Removes all the different results of the last comilation if they exist">
22 <!-- delete all the different results from the previous build -->
23@@ -105,9 +107,32 @@
24
25 </target>
26
27+ <target name="generate-versionnumber"
28+ description="Generates a new version number according to the number of builds done in the continuous integration" >
29+ <attrib readonly="false">
30+ <fileset>
31+ <include name="build.number" />
32+ <include name="src/Version.cs" />
33+ </fileset>
34+ </attrib>
35+ <version buildtype="MonthDay" revisiontype="Automatic" startdate="2010-04-21"/>
36+ <asminfo output="src/Version.cs"
37+ language="CSharp">
38+ <imports>
39+ <import namespace="System.Reflection" />
40+ </imports>
41+ <attributes>
42+ <attribute type="AssemblyVersionAttribute"
43+ value="${buildnumber.major}.${buildnumber.minor}.${buildnumber.build}.${buildnumber.revision}" />
44+ <attribute type="AssemblyFileVersionAttribute"
45+ value="${buildnumber.major}.${buildnumber.minor}.${buildnumber.build}.${buildnumber.revision}" />
46+ </attributes>
47+ </asminfo>
48+ </target>
49+
50 <target name="build"
51 description="Compiles all the different projects that form part of the solution."
52- depends="clean, generate_protos">
53+ depends="clean, generate_protos, generate-versionnumber">
54 <!-- use the msbuild action to compile the solution -->
55 <msbuild project="src/UbuntuOne.sln">
56 <property name="Configuration" value="${enviroment}" />
57
58=== modified file 'src/Canonical.UbuntuOne.Client.Test/Canonical.UbuntuOne.Client.Test.csproj'
59--- src/Canonical.UbuntuOne.Client.Test/Canonical.UbuntuOne.Client.Test.csproj 2010-07-27 11:57:29 +0000
60+++ src/Canonical.UbuntuOne.Client.Test/Canonical.UbuntuOne.Client.Test.csproj 2010-08-02 18:01:01 +0000
61@@ -49,6 +49,9 @@
62 <Reference Include="System.Xml" />
63 </ItemGroup>
64 <ItemGroup>
65+ <Compile Include="..\Version.cs">
66+ <Link>Properties\Version.cs</Link>
67+ </Compile>
68 <Compile Include="Notification\NotificationEventArgsFixture.cs" />
69 <Compile Include="Notification\OperationCompletenessEventArgsFixture.cs" />
70 <Compile Include="Notification\RecentlyModifiedEventArgsFixture.cs" />
71
72=== modified file 'src/Canonical.UbuntuOne.Client.Test/Properties/AssemblyInfo.cs'
73--- src/Canonical.UbuntuOne.Client.Test/Properties/AssemblyInfo.cs 2010-07-27 11:57:29 +0000
74+++ src/Canonical.UbuntuOne.Client.Test/Properties/AssemblyInfo.cs 2010-08-02 18:01:01 +0000
75@@ -21,16 +21,3 @@
76
77 // The following GUID is for the ID of the typelib if this project is exposed to COM
78 [assembly: Guid("993407a9-fb9c-4678-bd7c-5c2fdf60eb51")]
79-
80-// Version information for an assembly consists of the following four values:
81-//
82-// Major Version
83-// Minor Version
84-// Build Number
85-// Revision
86-//
87-// You can specify all the values or you can default the Build and Revision Numbers
88-// by using the '*' as shown below:
89-// [assembly: AssemblyVersion("1.0.*")]
90-[assembly: AssemblyVersion("1.0.0.0")]
91-[assembly: AssemblyFileVersion("1.0.0.0")]
92
93=== modified file 'src/Canonical.UbuntuOne.Client.Views/Canonical.UbuntuOne.Client.Views.csproj'
94--- src/Canonical.UbuntuOne.Client.Views/Canonical.UbuntuOne.Client.Views.csproj 2010-07-28 11:06:07 +0000
95+++ src/Canonical.UbuntuOne.Client.Views/Canonical.UbuntuOne.Client.Views.csproj 2010-08-02 18:01:01 +0000
96@@ -109,6 +109,9 @@
97 </Compile>
98 </ItemGroup>
99 <ItemGroup>
100+ <Compile Include="..\Version.cs">
101+ <Link>Properties\Version.cs</Link>
102+ </Compile>
103 <Compile Include="PreferencesDialog.xaml.cs">
104 <DependentUpon>PreferencesDialog.xaml</DependentUpon>
105 </Compile>
106
107=== modified file 'src/Canonical.UbuntuOne.Client.Views/Properties/AssemblyInfo.cs'
108--- src/Canonical.UbuntuOne.Client.Views/Properties/AssemblyInfo.cs 2010-07-27 15:35:34 +0000
109+++ src/Canonical.UbuntuOne.Client.Views/Properties/AssemblyInfo.cs 2010-08-02 18:01:01 +0000
110@@ -41,16 +41,4 @@
111 )]
112
113
114-// Version information for an assembly consists of the following four values:
115-//
116-// Major Version
117-// Minor Version
118-// Build Number
119-// Revision
120-//
121-// You can specify all the values or you can default the Build and Revision Numbers
122-// by using the '*' as shown below:
123-// [assembly: AssemblyVersion("1.0.*")]
124-[assembly: AssemblyVersion("1.0.0.0")]
125-[assembly: AssemblyFileVersion("1.0.0.0")]
126 [assembly: NeutralResourcesLanguageAttribute("")]
127
128=== modified file 'src/Canonical.UbuntuOne.Client/Canonical.UbuntuOne.Client.csproj'
129--- src/Canonical.UbuntuOne.Client/Canonical.UbuntuOne.Client.csproj 2010-07-28 11:06:07 +0000
130+++ src/Canonical.UbuntuOne.Client/Canonical.UbuntuOne.Client.csproj 2010-08-02 18:01:01 +0000
131@@ -32,6 +32,9 @@
132 <ConsolePause>false</ConsolePause>
133 </PropertyGroup>
134 <ItemGroup>
135+ <Compile Include="..\Version.cs">
136+ <Link>Properties\Version.cs</Link>
137+ </Compile>
138 <Compile Include="Notification\INotificationIconView.cs" />
139 <Compile Include="Notification\NotificationIconPresenter.cs" />
140 <Compile Include="Notification\OperationCompletenessEventArgs.cs" />
141
142=== modified file 'src/Canonical.UbuntuOne.Client/Properties/AssemblyInfo.cs'
143--- src/Canonical.UbuntuOne.Client/Properties/AssemblyInfo.cs 2010-07-04 11:53:55 +0000
144+++ src/Canonical.UbuntuOne.Client/Properties/AssemblyInfo.cs 2010-08-02 18:01:01 +0000
145@@ -22,15 +22,3 @@
146 // The following GUID is for the ID of the typelib if this project is exposed to COM
147 [assembly: Guid("3c7586a6-40ca-463b-b12c-b0aed0f4cb92")]
148
149-// Version information for an assembly consists of the following four values:
150-//
151-// Major Version
152-// Minor Version
153-// Build Number
154-// Revision
155-//
156-// You can specify all the values or you can default the Build and Revision Numbers
157-// by using the '*' as shown below:
158-// [assembly: AssemblyVersion("1.0.*")]
159-[assembly: AssemblyVersion("1.0.0.0")]
160-[assembly: AssemblyFileVersion("1.0.0.0")]
161
162=== modified file 'src/Canonical.UbuntuOne.Common.Tests/Canonical.UbuntuOne.Common.Tests.csproj'
163--- src/Canonical.UbuntuOne.Common.Tests/Canonical.UbuntuOne.Common.Tests.csproj 2010-07-23 15:51:36 +0000
164+++ src/Canonical.UbuntuOne.Common.Tests/Canonical.UbuntuOne.Common.Tests.csproj 2010-08-02 18:01:01 +0000
165@@ -32,6 +32,9 @@
166 <ConsolePause>false</ConsolePause>
167 </PropertyGroup>
168 <ItemGroup>
169+ <Compile Include="..\Version.cs">
170+ <Link>Properties\Version.cs</Link>
171+ </Compile>
172 <Compile Include="Aop\DebugLogAfterCallInterceptorFixture.cs" />
173 <Compile Include="Aop\DebugLogAfterThrowInterceptorFixture.cs" />
174 <Compile Include="Container\DictionaryContainerFixture.cs" />
175
176=== modified file 'src/Canonical.UbuntuOne.Common.Tests/Properties/AssemblyInfo.cs'
177--- src/Canonical.UbuntuOne.Common.Tests/Properties/AssemblyInfo.cs 2010-07-05 17:17:01 +0000
178+++ src/Canonical.UbuntuOne.Common.Tests/Properties/AssemblyInfo.cs 2010-08-02 18:01:01 +0000
179@@ -21,16 +21,3 @@
180
181 // The following GUID is for the ID of the typelib if this project is exposed to COM
182 [assembly: Guid("15e0f5ae-077e-4598-8762-f4e56c5ed643")]
183-
184-// Version information for an assembly consists of the following four values:
185-//
186-// Major Version
187-// Minor Version
188-// Build Number
189-// Revision
190-//
191-// You can specify all the values or you can default the Build and Revision Numbers
192-// by using the '*' as shown below:
193-// [assembly: AssemblyVersion("1.0.*")]
194-[assembly: AssemblyVersion("1.0.0.0")]
195-[assembly: AssemblyFileVersion("1.0.0.0")]
196
197=== modified file 'src/Canonical.UbuntuOne.Common/Canonical.UbuntuOne.Common.csproj'
198--- src/Canonical.UbuntuOne.Common/Canonical.UbuntuOne.Common.csproj 2010-07-23 15:51:36 +0000
199+++ src/Canonical.UbuntuOne.Common/Canonical.UbuntuOne.Common.csproj 2010-08-02 18:01:01 +0000
200@@ -32,6 +32,9 @@
201 <ConsolePause>false</ConsolePause>
202 </PropertyGroup>
203 <ItemGroup>
204+ <Compile Include="..\Version.cs">
205+ <Link>Properties\Version.cs</Link>
206+ </Compile>
207 <Compile Include="Aop\AopResources.Designer.cs">
208 <AutoGen>True</AutoGen>
209 <DesignTime>True</DesignTime>
210
211=== modified file 'src/Canonical.UbuntuOne.Common/Properties/AssemblyInfo.cs'
212--- src/Canonical.UbuntuOne.Common/Properties/AssemblyInfo.cs 2010-07-21 10:06:45 +0000
213+++ src/Canonical.UbuntuOne.Common/Properties/AssemblyInfo.cs 2010-08-02 18:01:01 +0000
214@@ -21,19 +21,6 @@
215
216 // The following GUID is for the ID of the typelib if this project is exposed to COM
217 [assembly: Guid("8e0c62a4-085d-417a-b9d0-20b6ca8face1")]
218-
219-// Version information for an assembly consists of the following four values:
220-//
221-// Major Version
222-// Minor Version
223-// Build Number
224-// Revision
225-//
226-// You can specify all the values or you can default the Build and Revision Numbers
227-// by using the '*' as shown below:
228-// [assembly: AssemblyVersion("1.0.*")]
229-[assembly: AssemblyVersion("1.0.0.0")]
230-[assembly: AssemblyFileVersion("1.0.0.0")]
231 [assembly: InternalsVisibleTo("Canonical.UbuntuOne.Common.Tests")]
232 // add the internals to be visible to the Rhino mocks code
233 [assembly: InternalsVisibleTo("DynamicProxyGenAssembly2")]
234\ No newline at end of file
235
236=== modified file 'src/Canonical.UbuntuOne.ProcessDispatcher.Tests/Canonical.UbuntuOne.ProcessDispatcher.Tests.csproj'
237--- src/Canonical.UbuntuOne.ProcessDispatcher.Tests/Canonical.UbuntuOne.ProcessDispatcher.Tests.csproj 2010-07-13 09:12:00 +0000
238+++ src/Canonical.UbuntuOne.ProcessDispatcher.Tests/Canonical.UbuntuOne.ProcessDispatcher.Tests.csproj 2010-08-02 18:01:01 +0000
239@@ -52,6 +52,9 @@
240 <ConsolePause>false</ConsolePause>
241 </PropertyGroup>
242 <ItemGroup>
243+ <Compile Include="..\Version.cs">
244+ <Link>Properties\Version.cs</Link>
245+ </Compile>
246 <Compile Include="Properties\AssemblyInfo.cs" />
247 <Compile Include="Protobuf\ConvertFixture.cs" />
248 <Compile Include="Protobuf\SyncConfigurationMessageFactoryFixture.cs" />
249
250=== modified file 'src/Canonical.UbuntuOne.ProcessDispatcher.Tests/Properties/AssemblyInfo.cs'
251--- src/Canonical.UbuntuOne.ProcessDispatcher.Tests/Properties/AssemblyInfo.cs 2010-07-04 18:47:44 +0000
252+++ src/Canonical.UbuntuOne.ProcessDispatcher.Tests/Properties/AssemblyInfo.cs 2010-08-02 18:01:01 +0000
253@@ -21,16 +21,3 @@
254
255 // The following GUID is for the ID of the typelib if this project is exposed to COM
256 [assembly: Guid("7cd55b5d-85c4-44c9-8379-b23650ef40c8")]
257-
258-// Version information for an assembly consists of the following four values:
259-//
260-// Major Version
261-// Minor Version
262-// Build Number
263-// Revision
264-//
265-// You can specify all the values or you can default the Build and Revision Numbers
266-// by using the '*' as shown below:
267-// [assembly: AssemblyVersion("1.0.*")]
268-[assembly: AssemblyVersion("1.0.0.0")]
269-[assembly: AssemblyFileVersion("1.0.0.0")]
270
271=== modified file 'src/Canonical.UbuntuOne.ProcessDispatcher/Canonical.UbuntuOne.ProcessDispatcher.csproj'
272--- src/Canonical.UbuntuOne.ProcessDispatcher/Canonical.UbuntuOne.ProcessDispatcher.csproj 2010-07-28 12:55:29 +0000
273+++ src/Canonical.UbuntuOne.ProcessDispatcher/Canonical.UbuntuOne.ProcessDispatcher.csproj 2010-08-02 18:01:01 +0000
274@@ -67,6 +67,9 @@
275 </None>
276 </ItemGroup>
277 <ItemGroup>
278+ <Compile Include="..\Version.cs">
279+ <Link>Properties\Version.cs</Link>
280+ </Compile>
281 <Compile Include="Program.cs" />
282 <Compile Include="ProjectInstaller.cs">
283 <SubType>Component</SubType>
284
285=== modified file 'src/Canonical.UbuntuOne.ProcessDispatcher/Properties/AssemblyInfo.cs'
286--- src/Canonical.UbuntuOne.ProcessDispatcher/Properties/AssemblyInfo.cs 2010-07-04 18:47:44 +0000
287+++ src/Canonical.UbuntuOne.ProcessDispatcher/Properties/AssemblyInfo.cs 2010-08-02 18:01:01 +0000
288@@ -22,12 +22,4 @@
289 // This sets the default COM visibility of types in the assembly to invisible.
290 // If you need to expose a type to COM, use [ComVisible(true)] on that type.
291 [assembly: ComVisible(false)]
292-
293-// The assembly version has following format :
294-//
295-// Major.Minor.Build.Revision
296-//
297-// You can specify all the values or you can use the default the Revision and
298-// Build Numbers by using the '*' as shown below:
299-[assembly: AssemblyVersion("1.0.*")]
300 [assembly: InternalsVisibleTo("Canonical.UbuntuOne.ProcessDispatcher.Tests")]
301
302=== modified file 'src/ServiceTestApp/Properties/AssemblyInfo.cs'
303--- src/ServiceTestApp/Properties/AssemblyInfo.cs 2010-07-26 16:01:09 +0000
304+++ src/ServiceTestApp/Properties/AssemblyInfo.cs 2010-08-02 18:01:01 +0000
305@@ -21,16 +21,3 @@
306
307 // The following GUID is for the ID of the typelib if this project is exposed to COM
308 [assembly: Guid("be6f3304-10ed-4a11-88ed-cf93531fb577")]
309-
310-// Version information for an assembly consists of the following four values:
311-//
312-// Major Version
313-// Minor Version
314-// Build Number
315-// Revision
316-//
317-// You can specify all the values or you can default the Build and Revision Numbers
318-// by using the '*' as shown below:
319-// [assembly: AssemblyVersion("1.0.*")]
320-[assembly: AssemblyVersion("1.0.0.0")]
321-[assembly: AssemblyFileVersion("1.0.0.0")]
322
323=== modified file 'src/ServiceTestApp/ServiceTestApp.csproj'
324--- src/ServiceTestApp/ServiceTestApp.csproj 2010-07-26 16:01:09 +0000
325+++ src/ServiceTestApp/ServiceTestApp.csproj 2010-08-02 18:01:01 +0000
326@@ -58,6 +58,9 @@
327 <Reference Include="System.Xml" />
328 </ItemGroup>
329 <ItemGroup>
330+ <Compile Include="..\Version.cs">
331+ <Link>Properties\Version.cs</Link>
332+ </Compile>
333 <Compile Include="Program.cs" />
334 <Compile Include="Properties\AssemblyInfo.cs" />
335 </ItemGroup>
336
337=== modified file 'src/UbuntuOneClient/Properties/AssemblyInfo.cs'
338--- src/UbuntuOneClient/Properties/AssemblyInfo.cs 2010-07-28 11:03:35 +0000
339+++ src/UbuntuOneClient/Properties/AssemblyInfo.cs 2010-08-02 18:01:01 +0000
340@@ -40,18 +40,5 @@
341 // app, or any theme specific resource dictionaries)
342 )]
343
344-
345-// Version information for an assembly consists of the following four values:
346-//
347-// Major Version
348-// Minor Version
349-// Build Number
350-// Revision
351-//
352-// You can specify all the values or you can default the Build and Revision Numbers
353-// by using the '*' as shown below:
354-// [assembly: AssemblyVersion("1.0.*")]
355-[assembly: AssemblyVersion("1.0.0.0")]
356-[assembly: AssemblyFileVersion("1.0.0.0")]
357 // allow the test assembly to access the internals
358 [assembly: InternalsVisibleTo("UbuntuOneClient.Tests")]
359
360=== modified file 'src/UbuntuOneClient/UbuntuOneClient.csproj'
361--- src/UbuntuOneClient/UbuntuOneClient.csproj 2010-07-28 11:03:35 +0000
362+++ src/UbuntuOneClient/UbuntuOneClient.csproj 2010-08-02 18:01:01 +0000
363@@ -62,6 +62,9 @@
364 <Reference Include="PresentationFramework" />
365 </ItemGroup>
366 <ItemGroup>
367+ <Compile Include="..\Version.cs">
368+ <Link>Version.cs</Link>
369+ </Compile>
370 <Compile Include="ApplicationWrapper.cs" />
371 <Compile Include="IApplication.cs" />
372 <Compile Include="Program.cs" />
373
374=== added file 'src/Version.cs'
375--- src/Version.cs 1970-01-01 00:00:00 +0000
376+++ src/Version.cs 2010-08-02 18:01:01 +0000
377@@ -0,0 +1,15 @@
378+using System.Reflection;
379+
380+//------------------------------------------------------------------------------
381+// <auto-generated>
382+// This code was generated by a tool.
383+// Runtime Version:2.0.50727.4927
384+//
385+// Changes to this file may cause incorrect behavior and will be lost if
386+// the code is regenerated.
387+// </auto-generated>
388+//------------------------------------------------------------------------------
389+
390+[assembly: AssemblyVersionAttribute("1.0.0.0")]
391+[assembly: AssemblyFileVersionAttribute("1.0.0.0")]
392+

Subscribers

People subscribed via source and target branches

to all changes: