Merge lp:~mandel/ubuntuone-windows-installer/use_correct_folder_name into lp:ubuntuone-windows-installer/beta

Proposed by Manuel de la Peña
Status: Merged
Approved by: John Lenton
Approved revision: 176
Merge reported by: Manuel de la Peña
Merged at revision: not available
Proposed branch: lp:~mandel/ubuntuone-windows-installer/use_correct_folder_name
Merge into: lp:ubuntuone-windows-installer/beta
Prerequisite: lp:~mandel/ubuntuone-windows-installer/manual_sync_does_nothing
Diff against target: 304 lines (+210/-8)
6 files modified
src/Canonical.UbuntuOne.Client/Canonical.UbuntuOne.Client.csproj (+9/-0)
src/Canonical.UbuntuOne.Client/Notification/NotificationIconPresenter.cs (+4/-6)
src/Canonical.UbuntuOne.Client/Preferences/LoadPreferencesStartupTask.cs (+1/-1)
src/Canonical.UbuntuOne.Client/Preferences/PreferencesDialogPresenter.cs (+1/-1)
src/Canonical.UbuntuOne.Client/Resources.Designer.cs (+72/-0)
src/Canonical.UbuntuOne.Client/Resources.resx (+123/-0)
To merge this branch: bzr merge lp:~mandel/ubuntuone-windows-installer/use_correct_folder_name
Reviewer Review Type Date Requested Status
John Lenton (community) Approve
Review via email: mp+40544@code.launchpad.net

Commit message

Ensures that the default folder name is 'Ubuntu One'

Description of the change

Ensures that the default folder name is 'Ubuntu One'

To post a comment you must log in.
Revision history for this message
John Lenton (chipaca) :
review: Approve
177. By Manuel de la Peña

Added resources to point to the correct directory name.

178. By Manuel de la Peña

Updated solution

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Canonical.UbuntuOne.Client/Canonical.UbuntuOne.Client.csproj'
2--- src/Canonical.UbuntuOne.Client/Canonical.UbuntuOne.Client.csproj 2010-11-11 11:46:48 +0000
3+++ src/Canonical.UbuntuOne.Client/Canonical.UbuntuOne.Client.csproj 2010-11-11 11:46:48 +0000
4@@ -95,6 +95,11 @@
5 <Compile Include="Preferences\LoadPreferencesStartupTask.cs" />
6 <Compile Include="Preferences\PreferencesDialogPresenter.cs" />
7 <Compile Include="Properties\AssemblyInfo.cs" />
8+ <Compile Include="Resources.Designer.cs">
9+ <AutoGen>True</AutoGen>
10+ <DesignTime>True</DesignTime>
11+ <DependentUpon>Resources.resx</DependentUpon>
12+ </Compile>
13 <Compile Include="SyncDaemonClient.cs" />
14 </ItemGroup>
15 <ItemGroup>
16@@ -146,6 +151,10 @@
17 <LastGenOutput>NotificationResources.Designer.cs</LastGenOutput>
18 <SubType>Designer</SubType>
19 </EmbeddedResource>
20+ <EmbeddedResource Include="Resources.resx">
21+ <Generator>ResXFileCodeGenerator</Generator>
22+ <LastGenOutput>Resources.Designer.cs</LastGenOutput>
23+ </EmbeddedResource>
24 </ItemGroup>
25 <ItemGroup>
26 <EmbeddedResource Include="objects.xml" />
27
28=== modified file 'src/Canonical.UbuntuOne.Client/Notification/NotificationIconPresenter.cs'
29--- src/Canonical.UbuntuOne.Client/Notification/NotificationIconPresenter.cs 2010-10-20 11:18:55 +0000
30+++ src/Canonical.UbuntuOne.Client/Notification/NotificationIconPresenter.cs 2010-11-11 11:46:48 +0000
31@@ -18,12 +18,10 @@
32 */
33 using System;
34 using System.IO;
35-using System.ServiceModel;
36 using Canonical.Ubuntu.SSO;
37 using Canonical.UbuntuOne.Client.Preferences;
38 using Canonical.UbuntuOne.Common;
39 using Canonical.UbuntuOne.Common.Aop;
40-using Canonical.UbuntuOne.Common.Net;
41 using Canonical.UbuntuOne.Common.Utils;
42 using log4net;
43
44@@ -53,8 +51,8 @@
45 private ISSOCredentialsProvider _ssoProvider;
46 private ILog _logger;
47 private readonly object _loggerLock = new object();
48- private static string EventName = "UbuntuOneNotificationIconPresenter";
49- private static string ApplicationName = "UbuntuOne";
50+ private const string EventName = "UbuntuOneNotificationIconPresenter";
51+ private const string ApplicationName = "UbuntuOne";
52
53 #endregion
54
55@@ -167,7 +165,7 @@
56 static NotificationIconPresenter()
57 {
58 SharesLocation = Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments);
59- SyncsLocation = Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments), "UbuntuOne");
60+ SyncsLocation = Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments), Resources.DefaulDirectoryName);
61
62 }
63
64@@ -243,7 +241,7 @@
65
66 Logger.Info("Got the UbuntuOne credentials!");
67 var oneDir = Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments),
68- "UbuntuOne");
69+ Resources.DefaulDirectoryName);
70 // ensure that the path can be handled by the python code
71 oneDir = oneDir.Replace("\\", "\\\\");
72 SyncDaemon.ManualSync(
73
74=== modified file 'src/Canonical.UbuntuOne.Client/Preferences/LoadPreferencesStartupTask.cs'
75--- src/Canonical.UbuntuOne.Client/Preferences/LoadPreferencesStartupTask.cs 2010-10-20 11:18:55 +0000
76+++ src/Canonical.UbuntuOne.Client/Preferences/LoadPreferencesStartupTask.cs 2010-11-11 11:46:48 +0000
77@@ -109,7 +109,7 @@
78 if (args.ApplicationName != EventName) return;
79 Logger.Info("Got the UbuntuOne credentials!");
80 var oneDir = Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments),
81- "UbuntuOne");
82+ Resources.DefaulDirectoryName);
83 // ensure that the path can be handled by the python code
84 oneDir = oneDir.Replace("\\", "\\\\");
85 // call the ISyncService to perform the manual sync
86
87=== modified file 'src/Canonical.UbuntuOne.Client/Preferences/PreferencesDialogPresenter.cs'
88--- src/Canonical.UbuntuOne.Client/Preferences/PreferencesDialogPresenter.cs 2010-10-20 11:18:55 +0000
89+++ src/Canonical.UbuntuOne.Client/Preferences/PreferencesDialogPresenter.cs 2010-11-11 11:46:48 +0000
90@@ -116,7 +116,7 @@
91 if (args.ApplicationName != EventName) return;
92 Logger.Info("Got the UbuntuOne credentials!");
93 var oneDir = Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments),
94- "UbuntuOne");
95+ Resources.DefaulDirectoryName);
96 // ensure that the path can be handled by the python code
97 oneDir = oneDir.Replace("\\", "\\\\");
98 // call the ISyncService to perform the manual sync
99
100=== added file 'src/Canonical.UbuntuOne.Client/Resources.Designer.cs'
101--- src/Canonical.UbuntuOne.Client/Resources.Designer.cs 1970-01-01 00:00:00 +0000
102+++ src/Canonical.UbuntuOne.Client/Resources.Designer.cs 2010-11-11 11:46:48 +0000
103@@ -0,0 +1,72 @@
104+//------------------------------------------------------------------------------
105+// <auto-generated>
106+// This code was generated by a tool.
107+// Runtime Version:4.0.30319.1
108+//
109+// Changes to this file may cause incorrect behavior and will be lost if
110+// the code is regenerated.
111+// </auto-generated>
112+//------------------------------------------------------------------------------
113+
114+namespace Canonical.UbuntuOne.Client {
115+ using System;
116+
117+
118+ /// <summary>
119+ /// A strongly-typed resource class, for looking up localized strings, etc.
120+ /// </summary>
121+ // This class was auto-generated by the StronglyTypedResourceBuilder
122+ // class via a tool like ResGen or Visual Studio.
123+ // To add or remove a member, edit your .ResX file then rerun ResGen
124+ // with the /str option, or rebuild your VS project.
125+ [global::System.CodeDom.Compiler.GeneratedCodeAttribute("System.Resources.Tools.StronglyTypedResourceBuilder", "4.0.0.0")]
126+ [global::System.Diagnostics.DebuggerNonUserCodeAttribute()]
127+ [global::System.Runtime.CompilerServices.CompilerGeneratedAttribute()]
128+ internal class Resources {
129+
130+ private static global::System.Resources.ResourceManager resourceMan;
131+
132+ private static global::System.Globalization.CultureInfo resourceCulture;
133+
134+ [global::System.Diagnostics.CodeAnalysis.SuppressMessageAttribute("Microsoft.Performance", "CA1811:AvoidUncalledPrivateCode")]
135+ internal Resources() {
136+ }
137+
138+ /// <summary>
139+ /// Returns the cached ResourceManager instance used by this class.
140+ /// </summary>
141+ [global::System.ComponentModel.EditorBrowsableAttribute(global::System.ComponentModel.EditorBrowsableState.Advanced)]
142+ internal static global::System.Resources.ResourceManager ResourceManager {
143+ get {
144+ if (object.ReferenceEquals(resourceMan, null)) {
145+ global::System.Resources.ResourceManager temp = new global::System.Resources.ResourceManager("Canonical.UbuntuOne.Client.Resources", typeof(Resources).Assembly);
146+ resourceMan = temp;
147+ }
148+ return resourceMan;
149+ }
150+ }
151+
152+ /// <summary>
153+ /// Overrides the current thread's CurrentUICulture property for all
154+ /// resource lookups using this strongly typed resource class.
155+ /// </summary>
156+ [global::System.ComponentModel.EditorBrowsableAttribute(global::System.ComponentModel.EditorBrowsableState.Advanced)]
157+ internal static global::System.Globalization.CultureInfo Culture {
158+ get {
159+ return resourceCulture;
160+ }
161+ set {
162+ resourceCulture = value;
163+ }
164+ }
165+
166+ /// <summary>
167+ /// Looks up a localized string similar to Ubuntu One.
168+ /// </summary>
169+ internal static string DefaulDirectoryName {
170+ get {
171+ return ResourceManager.GetString("DefaulDirectoryName", resourceCulture);
172+ }
173+ }
174+ }
175+}
176
177=== added file 'src/Canonical.UbuntuOne.Client/Resources.resx'
178--- src/Canonical.UbuntuOne.Client/Resources.resx 1970-01-01 00:00:00 +0000
179+++ src/Canonical.UbuntuOne.Client/Resources.resx 2010-11-11 11:46:48 +0000
180@@ -0,0 +1,123 @@
181+<?xml version="1.0" encoding="utf-8"?>
182+<root>
183+ <!--
184+ Microsoft ResX Schema
185+
186+ Version 2.0
187+
188+ The primary goals of this format is to allow a simple XML format
189+ that is mostly human readable. The generation and parsing of the
190+ various data types are done through the TypeConverter classes
191+ associated with the data types.
192+
193+ Example:
194+
195+ ... ado.net/XML headers & schema ...
196+ <resheader name="resmimetype">text/microsoft-resx</resheader>
197+ <resheader name="version">2.0</resheader>
198+ <resheader name="reader">System.Resources.ResXResourceReader, System.Windows.Forms, ...</resheader>
199+ <resheader name="writer">System.Resources.ResXResourceWriter, System.Windows.Forms, ...</resheader>
200+ <data name="Name1"><value>this is my long string</value><comment>this is a comment</comment></data>
201+ <data name="Color1" type="System.Drawing.Color, System.Drawing">Blue</data>
202+ <data name="Bitmap1" mimetype="application/x-microsoft.net.object.binary.base64">
203+ <value>[base64 mime encoded serialized .NET Framework object]</value>
204+ </data>
205+ <data name="Icon1" type="System.Drawing.Icon, System.Drawing" mimetype="application/x-microsoft.net.object.bytearray.base64">
206+ <value>[base64 mime encoded string representing a byte array form of the .NET Framework object]</value>
207+ <comment>This is a comment</comment>
208+ </data>
209+
210+ There are any number of "resheader" rows that contain simple
211+ name/value pairs.
212+
213+ Each data row contains a name, and value. The row also contains a
214+ type or mimetype. Type corresponds to a .NET class that support
215+ text/value conversion through the TypeConverter architecture.
216+ Classes that don't support this are serialized and stored with the
217+ mimetype set.
218+
219+ The mimetype is used for serialized objects, and tells the
220+ ResXResourceReader how to depersist the object. This is currently not
221+ extensible. For a given mimetype the value must be set accordingly:
222+
223+ Note - application/x-microsoft.net.object.binary.base64 is the format
224+ that the ResXResourceWriter will generate, however the reader can
225+ read any of the formats listed below.
226+
227+ mimetype: application/x-microsoft.net.object.binary.base64
228+ value : The object must be serialized with
229+ : System.Runtime.Serialization.Formatters.Binary.BinaryFormatter
230+ : and then encoded with base64 encoding.
231+
232+ mimetype: application/x-microsoft.net.object.soap.base64
233+ value : The object must be serialized with
234+ : System.Runtime.Serialization.Formatters.Soap.SoapFormatter
235+ : and then encoded with base64 encoding.
236+
237+ mimetype: application/x-microsoft.net.object.bytearray.base64
238+ value : The object must be serialized into a byte array
239+ : using a System.ComponentModel.TypeConverter
240+ : and then encoded with base64 encoding.
241+ -->
242+ <xsd:schema id="root" xmlns="" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:msdata="urn:schemas-microsoft-com:xml-msdata">
243+ <xsd:import namespace="http://www.w3.org/XML/1998/namespace" />
244+ <xsd:element name="root" msdata:IsDataSet="true">
245+ <xsd:complexType>
246+ <xsd:choice maxOccurs="unbounded">
247+ <xsd:element name="metadata">
248+ <xsd:complexType>
249+ <xsd:sequence>
250+ <xsd:element name="value" type="xsd:string" minOccurs="0" />
251+ </xsd:sequence>
252+ <xsd:attribute name="name" use="required" type="xsd:string" />
253+ <xsd:attribute name="type" type="xsd:string" />
254+ <xsd:attribute name="mimetype" type="xsd:string" />
255+ <xsd:attribute ref="xml:space" />
256+ </xsd:complexType>
257+ </xsd:element>
258+ <xsd:element name="assembly">
259+ <xsd:complexType>
260+ <xsd:attribute name="alias" type="xsd:string" />
261+ <xsd:attribute name="name" type="xsd:string" />
262+ </xsd:complexType>
263+ </xsd:element>
264+ <xsd:element name="data">
265+ <xsd:complexType>
266+ <xsd:sequence>
267+ <xsd:element name="value" type="xsd:string" minOccurs="0" msdata:Ordinal="1" />
268+ <xsd:element name="comment" type="xsd:string" minOccurs="0" msdata:Ordinal="2" />
269+ </xsd:sequence>
270+ <xsd:attribute name="name" type="xsd:string" use="required" msdata:Ordinal="1" />
271+ <xsd:attribute name="type" type="xsd:string" msdata:Ordinal="3" />
272+ <xsd:attribute name="mimetype" type="xsd:string" msdata:Ordinal="4" />
273+ <xsd:attribute ref="xml:space" />
274+ </xsd:complexType>
275+ </xsd:element>
276+ <xsd:element name="resheader">
277+ <xsd:complexType>
278+ <xsd:sequence>
279+ <xsd:element name="value" type="xsd:string" minOccurs="0" msdata:Ordinal="1" />
280+ </xsd:sequence>
281+ <xsd:attribute name="name" type="xsd:string" use="required" />
282+ </xsd:complexType>
283+ </xsd:element>
284+ </xsd:choice>
285+ </xsd:complexType>
286+ </xsd:element>
287+ </xsd:schema>
288+ <resheader name="resmimetype">
289+ <value>text/microsoft-resx</value>
290+ </resheader>
291+ <resheader name="version">
292+ <value>2.0</value>
293+ </resheader>
294+ <resheader name="reader">
295+ <value>System.Resources.ResXResourceReader, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
296+ </resheader>
297+ <resheader name="writer">
298+ <value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
299+ </resheader>
300+ <data name="DefaulDirectoryName" xml:space="preserve">
301+ <value>Ubuntu One</value>
302+ </data>
303+</root>
304\ No newline at end of file

Subscribers

People subscribed via source and target branches

to all changes: