Merge lp:~mandel/ubuntuone-windows-installer/remove_syncdaemon_shit_from_msi into lp:ubuntuone-windows-installer/beta

Proposed by Manuel de la Peña
Status: Merged
Approved by: Vincenzo Di Somma
Approved revision: 58
Merged at revision: 70
Proposed branch: lp:~mandel/ubuntuone-windows-installer/remove_syncdaemon_shit_from_msi
Merge into: lp:ubuntuone-windows-installer/beta
Prerequisite: lp:~mandel/ubuntuone-windows-installer/remove_syncdaemon_shit_the_second
Diff against target: 74 lines (+0/-35)
3 files modified
install/UbuntuOne.wxs (+0/-27)
src/Canonical.UbuntuOne.ProcessDispatcher.Tests/Canonical.UbuntuOne.ProcessDispatcher.Tests.csproj (+0/-4)
src/Canonical.UbuntuOne.ProcessDispatcher/Canonical.UbuntuOne.ProcessDispatcher.csproj (+0/-4)
To merge this branch: bzr merge lp:~mandel/ubuntuone-windows-installer/remove_syncdaemon_shit_from_msi
Reviewer Review Type Date Requested Status
Vincenzo Di Somma (community) Approve
John Lenton (community) Approve
Review via email: mp+33566@code.launchpad.net

Description of the change

Removes the dlls that are used for the protobuf implementation from the msi package.

To post a comment you must log in.
Revision history for this message
John Lenton (chipaca) :
review: Approve
Revision history for this message
Vincenzo Di Somma (vds) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'install/UbuntuOne.wxs'
2--- install/UbuntuOne.wxs 2010-08-18 12:44:45 +0000
3+++ install/UbuntuOne.wxs 2010-08-24 17:51:38 +0000
4@@ -136,30 +136,6 @@
5 Source="build_results\Daemon\log4net.dll"
6 KeyPath="yes"/>
7 </Component>
8- <Component Id="ProtobufNetComponent"
9- Guid="24d3a3a0-94b7-11df-981c-0800200c9a66">
10- <File Id="protobufnet.dll"
11- Name="protobuf-net.dll"
12- DiskId="1"
13- Source="build_results\Daemon\protobuf-net.dll"
14- KeyPath="yes"/>
15- </Component>
16- <Component Id="ProtobufPdbComponent"
17- Guid="309dd3e0-94b7-11df-981c-0800200c9a66">
18- <File Id="protobufnet.pdb"
19- Name="protobuf-net.pdb"
20- DiskId="1"
21- Source="build_results\Daemon\protobuf-net.pdb"
22- KeyPath="yes"/>
23- </Component>
24- <Component Id="ProtobufConfigComponent"
25- Guid="44ba72c0-94b7-11df-981c-0800200c9a66">
26- <File Id="protobufnet.xml"
27- Name="protobuf-net.xml"
28- DiskId="1"
29- Source="build_results\Daemon\protobuf-net.xml"
30- KeyPath="yes"/>
31- </Component>
32 <Component Id="SpringAopComponent"
33 Guid="5431cc80-94b7-11df-981c-0800200c9a66">
34 <File Id="Spring.Aop.dll"
35@@ -446,9 +422,6 @@
36 <ComponentRef Id="CommonLoggingLog4NetComponent" />
37 <ComponentRef Id="DotUpdaterLib" />
38 <ComponentRef Id="Log4NetComponent" />
39- <ComponentRef Id="ProtobufNetComponent" />
40- <ComponentRef Id="ProtobufPdbComponent" />
41- <ComponentRef Id="ProtobufConfigComponent" />
42 <ComponentRef Id="SpringAopComponent" />
43 <ComponentRef Id="SpringAopConfigComponent" />
44 <ComponentRef Id="SpringCoreComponent" />
45
46=== modified file 'src/Canonical.UbuntuOne.ProcessDispatcher.Tests/Canonical.UbuntuOne.ProcessDispatcher.Tests.csproj'
47--- src/Canonical.UbuntuOne.ProcessDispatcher.Tests/Canonical.UbuntuOne.ProcessDispatcher.Tests.csproj 2010-08-24 17:51:38 +0000
48+++ src/Canonical.UbuntuOne.ProcessDispatcher.Tests/Canonical.UbuntuOne.ProcessDispatcher.Tests.csproj 2010-08-24 17:51:38 +0000
49@@ -86,10 +86,6 @@
50 <SpecificVersion>False</SpecificVersion>
51 <HintPath>..\..\lib\Nunit\nunit.framework.dll</HintPath>
52 </Reference>
53- <Reference Include="protobuf-net, Version=1.0.0.282, Culture=neutral, PublicKeyToken=257b51d87d2e4d67">
54- <SpecificVersion>False</SpecificVersion>
55- <HintPath>..\..\lib\Protobuf-net\protobuf-net.dll</HintPath>
56- </Reference>
57 <Reference Include="Rhino.Mocks, Version=3.6.0.0, Culture=neutral, PublicKeyToken=0b3305902db7183f, processorArchitecture=MSIL">
58 <SpecificVersion>False</SpecificVersion>
59 <HintPath>..\..\lib\RhinoMocks\Rhino.Mocks.dll</HintPath>
60
61=== modified file 'src/Canonical.UbuntuOne.ProcessDispatcher/Canonical.UbuntuOne.ProcessDispatcher.csproj'
62--- src/Canonical.UbuntuOne.ProcessDispatcher/Canonical.UbuntuOne.ProcessDispatcher.csproj 2010-08-24 17:51:38 +0000
63+++ src/Canonical.UbuntuOne.ProcessDispatcher/Canonical.UbuntuOne.ProcessDispatcher.csproj 2010-08-24 17:51:38 +0000
64@@ -119,10 +119,6 @@
65 <Reference Include="System.Configuration.Install" />
66 <Reference Include="System.ServiceModel">
67 </Reference>
68- <Reference Include="protobuf-net, Version=1.0.0.282, Culture=neutral, PublicKeyToken=257b51d87d2e4d67">
69- <SpecificVersion>False</SpecificVersion>
70- <HintPath>..\..\lib\Protobuf-net\protobuf-net.dll</HintPath>
71- </Reference>
72 <Reference Include="System.Core">
73 <RequiredTargetFramework>3.5</RequiredTargetFramework>
74 </Reference>

Subscribers

People subscribed via source and target branches

to all changes: