Merge lp:~mandel/ubuntuone-windows-installer/fix_xml_warnings_1 into lp:ubuntuone-windows-installer/beta
- fix_xml_warnings_1
- Merge into beta
Proposed by
Manuel de la Peña
Status: | Merged |
---|---|
Approved by: | Rodrigo Moya |
Approved revision: | 29 |
Merged at revision: | 54 |
Proposed branch: | lp:~mandel/ubuntuone-windows-installer/fix_xml_warnings_1 |
Merge into: | lp:ubuntuone-windows-installer/beta |
Prerequisite: | lp:~mandel/ubuntuone-windows-installer/add_client_installer |
Diff against target: |
843 lines (+275/-33) 30 files modified
src/Canonical.UbuntuOne.Common/Aop/DebugLogAfterCallInterceptor.cs (+7/-0) src/Canonical.UbuntuOne.Common/Aop/DebugLogBeforeCallInterceptor.cs (+8/-0) src/Canonical.UbuntuOne.Common/Aop/LoggingInterceptor.cs (+5/-0) src/Canonical.UbuntuOne.Common/Container/DictionaryContainer.cs (+7/-0) src/Canonical.UbuntuOne.Common/Container/IContainer.cs (+4/-0) src/Canonical.UbuntuOne.Common/Container/SpringContainer.cs (+26/-12) src/Canonical.UbuntuOne.Common/DataContracts/QueueItemData.cs (+4/-0) src/Canonical.UbuntuOne.Common/DataContracts/ShareData.cs (+3/-0) src/Canonical.UbuntuOne.Common/DataContracts/ShareResponseData.cs (+4/-1) src/Canonical.UbuntuOne.Common/DataContracts/ThrottlingData.cs (+4/-0) src/Canonical.UbuntuOne.Common/IProcessManager.cs (+4/-0) src/Canonical.UbuntuOne.Common/OperationContracts/ISyncConfiguration.cs (+4/-0) src/Canonical.UbuntuOne.Common/OperationContracts/ISyncDaemon.cs (+1/-1) src/Canonical.UbuntuOne.Common/OperationContracts/ISyncDaemonClient.cs (+4/-4) src/Canonical.UbuntuOne.Common/OperationContracts/ISyncShares.cs (+4/-0) src/Canonical.UbuntuOne.Common/ProcessManagementException.cs (+14/-0) src/Canonical.UbuntuOne.Common/SyncDaemonException.cs (+17/-0) src/Canonical.UbuntuOne.Common/Update/Enumerators.cs (+6/-0) src/Canonical.UbuntuOne.Common/Update/IUpdatingPresenter.cs (+4/-0) src/Canonical.UbuntuOne.Common/Update/IUpdatingView.cs (+4/-0) src/Canonical.UbuntuOne.Common/Update/SelfUpdateException.cs (+14/-0) src/Canonical.UbuntuOne.Common/Update/Updater.cs (+39/-0) src/Canonical.UbuntuOne.Common/Update/UpdatingPresenter.cs (+13/-0) src/Canonical.UbuntuOne.Common/Utils/ApplicationWrapper.cs (+9/-0) src/Canonical.UbuntuOne.Common/Utils/ExplorerException.cs (+18/-0) src/Canonical.UbuntuOne.Common/Utils/IExplorer.cs (+4/-0) src/Canonical.UbuntuOne.Common/Utils/IWebbrowser.cs (+4/-0) src/Canonical.UbuntuOne.Common/Utils/Webbrowser.cs (+6/-0) src/Canonical.UbuntuOne.Common/Validation/EqualityValidationExtensions.cs (+28/-13) src/Canonical.UbuntuOne.Common/Validation/ValidationExtensions.cs (+6/-2) |
To merge this branch: | bzr merge lp:~mandel/ubuntuone-windows-installer/fix_xml_warnings_1 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Rodrigo Moya (community) | Approve | ||
Vincenzo Di Somma (community) | Approve | ||
Review via email: mp+31816@code.launchpad.net |
Commit message
Description of the change
First clean of the warnings given by the XmlDoc tool during compilation. This should make the docs better for community developers.
To post a comment you must log in.
- 29. By Manuel de la Peña
-
Merge with parent.
Revision history for this message
Rodrigo Moya (rodrigo-moya) : | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1 | === modified file 'src/Canonical.UbuntuOne.Common/Aop/DebugLogAfterCallInterceptor.cs' |
2 | --- src/Canonical.UbuntuOne.Common/Aop/DebugLogAfterCallInterceptor.cs 2010-07-26 11:09:17 +0000 |
3 | +++ src/Canonical.UbuntuOne.Common/Aop/DebugLogAfterCallInterceptor.cs 2010-08-09 16:39:47 +0000 |
4 | @@ -32,6 +32,13 @@ |
5 | { |
6 | private readonly ILog _logger = LogManager.GetLogger(typeof (DebugLogAfterCallInterceptor)); |
7 | |
8 | + /// <summary> |
9 | + /// Callback after a given method successfully returned. |
10 | + /// </summary> |
11 | + /// <param name="returnValue">The value returned by the method, if any</param> |
12 | + /// <param name="method">Method being invoked</param> |
13 | + /// <param name="args">Arguments to the method</param> |
14 | + /// <param name="target">Target of the method invocation. May be null.</param> |
15 | public void AfterReturning(object returnValue, MethodInfo method, object[] args, object target) |
16 | { |
17 | if(Logger == null) |
18 | |
19 | === modified file 'src/Canonical.UbuntuOne.Common/Aop/DebugLogBeforeCallInterceptor.cs' |
20 | --- src/Canonical.UbuntuOne.Common/Aop/DebugLogBeforeCallInterceptor.cs 2010-07-26 11:09:17 +0000 |
21 | +++ src/Canonical.UbuntuOne.Common/Aop/DebugLogBeforeCallInterceptor.cs 2010-08-09 16:39:47 +0000 |
22 | @@ -48,6 +48,14 @@ |
23 | |
24 | #endregion |
25 | |
26 | + /// <summary> |
27 | + /// This is the method that will be executed by the advice before the execution of the |
28 | + /// actual method to with the advice was added. |
29 | + /// </summary> |
30 | + /// <param name="method">The MethodInfo of the method to which the advice was added.</param> |
31 | + /// <param name="args">The arguments that have been passed to execute the method with |
32 | + /// the advice.</param> |
33 | + /// <param name="target">The object that is the target of the method execution.</param> |
34 | public void Before(MethodInfo method, object[] args, object target) |
35 | { |
36 | if(Logger == null) |
37 | |
38 | === modified file 'src/Canonical.UbuntuOne.Common/Aop/LoggingInterceptor.cs' |
39 | --- src/Canonical.UbuntuOne.Common/Aop/LoggingInterceptor.cs 2010-07-26 11:09:17 +0000 |
40 | +++ src/Canonical.UbuntuOne.Common/Aop/LoggingInterceptor.cs 2010-08-09 16:39:47 +0000 |
41 | @@ -35,6 +35,11 @@ |
42 | /// </summary> |
43 | internal ILog Logger { get; set; } |
44 | |
45 | + /// <summary> |
46 | + /// Get the logger to be used with a given object. |
47 | + /// </summary> |
48 | + /// <param name="caller">The caller object whose logger we want to retrieve.</param> |
49 | + /// <returns>An ILog object that can be used to log the operations of the caller object.</returns> |
50 | protected ILog GetLogger(Object caller) |
51 | { |
52 | return LogManager.GetLogger(caller.GetType()); |
53 | |
54 | === modified file 'src/Canonical.UbuntuOne.Common/Container/DictionaryContainer.cs' |
55 | --- src/Canonical.UbuntuOne.Common/Container/DictionaryContainer.cs 2010-07-23 15:47:32 +0000 |
56 | +++ src/Canonical.UbuntuOne.Common/Container/DictionaryContainer.cs 2010-08-09 16:39:47 +0000 |
57 | @@ -23,6 +23,10 @@ |
58 | |
59 | namespace Canonical.UbuntuOne.Common.Container |
60 | { |
61 | + /// <summary> |
62 | + /// Basic container that is implemented through the use of a dictionary. This container is not |
63 | + /// recomended for everyday use but more for testing purposes. |
64 | + /// </summary> |
65 | public class DictionaryContainer : IContainer |
66 | { |
67 | #region Private variables |
68 | @@ -55,6 +59,9 @@ |
69 | return result; |
70 | } |
71 | |
72 | + /// <summary> |
73 | + /// Cleans this instance. |
74 | + /// </summary> |
75 | public void Clear() |
76 | { |
77 | _types.Clear(); |
78 | |
79 | === modified file 'src/Canonical.UbuntuOne.Common/Container/IContainer.cs' |
80 | --- src/Canonical.UbuntuOne.Common/Container/IContainer.cs 2010-07-23 15:47:32 +0000 |
81 | +++ src/Canonical.UbuntuOne.Common/Container/IContainer.cs 2010-08-09 16:39:47 +0000 |
82 | @@ -19,6 +19,10 @@ |
83 | */ |
84 | namespace Canonical.UbuntuOne.Common.Container |
85 | { |
86 | + /// <summary> |
87 | + /// Interface to be implemented by those objects that provide the behaviour that would be |
88 | + /// expected by an Inversion Of Control container. |
89 | + /// </summary> |
90 | public interface IContainer |
91 | { |
92 | /// <summary> |
93 | |
94 | === modified file 'src/Canonical.UbuntuOne.Common/Container/SpringContainer.cs' |
95 | --- src/Canonical.UbuntuOne.Common/Container/SpringContainer.cs 2010-07-23 15:47:32 +0000 |
96 | +++ src/Canonical.UbuntuOne.Common/Container/SpringContainer.cs 2010-08-09 16:39:47 +0000 |
97 | @@ -174,6 +174,14 @@ |
98 | |
99 | #region IDisposable Members |
100 | |
101 | + /// <summary> |
102 | + /// Performs application-defined tasks associated with freeing, releasing, or resetting unmanaged resources. |
103 | + /// </summary> |
104 | + /// <remarks> |
105 | + /// Use this method to close or release unmanaged resources such as files, streams, and handles held by |
106 | + /// an instance of the class that implements this interface. By convention, this method is used for all |
107 | + /// tasks associated with freeing resources held by an object, or preparing an object for reuse. |
108 | + /// </remarks> |
109 | public void Dispose() |
110 | { |
111 | Dispose(true); |
112 | @@ -183,13 +191,17 @@ |
113 | GC.SuppressFinalize(this); |
114 | } |
115 | |
116 | - // Dispose(bool disposing) executes in two distinct scenarios. |
117 | - // If disposing equals true, the method has been called directly |
118 | - // or indirectly by a user's code. Managed and unmanaged resources |
119 | - // can be disposed. |
120 | - // If disposing equals false, the method has been called by the |
121 | - // runtime from inside the finalizer and you should not reference |
122 | - // other objects. Only unmanaged resources can be disposed. |
123 | + /// <summary> |
124 | + /// Dispose(bool disposing) executes in two distinct scenarios. |
125 | + /// If disposing equals true, the method has been called directly |
126 | + /// or indirectly by a user's code. Managed and unmanaged resources |
127 | + /// can be disposed. |
128 | + /// If disposing equals false, the method has been called by the |
129 | + /// runtime from inside the finalizer and you should not reference |
130 | + /// other objects. Only unmanaged resources can be disposed. |
131 | + /// </summary> |
132 | + /// <param name="disposing">A method that is used to indicate if the |
133 | + /// dispose method was directly called by the user of by the system.</param> |
134 | protected virtual void Dispose(bool disposing) |
135 | { |
136 | // Check to see if Dispose has already been called. |
137 | @@ -214,11 +226,13 @@ |
138 | _disposed = true; |
139 | } |
140 | |
141 | - // Use C# destructor syntax for finalization code. |
142 | - // This destructor will run only if the Dispose method |
143 | - // does not get called. |
144 | - // It gives your base class the opportunity to finalize. |
145 | - // Do not provide destructors in types derived from this class. |
146 | + /// <summary> |
147 | + /// Use C# destructor syntax for finalization code. |
148 | + /// This destructor will run only if the Dispose method |
149 | + /// does not get called. |
150 | + /// It gives your base class the opportunity to finalize. |
151 | + /// Do not provide destructors in types derived from this class. |
152 | + /// </summary> |
153 | ~SpringContainer() |
154 | { |
155 | // Do not re-create Dispose clean-up code here. |
156 | |
157 | === modified file 'src/Canonical.UbuntuOne.Common/DataContracts/QueueItemData.cs' |
158 | --- src/Canonical.UbuntuOne.Common/DataContracts/QueueItemData.cs 2010-07-07 10:41:49 +0000 |
159 | +++ src/Canonical.UbuntuOne.Common/DataContracts/QueueItemData.cs 2010-08-09 16:39:47 +0000 |
160 | @@ -28,6 +28,10 @@ |
161 | public class QueueItemData : NodeData |
162 | { |
163 | //TODO: This should be an enum never a string |
164 | + /// <summary> |
165 | + /// Gets and sets the string that represents the operation to be performed |
166 | + /// on the node. |
167 | + /// </summary> |
168 | [DataMember] |
169 | public string Operation { get; set; } |
170 | } |
171 | |
172 | === modified file 'src/Canonical.UbuntuOne.Common/DataContracts/ShareData.cs' |
173 | --- src/Canonical.UbuntuOne.Common/DataContracts/ShareData.cs 2010-07-07 10:41:49 +0000 |
174 | +++ src/Canonical.UbuntuOne.Common/DataContracts/ShareData.cs 2010-08-09 16:39:47 +0000 |
175 | @@ -21,6 +21,9 @@ |
176 | |
177 | namespace Canonical.UbuntuOne.Common |
178 | { |
179 | + /// <summary> |
180 | + /// Data contract that describes the data of a Share in Ubuntu One. |
181 | + /// </summary> |
182 | [DataContract] |
183 | public class ShareData : NodeData |
184 | { |
185 | |
186 | === modified file 'src/Canonical.UbuntuOne.Common/DataContracts/ShareResponseData.cs' |
187 | --- src/Canonical.UbuntuOne.Common/DataContracts/ShareResponseData.cs 2010-07-07 10:41:49 +0000 |
188 | +++ src/Canonical.UbuntuOne.Common/DataContracts/ShareResponseData.cs 2010-08-09 16:39:47 +0000 |
189 | @@ -19,8 +19,11 @@ |
190 | */ |
191 | namespace Canonical.UbuntuOne.Common |
192 | { |
193 | + /// <summary> |
194 | + /// Class that represents the data of a reponse to a sahre request. |
195 | + /// </summary> |
196 | public class ShareResponseData |
197 | { |
198 | - |
199 | + // TODO: Implement class, talk with verterok |
200 | } |
201 | } |
202 | |
203 | === modified file 'src/Canonical.UbuntuOne.Common/DataContracts/ThrottlingData.cs' |
204 | --- src/Canonical.UbuntuOne.Common/DataContracts/ThrottlingData.cs 2010-07-07 10:41:49 +0000 |
205 | +++ src/Canonical.UbuntuOne.Common/DataContracts/ThrottlingData.cs 2010-08-09 16:39:47 +0000 |
206 | @@ -21,6 +21,10 @@ |
207 | |
208 | namespace Canonical.UbuntuOne.Common |
209 | { |
210 | + /// <summary> |
211 | + /// Data contract that is used to transfer the throttling information of the |
212 | + /// setting of the sync daemon. |
213 | + /// </summary> |
214 | [DataContract] |
215 | public class ThrottlingData |
216 | { |
217 | |
218 | === modified file 'src/Canonical.UbuntuOne.Common/IProcessManager.cs' |
219 | --- src/Canonical.UbuntuOne.Common/IProcessManager.cs 2010-07-07 10:41:49 +0000 |
220 | +++ src/Canonical.UbuntuOne.Common/IProcessManager.cs 2010-08-09 16:39:47 +0000 |
221 | @@ -19,6 +19,10 @@ |
222 | */ |
223 | namespace Canonical.UbuntuOne.Common |
224 | { |
225 | + /// <summary> |
226 | + /// A process manager allows to perform management task on processes in the system. The manager |
227 | + /// allows to star and stop a process as well as to query if the process is running. |
228 | + /// </summary> |
229 | public interface IProcessManager |
230 | { |
231 | /// <summary> |
232 | |
233 | === modified file 'src/Canonical.UbuntuOne.Common/OperationContracts/ISyncConfiguration.cs' |
234 | --- src/Canonical.UbuntuOne.Common/OperationContracts/ISyncConfiguration.cs 2010-08-09 16:39:46 +0000 |
235 | +++ src/Canonical.UbuntuOne.Common/OperationContracts/ISyncConfiguration.cs 2010-08-09 16:39:47 +0000 |
236 | @@ -21,6 +21,10 @@ |
237 | |
238 | namespace Canonical.UbuntuOne.Common |
239 | { |
240 | + /// <summary> |
241 | + /// Interface to be implemented by those object that allows to interact with the |
242 | + /// different setting of the sync daemon. |
243 | + /// </summary> |
244 | [ServiceContract( |
245 | Name = "SyncConfiguration", |
246 | Namespace = "http://one.ubuntu.com/syncconfiguration", |
247 | |
248 | === modified file 'src/Canonical.UbuntuOne.Common/OperationContracts/ISyncDaemon.cs' |
249 | --- src/Canonical.UbuntuOne.Common/OperationContracts/ISyncDaemon.cs 2010-08-09 16:39:46 +0000 |
250 | +++ src/Canonical.UbuntuOne.Common/OperationContracts/ISyncDaemon.cs 2010-08-09 16:39:47 +0000 |
251 | @@ -89,7 +89,7 @@ |
252 | |
253 | /// <summary> |
254 | /// Allows the client to schedule the share and node be next in the |
255 | - // queue of waiting commands. |
256 | + /// queue of waiting commands. |
257 | /// </summary> |
258 | /// <param name="shareId">The unique id that describes the share.</param> |
259 | /// <param name="nodeId">The unique id that describes the node.</param> |
260 | |
261 | === modified file 'src/Canonical.UbuntuOne.Common/OperationContracts/ISyncDaemonClient.cs' |
262 | --- src/Canonical.UbuntuOne.Common/OperationContracts/ISyncDaemonClient.cs 2010-07-08 14:45:50 +0000 |
263 | +++ src/Canonical.UbuntuOne.Common/OperationContracts/ISyncDaemonClient.cs 2010-08-09 16:39:47 +0000 |
264 | @@ -21,13 +21,16 @@ |
265 | |
266 | namespace Canonical.UbuntuOne.Common |
267 | { |
268 | + /// <summary> |
269 | + /// Interface to be implementedby a sync daemon client that wants to interact with the |
270 | + /// daemon that manages the Ubuntu One storage in a machine. |
271 | + /// </summary> |
272 | [ServiceContract(Namespace = "http://one.ubuntu.com/client")] |
273 | public interface ISyncDaemonClient |
274 | { |
275 | /// <summary> |
276 | /// Callback performed when a download starts. |
277 | /// </summary> |
278 | - /// <param name="path">The path being downloaded.</param> |
279 | /// <param name="data">The information of the download that is in process.</param> |
280 | [OperationContract(IsOneWay = true)] |
281 | void OnDownloadStarted(DownloadData data); |
282 | @@ -35,7 +38,6 @@ |
283 | /// <summary> |
284 | /// Callback performed when a download finished. |
285 | /// </summary> |
286 | - /// <param name="path">The path of the download that was finished.</param> |
287 | /// <param name="data">The information of the download that was finished.</param> |
288 | [OperationContract(IsOneWay = true)] |
289 | void OnDownloadFinished(DownloadData data); |
290 | @@ -43,7 +45,6 @@ |
291 | /// <summary> |
292 | /// Callback performed when an uploaded has been started. |
293 | /// </summary> |
294 | - /// <param name="path">The path of the uploading file.</param> |
295 | /// <param name="data">The information of the upload.</param> |
296 | [OperationContract(IsOneWay = true)] |
297 | void OnUploadStarted(UploadData data); |
298 | @@ -51,7 +52,6 @@ |
299 | /// <summary> |
300 | /// Calback performed when and upload has finished. |
301 | /// </summary> |
302 | - /// <param name="path">The path whose upload has finished.</param> |
303 | /// <param name="data">The data of the upload.</param> |
304 | [OperationContract(IsOneWay = true)] |
305 | void OnUploadFinished(UploadData data); |
306 | |
307 | === modified file 'src/Canonical.UbuntuOne.Common/OperationContracts/ISyncShares.cs' |
308 | --- src/Canonical.UbuntuOne.Common/OperationContracts/ISyncShares.cs 2010-08-09 16:39:46 +0000 |
309 | +++ src/Canonical.UbuntuOne.Common/OperationContracts/ISyncShares.cs 2010-08-09 16:39:47 +0000 |
310 | @@ -22,6 +22,10 @@ |
311 | |
312 | namespace Canonical.UbuntuOne.Common |
313 | { |
314 | + /// <summary> |
315 | + /// Contract to be implemented by a object that allows to interact with the different shares |
316 | + /// that a user has in the Ubuntu One storage infrastructure. |
317 | + /// </summary> |
318 | [ServiceContract( |
319 | Name = "SyncShares", |
320 | Namespace = "http://one.ubuntu.com/shares", |
321 | |
322 | === modified file 'src/Canonical.UbuntuOne.Common/ProcessManagementException.cs' |
323 | --- src/Canonical.UbuntuOne.Common/ProcessManagementException.cs 2010-07-07 10:41:49 +0000 |
324 | +++ src/Canonical.UbuntuOne.Common/ProcessManagementException.cs 2010-08-09 16:39:47 +0000 |
325 | @@ -28,17 +28,31 @@ |
326 | { |
327 | #region Constructors |
328 | |
329 | + /// <summary> |
330 | + /// Initializes a new instance of the ProcessManagementException class. |
331 | + /// </summary> |
332 | public ProcessManagementException() |
333 | { |
334 | |
335 | } |
336 | |
337 | + /// <summary> |
338 | + /// Initializes a new instance of the ProcessManagementException class with a specified error message. |
339 | + /// </summary> |
340 | + /// <param name="message">The message that describes the error. </param> |
341 | public ProcessManagementException(string message) |
342 | : base(message) |
343 | { |
344 | |
345 | } |
346 | |
347 | + /// <summary> |
348 | + /// Initializes a new instance of the ProcessManagementException class with a specified error message |
349 | + /// and a reference to the inner exception that is the cause of this exception. |
350 | + /// </summary> |
351 | + /// <param name="message">The error message that explains the reason for the exception.</param> |
352 | + /// <param name="inner">The exception that is the cause of the current exception, |
353 | + /// or a null reference (Nothing in Visual Basic) if no inner exception is specified. </param> |
354 | public ProcessManagementException(string message, Exception inner) |
355 | : base(message, inner) |
356 | { |
357 | |
358 | === modified file 'src/Canonical.UbuntuOne.Common/SyncDaemonException.cs' |
359 | --- src/Canonical.UbuntuOne.Common/SyncDaemonException.cs 2010-07-04 18:47:44 +0000 |
360 | +++ src/Canonical.UbuntuOne.Common/SyncDaemonException.cs 2010-08-09 16:39:47 +0000 |
361 | @@ -2,20 +2,37 @@ |
362 | |
363 | namespace Canonical.UbuntuOne.Common |
364 | { |
365 | + /// <summary> |
366 | + /// Exception thrown when ever there are issues with the daemon. |
367 | + /// </summary> |
368 | public class SyncDaemonException : Exception |
369 | { |
370 | #region Constructors |
371 | |
372 | + /// <summary> |
373 | + /// Initializes a new instance of the SyncDaemonException class. |
374 | + /// </summary> |
375 | public SyncDaemonException() |
376 | { |
377 | |
378 | } |
379 | |
380 | + /// <summary> |
381 | + /// Initializes a new instance of the SyncDaemonException class with a specified error message. |
382 | + /// </summary> |
383 | + /// <param name="message">The message that describes the error. </param> |
384 | public SyncDaemonException(string message) |
385 | : base(message){ |
386 | |
387 | } |
388 | |
389 | + /// <summary> |
390 | + /// Initializes a new instance of the SyncDaemonException class with a specified error message |
391 | + /// and a reference to the inner exception that is the cause of this exception. |
392 | + /// </summary> |
393 | + /// <param name="message">The error message that explains the reason for the exception.</param> |
394 | + /// <param name="inner">The exception that is the cause of the current exception, |
395 | + /// or a null reference (Nothing in Visual Basic) if no inner exception is specified. </param> |
396 | public SyncDaemonException(string message, Exception inner) |
397 | : base(message, inner) |
398 | { |
399 | |
400 | === modified file 'src/Canonical.UbuntuOne.Common/Update/Enumerators.cs' |
401 | --- src/Canonical.UbuntuOne.Common/Update/Enumerators.cs 2010-07-14 13:50:36 +0000 |
402 | +++ src/Canonical.UbuntuOne.Common/Update/Enumerators.cs 2010-08-09 16:39:47 +0000 |
403 | @@ -25,7 +25,13 @@ |
404 | /// </summary> |
405 | public enum UpdateConfirmation |
406 | { |
407 | + /// <summary> |
408 | + /// Value that represents a positive answer from the user. |
409 | + /// </summary> |
410 | YES, |
411 | + /// <summary> |
412 | + /// Value that represents a newagtive answer from the user. |
413 | + /// </summary> |
414 | NO |
415 | } |
416 | } |
417 | |
418 | === modified file 'src/Canonical.UbuntuOne.Common/Update/IUpdatingPresenter.cs' |
419 | --- src/Canonical.UbuntuOne.Common/Update/IUpdatingPresenter.cs 2010-07-29 16:34:27 +0000 |
420 | +++ src/Canonical.UbuntuOne.Common/Update/IUpdatingPresenter.cs 2010-08-09 16:39:47 +0000 |
421 | @@ -19,6 +19,10 @@ |
422 | */ |
423 | namespace Canonical.UbuntuOne.Common.Update |
424 | { |
425 | + /// <summary> |
426 | + /// Interface to be implemented by those presenters that will manage the view use to |
427 | + /// communicate the user that an update is taking place. |
428 | + /// </summary> |
429 | public interface IUpdatingPresenter |
430 | { |
431 | /// <summary> |
432 | |
433 | === modified file 'src/Canonical.UbuntuOne.Common/Update/IUpdatingView.cs' |
434 | --- src/Canonical.UbuntuOne.Common/Update/IUpdatingView.cs 2010-07-30 07:38:58 +0000 |
435 | +++ src/Canonical.UbuntuOne.Common/Update/IUpdatingView.cs 2010-08-09 16:39:47 +0000 |
436 | @@ -20,6 +20,10 @@ |
437 | |
438 | namespace Canonical.UbuntuOne.Common.Update |
439 | { |
440 | + /// <summary> |
441 | + /// Interface to be implemented by those views that will interact with the user when |
442 | + /// the application is being updated. |
443 | + /// </summary> |
444 | public interface IUpdatingView |
445 | { |
446 | /// <summary> |
447 | |
448 | === modified file 'src/Canonical.UbuntuOne.Common/Update/SelfUpdateException.cs' |
449 | --- src/Canonical.UbuntuOne.Common/Update/SelfUpdateException.cs 2010-07-14 13:50:36 +0000 |
450 | +++ src/Canonical.UbuntuOne.Common/Update/SelfUpdateException.cs 2010-08-09 16:39:47 +0000 |
451 | @@ -27,16 +27,30 @@ |
452 | /// </summary> |
453 | public class SelfUpdateException : Exception |
454 | { |
455 | + /// <summary> |
456 | + /// Initializes a new instance of the SelfUpdateException class. |
457 | + /// </summary> |
458 | public SelfUpdateException() |
459 | { |
460 | } |
461 | |
462 | + /// <summary> |
463 | + /// Initializes a new instance of the SelfUpdateException class with a specified error message. |
464 | + /// </summary> |
465 | + /// <param name="message">The message that describes the error. </param> |
466 | public SelfUpdateException(string message) |
467 | : base(message) |
468 | { |
469 | |
470 | } |
471 | |
472 | + /// <summary> |
473 | + /// Initializes a new instance of the SelfUpdateException class with a specified error message |
474 | + /// and a reference to the inner exception that is the cause of this exception. |
475 | + /// </summary> |
476 | + /// <param name="message">The error message that explains the reason for the exception.</param> |
477 | + /// <param name="inner">The exception that is the cause of the current exception, |
478 | + /// or a null reference (Nothing in Visual Basic) if no inner exception is specified. </param> |
479 | public SelfUpdateException(string message, Exception inner) |
480 | : base(message, inner) |
481 | { |
482 | |
483 | === modified file 'src/Canonical.UbuntuOne.Common/Update/Updater.cs' |
484 | --- src/Canonical.UbuntuOne.Common/Update/Updater.cs 2010-07-29 17:19:47 +0000 |
485 | +++ src/Canonical.UbuntuOne.Common/Update/Updater.cs 2010-08-09 16:39:47 +0000 |
486 | @@ -54,9 +54,26 @@ |
487 | |
488 | #region DI properties |
489 | |
490 | + /// <summary> |
491 | + /// Gets and sets the url of the feed that is used to determine if there are updates available. |
492 | + /// </summary> |
493 | public string RSSFeed { get; set; } |
494 | + |
495 | + /// <summary> |
496 | + /// Gets and sets the message box that is used to communicate messages to the user, |
497 | + /// </summary> |
498 | public IMessageBox MessageBox { get; set; } |
499 | + |
500 | + /// <summary> |
501 | + /// Gets and sets the downloading presenter that manages the view used to tell the user |
502 | + /// that the updates are being downloaded. |
503 | + /// </summary> |
504 | public IDownloadingPresenter DownloadingPresenter { get; set; } |
505 | + |
506 | + /// <summary> |
507 | + /// Gets and sets the updating presenter that manages the view used to tell the user |
508 | + /// that the updates are taking place. |
509 | + /// </summary> |
510 | public IUpdatingPresenter UpdatingPresenter { get; set; } |
511 | |
512 | #endregion |
513 | @@ -171,6 +188,10 @@ |
514 | |
515 | #endregion |
516 | |
517 | + /// <summary> |
518 | + /// Returns if the are updates present for the application. |
519 | + /// </summary> |
520 | + /// <returns>A flag indicating if updates are available.</returns> |
521 | public bool UpdatesArePresent() |
522 | { |
523 | try |
524 | @@ -193,6 +214,10 @@ |
525 | } |
526 | } |
527 | |
528 | + /// <summary> |
529 | + /// This method will perform the update of the application using a msi installer that |
530 | + /// is fecthed from the rss feed. |
531 | + /// </summary> |
532 | public void PerformUpdate() |
533 | { |
534 | lock (_updateLock) |
535 | @@ -243,6 +268,20 @@ |
536 | } |
537 | } |
538 | |
539 | + /// <summary> |
540 | + /// Defines a method to release allocated resources. |
541 | + /// </summary> |
542 | + /// <remarks> |
543 | + /// The primary use of this interface is to release unmanaged resources. The garbage collector |
544 | + /// automatically releases the memory allocated to a managed object when that object is no longer |
545 | + /// used. However, it is not possible to predict when garbage collection will occur. Furthermore, |
546 | + /// the garbage collector has no knowledge of unmanaged resources such as window handles, |
547 | + /// or open files and streams. |
548 | + /// |
549 | + /// Use the Dispose method of this interface to explicitly release unmanaged resources in |
550 | + /// conjunction with the garbage collector. The consumer of an object can call this method |
551 | + /// when the object is no longer needed. |
552 | + /// </remarks> |
553 | public void Dispose() |
554 | { |
555 | if (_updater == null) return; |
556 | |
557 | === modified file 'src/Canonical.UbuntuOne.Common/Update/UpdatingPresenter.cs' |
558 | --- src/Canonical.UbuntuOne.Common/Update/UpdatingPresenter.cs 2010-07-29 16:36:02 +0000 |
559 | +++ src/Canonical.UbuntuOne.Common/Update/UpdatingPresenter.cs 2010-08-09 16:39:47 +0000 |
560 | @@ -20,10 +20,20 @@ |
561 | |
562 | namespace Canonical.UbuntuOne.Common.Update |
563 | { |
564 | + /// <summary> |
565 | + /// Implementation of the IUpdatingPresenter that manages the UI used to communicate the |
566 | + /// user that an update is taking place. |
567 | + /// </summary> |
568 | public class UpdatingPresenter : IUpdatingPresenter |
569 | { |
570 | + /// <summary> |
571 | + /// Gets and sets the view that is used to interact with the user. |
572 | + /// </summary> |
573 | public IUpdatingView View { get; set; } |
574 | |
575 | + /// <summary> |
576 | + /// Method used to notify the user that the updating started. |
577 | + /// </summary> |
578 | public void UpdatingStarted() |
579 | { |
580 | if(!View.IsShown) |
581 | @@ -32,6 +42,9 @@ |
582 | View.IsUpdating = true; |
583 | } |
584 | |
585 | + /// <summary> |
586 | + /// Method used to notify the user that the updating finished. |
587 | + /// </summary> |
588 | public void UpdatingFinished() |
589 | { |
590 | View.UpdatingText = UpdateResources.UpdateFinished; |
591 | |
592 | === modified file 'src/Canonical.UbuntuOne.Common/Utils/ApplicationWrapper.cs' |
593 | --- src/Canonical.UbuntuOne.Common/Utils/ApplicationWrapper.cs 2010-08-09 16:39:46 +0000 |
594 | +++ src/Canonical.UbuntuOne.Common/Utils/ApplicationWrapper.cs 2010-08-09 16:39:47 +0000 |
595 | @@ -21,10 +21,19 @@ |
596 | |
597 | namespace Canonical.UbuntuOne.Common.Utils |
598 | { |
599 | + /// <summary> |
600 | + /// Wrapper that allows to add an abstraction when working with the System.Window.Application class. |
601 | + /// </summary> |
602 | public class ApplicationWrapper : IApplication |
603 | { |
604 | private readonly Application _app; |
605 | |
606 | + /// <summary> |
607 | + /// Initializes a new instance of the ApplicationWrapper class with a new application. |
608 | + /// </summary> |
609 | + /// <remarks> |
610 | + /// At any point of time just a single ApplicationWrapper instance can be present in an application. |
611 | + /// </remarks> |
612 | public ApplicationWrapper() |
613 | { |
614 | _app = new Application(); |
615 | |
616 | === modified file 'src/Canonical.UbuntuOne.Common/Utils/ExplorerException.cs' |
617 | --- src/Canonical.UbuntuOne.Common/Utils/ExplorerException.cs 2010-08-09 16:39:46 +0000 |
618 | +++ src/Canonical.UbuntuOne.Common/Utils/ExplorerException.cs 2010-08-09 16:39:47 +0000 |
619 | @@ -21,19 +21,37 @@ |
620 | |
621 | namespace Canonical.UbuntuOne.Common.Utils |
622 | { |
623 | + /// <summary> |
624 | + /// Exception thrown when there is a problem when interaction with the |
625 | + /// file explorer. |
626 | + /// </summary> |
627 | public class ExplorerException : Exception |
628 | { |
629 | + /// <summary> |
630 | + /// Initializes a new instance of the ExplorerException class. |
631 | + /// </summary> |
632 | public ExplorerException() |
633 | { |
634 | |
635 | } |
636 | |
637 | + /// <summary> |
638 | + /// Initializes a new instance of the ExplorerException class with a specified error message. |
639 | + /// </summary> |
640 | + /// <param name="message">The message that describes the error. </param> |
641 | public ExplorerException(string message) |
642 | : base(message) |
643 | { |
644 | |
645 | } |
646 | |
647 | + /// <summary> |
648 | + /// Initializes a new instance of the ExplorerException class with a specified error message |
649 | + /// and a reference to the inner exception that is the cause of this exception. |
650 | + /// </summary> |
651 | + /// <param name="message">The error message that explains the reason for the exception.</param> |
652 | + /// <param name="inner">The exception that is the cause of the current exception, |
653 | + /// or a null reference (Nothing in Visual Basic) if no inner exception is specified. </param> |
654 | public ExplorerException(string message, Exception inner) |
655 | : base(message, inner) |
656 | { |
657 | |
658 | === modified file 'src/Canonical.UbuntuOne.Common/Utils/IExplorer.cs' |
659 | --- src/Canonical.UbuntuOne.Common/Utils/IExplorer.cs 2010-08-09 16:39:46 +0000 |
660 | +++ src/Canonical.UbuntuOne.Common/Utils/IExplorer.cs 2010-08-09 16:39:47 +0000 |
661 | @@ -19,6 +19,10 @@ |
662 | */ |
663 | namespace Canonical.UbuntuOne.Common.Utils |
664 | { |
665 | + /// <summary> |
666 | + /// Interface to be implemented by an object that allows to interact with the |
667 | + /// file Explorer on Windows. |
668 | + /// </summary> |
669 | public interface IExplorer |
670 | { |
671 | /// <summary> |
672 | |
673 | === modified file 'src/Canonical.UbuntuOne.Common/Utils/IWebbrowser.cs' |
674 | --- src/Canonical.UbuntuOne.Common/Utils/IWebbrowser.cs 2010-08-09 16:39:46 +0000 |
675 | +++ src/Canonical.UbuntuOne.Common/Utils/IWebbrowser.cs 2010-08-09 16:39:47 +0000 |
676 | @@ -19,6 +19,10 @@ |
677 | */ |
678 | namespace Canonical.UbuntuOne.Common.Utils |
679 | { |
680 | + /// <summary> |
681 | + /// Interface to be implemented by an object that allows to interact with the |
682 | + /// default webbrowser in the system. |
683 | + /// </summary> |
684 | public interface IWebbrowser |
685 | { |
686 | /// <summary> |
687 | |
688 | === modified file 'src/Canonical.UbuntuOne.Common/Utils/Webbrowser.cs' |
689 | --- src/Canonical.UbuntuOne.Common/Utils/Webbrowser.cs 2010-08-09 16:39:46 +0000 |
690 | +++ src/Canonical.UbuntuOne.Common/Utils/Webbrowser.cs 2010-08-09 16:39:47 +0000 |
691 | @@ -21,8 +21,14 @@ |
692 | |
693 | namespace Canonical.UbuntuOne.Common.Utils |
694 | { |
695 | + /// <summary> |
696 | + /// Implementation of the IWebbrowser that allows to interact with the default browser. |
697 | + /// </summary> |
698 | public class Webbrowser : IWebbrowser |
699 | { |
700 | + /// <summary> |
701 | + /// Opens the default browser in the system and dispaly the passed url. |
702 | + /// </summary> |
703 | public void LauncWebpage(string url) |
704 | { |
705 | // trust the console to open the correct app |
706 | |
707 | === modified file 'src/Canonical.UbuntuOne.Common/Validation/EqualityValidationExtensions.cs' |
708 | --- src/Canonical.UbuntuOne.Common/Validation/EqualityValidationExtensions.cs 2010-07-23 14:59:53 +0000 |
709 | +++ src/Canonical.UbuntuOne.Common/Validation/EqualityValidationExtensions.cs 2010-08-09 16:39:47 +0000 |
710 | @@ -36,10 +36,10 @@ |
711 | /// A <see cref="ArgumentValidation"/> with the validations done so far. |
712 | /// </param> |
713 | /// <param name="value"> |
714 | - /// A <see cref="T"/> to be tested. |
715 | + /// A comparable object to be tested. |
716 | /// </param> |
717 | /// <param name="otherValue"> |
718 | - /// A <see cref="T"/> with the value to test agains. |
719 | + /// A comparable object with the value to test agains. |
720 | /// </param> |
721 | /// <param name="parameterName"> |
722 | /// A <see cref="System.String"/> with the message to be used in the exception. |
723 | @@ -64,10 +64,10 @@ |
724 | /// A <see cref="ArgumentValidation"/> with the validations done so far. |
725 | /// </param> |
726 | /// <param name="value"> |
727 | - /// A <see cref="T"/> with the argument to validate. |
728 | + /// A comparable object with the argument to validate. |
729 | /// </param> |
730 | /// <param name="otherValue"> |
731 | - /// A <see cref="T"/> with the value to compare against. |
732 | + /// A comparable object with the value to compare against. |
733 | /// </param> |
734 | /// <param name="parameterName"> |
735 | /// A <see cref="System.String"/> with the message to be used in the exception. |
736 | @@ -92,10 +92,10 @@ |
737 | /// A <see cref="ArgumentValidation"/> with the validations so far. |
738 | /// </param> |
739 | /// <param name="value"> |
740 | - /// A <see cref="T"/> to be validated. |
741 | + /// A comparable object to be validated. |
742 | /// </param> |
743 | /// <param name="otherValue"> |
744 | - /// A <see cref="T"/> with the valut to validate against. |
745 | + /// A comparable object with the value to validate against. |
746 | /// </param> |
747 | /// <returns> |
748 | /// A <see cref="ArgumentValidation"/> with the result of the validation. |
749 | @@ -116,10 +116,10 @@ |
750 | /// A <see cref="ArgumentValidation"/> with the validation so far. |
751 | /// </param> |
752 | /// <param name="value"> |
753 | - /// A <see cref="T"/> with the argument to validate. |
754 | + /// A comparable object with the argument to validate. |
755 | /// </param> |
756 | /// <param name="otherValues"> |
757 | - /// A <see cref="ICollection"/> with the values to validate against. |
758 | + /// A collection with the values to validate against. |
759 | /// </param> |
760 | /// <returns> |
761 | /// A <see cref="ArgumentValidation"/> with the result of the validation. |
762 | @@ -147,10 +147,10 @@ |
763 | /// A <see cref="ArgumentValidation"/> with the validation so far. |
764 | /// </param> |
765 | /// <param name="value"> |
766 | - /// A <see cref="T"/> with the argument to validate. |
767 | + /// A comparable object with the argument to validate. |
768 | /// </param> |
769 | /// <param name="otherValue"> |
770 | - /// A <see cref="T"/> with the value to validate against. |
771 | + /// A comparable object with the value to validate against. |
772 | /// </param> |
773 | /// <returns> |
774 | /// A <see cref="ArgumentValidation"/> with the result of the validation. |
775 | @@ -171,10 +171,10 @@ |
776 | /// A <see cref="ArgumentValidation"/> with the valdiation result so far. |
777 | /// </param> |
778 | /// <param name="value"> |
779 | - /// A <see cref="T"/> with the argument to validate. |
780 | + /// A comparable object with the argument to validate. |
781 | /// </param> |
782 | - /// <param name="otherValue"> |
783 | - /// A <see cref="ICollection"/> with the value to validate against. |
784 | + /// <param name="otherValues"> |
785 | + /// A collection with the value to validate against. |
786 | /// </param> |
787 | /// <returns> |
788 | /// A <see cref="ArgumentValidation"/> with the result of the validation. |
789 | @@ -219,6 +219,21 @@ |
790 | string.Format("'{0}' must match '{1}'.", value, regularExpression))); |
791 | } |
792 | |
793 | + /// <summary> |
794 | + /// Ensures that the string that was passed as an argument is not null or empty |
795 | + /// </summary> |
796 | + /// <param name="argumentValidation"> |
797 | + /// A <see cref="ArgumentValidation"/> with the current result of the validations. |
798 | + /// </param> |
799 | + /// <param name="value"> |
800 | + /// A <see cref="System.String"/> with the argument to validate. |
801 | + /// </param> |
802 | + /// <param name="parameterName"> |
803 | + /// The name of the parameter under test. |
804 | + /// </param> |
805 | + /// <returns> |
806 | + /// A <see cref="ArgumentValidation"/> the result of the validation. |
807 | + /// </returns> |
808 | public static ArgumentValidation IsNotNullOrEmpty(this ArgumentValidation argumentValidation, string value, |
809 | string parameterName) |
810 | { |
811 | |
812 | === modified file 'src/Canonical.UbuntuOne.Common/Validation/ValidationExtensions.cs' |
813 | --- src/Canonical.UbuntuOne.Common/Validation/ValidationExtensions.cs 2010-07-13 08:08:53 +0000 |
814 | +++ src/Canonical.UbuntuOne.Common/Validation/ValidationExtensions.cs 2010-08-09 16:39:47 +0000 |
815 | @@ -22,6 +22,10 @@ |
816 | |
817 | namespace Canonical.UbuntuOne.Common.Validation |
818 | { |
819 | + /// <summary> |
820 | + /// Static class that contains a collection of extension method that can be used to |
821 | + /// validate the arguments of a method. |
822 | + /// </summary> |
823 | public static class ValidationExtensions |
824 | { |
825 | /// <summary> |
826 | @@ -31,7 +35,7 @@ |
827 | /// A <see cref="ArgumentValidation"/> that will be used when validating the arguments of a method. |
828 | /// </param> |
829 | /// <param name="theObject"> |
830 | - /// A <see cref="T"/> to test if it is null. |
831 | + /// A ref object to test if it is null. |
832 | /// </param> |
833 | /// <returns> |
834 | /// A <see cref="ArgumentValidation"/> with the result of the validation os far. |
835 | @@ -49,7 +53,7 @@ |
836 | /// A <see cref="ArgumentValidation"/> that will be used when validating the arguments of a method. |
837 | /// </param> |
838 | /// <param name="theObject"> |
839 | - /// A <see cref="T"/> to test if it is null. |
840 | + /// A ref object to test if it is null. |
841 | /// </param> |
842 | /// <param name="parameterName"> |
843 | /// A <see cref="System.String"/> with the message to be used in the exception. |
Thanks for the comments!