Merge lp:~mandel/ubuntuone-windows-installer/fix-reactor-import into lp:ubuntuone-windows-installer

[Manuel de la Peña]

Fix the reactor installation by ensuring that tools does not install the reactor.

Fix the reactor installation by ensuring that tools does not install the reactor.

[lp:~mandel/ubuntuone-windows-installer/fix-reactor-import]

86. By Manuel de la Peña on 2011-10-19

Import tools from inside the func and get utils out again.

[Diego Sarmentero (diegosarmentero)]

+1

review: Approve

[lp:~mandel/ubuntuone-windows-installer/fix-reactor-import]

87. By Manuel de la Peña on 2011-10-19

Reset else.

88. By Manuel de la Peña on 2011-10-19

Fix pep8.

89. By Manuel de la Peña on 2011-10-19

Fix tests.

[Natalia Bidart (nataliabidart)]

(01:34:37 PM) nessita: mandel: right, so the fix should be move the utils import from the global space to inside the def's that need it
(01:35:10 PM) nessita: mandel: in fact, I'm wondering why those def's are in main() (besides the main() itself)
(01:35:50 PM) nessita: mandel: so, I would move:
(01:36:29 PM) nessita: check_updates, check_credentials to utils, and then import the utils module inside the main() def, after the reactor was installed
(01:36:56 PM) nessita: mandel: that way we can also cleanup the passing of the CredentialsManagementTool class to check_credentials
(01:37:33 PM) nessita: mandel: since, if we move check_credentials to utils, which will be imported after the reactor was installed, we can import CredentialsManagemetTool globally in utils
(01:37:38 PM) nessita: mandel: you followed me?
(01:38:37 PM) mandel: nessita, so, move everything but move to utils and then simply import check_credentials, right?
(01:38:57 PM) nessita: mandel: hem.. that's a subset, yes
(01:39:10 PM) nessita: mandel: you can't move the reactor callbacks, for example
(01:39:31 PM) nessita: so, stop, error_cb, and success_cb remain in main()
(01:39:46 PM) mandel: nessita, why can't I move success?
(01:39:55 PM) nessita: mandel: it creates a GUI
(01:40:02 PM) nessita: we don't want to move that to utils
(01:40:06 PM) mandel: oh, true..
(01:40:33 PM) mandel: I hate that stupid import magic from the reactor, is making or code look horrible
(01:40:41 PM) nessita: mandel: yes
(01:41:16 PM) mandel: nessita, ok, can you add a needs fixing and I'll sort out this tom early morning, I ran out of hours

review: Needs Fixing

[lp:~mandel/ubuntuone-windows-installer/fix-reactor-import]

90. By Manuel de la Peña on 2011-10-20

Moved functions to utils and sorted the tests to ensure everything works as expected.

91. By Manuel de la Peña on 2011-10-20

Fixed lint issues.

92. By Manuel de la Peña on 2011-10-20

Import credentials from the main function.

[Natalia Bidart (nataliabidart)]

* Code looks good. One tiny note: the FakeCredsManagementTool.find_credentials should return a deferred like the real one does, something like:

255 + def find_credentials(self):
256 + """Fake find credentials."""
257 + if FakeCredsManagementTool.raise_error:
258 + return defer.fail(Exception('Test!'))
259 + else:
260 + return defer.succeed(FakeCredsManagementTool.credentials)

* Tests are not passing on windows:

===============================================================================
[ERROR]
Traceback (most recent call last):
  File "C:\Python27\lib\site-packages\twisted\internet\defer.py", line 1020, in
_inlineCallbacks
    result = g.send(result)
  File "E:\windows-installer\review_fix-reactor-import\ubuntuone_installer\gui\q
t\main\tests\test_windows.py", line 99, in test_failure
    yield windows.check_credentials(
exceptions.AttributeError: 'module' object has no attribute 'check_credentials'

ubuntuone_installer.gui.qt.main.tests.test_windows.CredsFailureMainTestCase.test
_failure
===============================================================================
[ERROR]
Traceback (most recent call last):
  File "C:\Python27\lib\site-packages\twisted\internet\defer.py", line 1020, in
_inlineCallbacks
    result = g.send(result)
  File "E:\windows-installer\review_fix-reactor-import\ubuntuone_installer\gui\q
t\main\tests\test_windows.py", line 118, in test_no_creds
    yield windows.check_credentials(
exceptions.AttributeError: 'module' object has no attribute 'check_credentials'

ubuntuone_installer.gui.qt.main.tests.test_windows.CredsFailureMainTestCase.test
_no_creds
===============================================================================
[ERROR]
Traceback (most recent call last):
  File "C:\Python27\lib\site-packages\twisted\internet\defer.py", line 1020, in
_inlineCallbacks
    result = g.send(result)
  File "E:\windows-installer\review_fix-reactor-import\ubuntuone_installer\gui\q
t\main\tests\test_windows.py", line 136, in test_with_creds
    yield windows.check_credentials(
exceptions.AttributeError: 'module' object has no attribute 'check_credentials'

ubuntuone_installer.gui.qt.main.tests.test_windows.CredsFailureMainTestCase.test
_with_creds
===============================================================================
[ERROR]
Traceback (most recent call last):
  File "C:\Python27\lib\site-packages\twisted\internet\defer.py", line 1020, in
_inlineCallbacks
    result = g.send(result)
  File "E:\windows-installer\review_fix-reactor-import\ubuntuone_installer\gui\q
t\main\tests\test_windows.py", line 163, in test_with_installed_flag
    yield windows.check_credentials(
exceptions.AttributeError: 'module' object has no attribute 'check_credentials'

ubuntuone_installer.gui.qt.main.tests.test_windows.CredsFailureMainTestCase.test
_with_installed_flag
===============================================================================
[ERROR]
Traceback (most recent call last):
  File "C:\Python27\lib\site-packages\twisted\internet\defer.py", line 1020, in
_inlineCallbacks
    result = g.send(result)
  File "E:\windows-installer\review_fix-reactor-import\ubuntuone_installer\gui\q
t\main\tests\test_wind...

review: Needs Fixing

[lp:~mandel/ubuntuone-windows-installer/fix-reactor-import]

93. By Manuel de la Peña on 2011-10-21

Fixed tests.

94. By Manuel de la Peña on 2011-10-21

Fixed lint issues.

95. By Manuel de la Peña on 2011-10-21

Ignore pylint.

96. By Manuel de la Peña on 2011-10-21

Added test for error_cb

[Natalia Bidart (nataliabidart)]

Looks good!

review: Approve

=== modified file 'ubuntuone_installer/gui/qt/main/tests/test_windows.py'
--- ubuntuone_installer/gui/qt/main/tests/test_windows.py	2011-09-29 13:26:44 +0000
+++ ubuntuone_installer/gui/qt/main/tests/test_windows.py	2011-10-21 15:53:24 +0000
@@ -21,39 +21,10 @@
 
 from twisted.internet import defer
 
-from ubuntuone_installer.gui.qt import gui, utils
 from ubuntuone_installer.gui.qt.main import windows
-from ubuntuone_installer.gui.qt.tests.test_gui import FakeMainWindow
 from ubuntuone_installer.tests import TestCase
 
 
-class FakeFailingCredentialsManagementTool(object):
-
-    """A fake CredentialsManagementTool that fails."""
-
-    def find_credentials(self):
-        """Return a failure."""
-        return defer.fail(Exception())
-
-
-class FakeNoCredentialsManagementTool(object):
-
-    """A fake CredentialsManagementTool that fakes no credentials."""
-
-    def find_credentials(self):
-        """Return a success, but no credentials."""
-        return defer.succeed({})
-
-
-class FakeCredentialsManagementTool(object):
-
-    """A fake CredentialsManagementTool that fakes credentials."""
-
-    def find_credentials(self):
-        """Return a success, but no credentials."""
-        return defer.succeed("Something not false")
-
-
 class FakeLogger(object):
 
     """Fake Logger."""
@@ -75,93 +46,111 @@
         self.info_args = (args, kwargs)
 
 
-class CredsFailureMainTestCase(TestCase):
-
-    """Test the qt main window."""
-
-    stopped = False
-    updates_checked = False
-
-    def stop(self):
-        """A fake stop."""
-        self.stopped = True
-
-    def check_updates(self, gui_ref, logger):
-        """A fake check updates."""
-        self.updates_checked = True
-
-    @defer.inlineCallbacks
-    def test_failure(self):
-        """Credential errors should display a critical message."""
-        logger = FakeLogger()
-        self.patch(windows, 'stop', self.stop)
-        self.stopped = False
-        yield windows.check_credentials(
-            FakeFailingCredentialsManagementTool,
-            gui, logger)
-        # Should log the error
-        self.assertEqual(logger.error_args[0][0],
-            ('Error while getting the credentials: %r'))
-        # Should stop the app
-        self.assertTrue(self.stopped)
-
-    @defer.inlineCallbacks
-    def test_no_creds(self):
-        """No credentials should start the wizard."""
-        logger = FakeLogger()
-        fakemain = FakeMainWindow()
-        self.patch(gui, 'MainWindow', lambda *args, **kwargs: fakemain)
-        self.patch(windows, 'stop', self._set_called)
-        self.assertFalse(fakemain.shown)
-        self.patch(windows, 'stop', self.stop)
-        self.stopped = False
-        yield windows.check_credentials(
-            FakeNoCredentialsManagementTool,
-            gui, logger)
-        # Should show the main window
-        self.assertTrue(fakemain.shown)
-        # Should not log errors
-        self.assertEqual(logger.error_args, None)
-        # Should not stop the app
-        self.assertFalse(self.stopped)
-
-    @defer.inlineCallbacks
-    def test_with_creds(self):
-        """Having credentials should start the control panel."""
-        logger = FakeLogger()
-        self.patch(utils, 'start_control_panel', self._set_called)
-        self.patch(windows, 'stop', self.stop)
-        self.patch(windows, 'check_updates', self.check_updates)
-        self.stopped = False
-        yield windows.check_credentials(
-            FakeCredentialsManagementTool,
-            gui, logger)
-        # Should not log errors
-        self.assertEqual(logger.error_args, None)
-        # Should start u1cp
-        self.assertEqual(self._called, ((), {'with_icon': False}))
-        # Should stop the app
-        self.assertTrue(self.stopped)
-        self.assertTrue(self.updates_checked)
-
-    @defer.inlineCallbacks
-    def test_without_installed_flag(self):
-        """Test behaviour without the installer flag."""
-        logger = FakeLogger()
-        self.patch(windows, "success_cb", self._set_called)
-        yield windows.check_credentials(
-            FakeCredentialsManagementTool,
-            gui, logger)
-        self.assertEqual(self._called, (('Something not false',
-            gui, False, logger), {}))
-
-    @defer.inlineCallbacks
-    def test_with_installed_flag(self):
-        """Test behaviour without the installer flag."""
-        logger = FakeLogger()
-        self.patch(windows, "success_cb", self._set_called)
-        yield windows.check_credentials(
-            FakeCredentialsManagementTool,
-            gui, logger, installer=True)
-        self.assertEqual(self._called, (('Something not false',
-            gui, True, logger), {}))
+class FakeGui(object):
+    """Fake gui module."""
+
+    def __init__(self):
+        """Create a new instance."""
+        self.main_window = None
+        self.close = None
+        self.installing = False
+        self.called = []
+
+    # pylint: disable=C0103
+    def MainWindow(self, close_callback=lambda: None, installing=False):
+        """Fake main window creation."""
+        self.close = close_callback
+        self.installing = installing
+        self.called.append('MainWindow')
+        return self.main_window
+    # pylint: enable=C0103
+
+
+class FakeWindow(object):
+    """Fake a window."""
+
+    def __init__(self):
+        """Create a new instance."""
+        self.shown = False
+
+    def show(self):
+        """Fake a shown window."""
+        self.shown = True
+
+
+class SuccessTestCase(TestCase):
+    """Test the success callback."""
+
+    @defer.inlineCallbacks
+    def setUp(self):
+        """Set up the diff tests."""
+        yield super(SuccessTestCase, self).setUp()
+        self.called = []
+        self.start_name = 'start'
+        self.update_name = 'update'
+        self.stop_name = 'stop'
+        self.gui = FakeGui()
+        self.gui.main_window = FakeWindow()
+        self.logger = FakeLogger()
+
+        def fake_start(with_icon=False):
+            """Fake the control panel start."""
+            self.called.append((self.start_name, with_icon))
+            return defer.succeed(None)
+
+        def fake_check_updates(gui, logger):
+            """Fake the check of updates."""
+            self.called.append((self.update_name, gui, logger))
+            return defer.succeed(None)
+
+        def fake_stop():
+            """Fake stop."""
+            self.called.append((self.stop_name,))
+
+        self.patch(windows, 'stop', fake_stop)
+        self.start_cb = fake_start
+        self.check_updates_cb = fake_check_updates
+
+    @defer.inlineCallbacks
+    def test_success_with_creds(self):
+        """Test the success callback with creds."""
+        yield windows.success_cb('creds', self.gui, False, self.logger,
+                                 self.start_cb, self.check_updates_cb)
+        self.assertEqual(self.start_name, self.called[0][0])
+        self.assertFalse(self.called[0][1])
+        self.assertEqual(self.update_name, self.called[1][0])
+        self.assertEqual(self.gui, self.called[1][1])
+        self.assertEqual(self.logger, self.called[1][2])
+        self.assertEqual(self.stop_name, self.called[2][0])
+        self.assertEqual(0, len(self.gui.called))
+
+    @defer.inlineCallbacks
+    def test_success_not_creds(self):
+        """Test the success callback with no creds."""
+        yield windows.success_cb(None, self.gui, True, self.logger,
+                                 self.start_cb, self.check_updates_cb)
+        self.assertTrue('MainWindow' in self.gui.called)
+        self.assertTrue(self.gui.main_window.shown)
+
+
+class ErrorTestCase(TestCase):
+    """Test the success callback."""
+
+    @defer.inlineCallbacks
+    def setUp(self):
+        """Set up the diff tests."""
+        yield super(ErrorTestCase, self).setUp()
+        self.called = []
+        self.stop_name = 'stop'
+        self.logger = FakeLogger()
+
+        def fake_stop():
+            """Fake stop."""
+            self.called.append(self.stop_name)
+
+        self.patch(windows, 'stop', fake_stop)
+
+    def test_stop(self):
+        """Test the error_cb"""
+        windows.error_cb(Exception('test'), self.logger)
+        self.assertTrue(self.stop_name in self.called)

=== modified file 'ubuntuone_installer/gui/qt/main/windows.py'
--- ubuntuone_installer/gui/qt/main/windows.py	2011-09-29 13:26:44 +0000
+++ ubuntuone_installer/gui/qt/main/windows.py	2011-10-21 15:53:24 +0000
@@ -29,7 +29,6 @@
 # pylint: disable=W0611
 from ubuntuone_installer.gui.qt.ui import images_rc
 # pylint: enable=W0611
-from ubuntuone_installer.gui.qt import utils
 
 
 def stop(*args):
@@ -46,13 +45,14 @@
 
 
 @defer.inlineCallbacks
-def success_cb(creds, gui, installing, logger):
+def success_cb(creds, gui, installing, logger, start_control_panel,
+               check_updates):
     """Handle credentials success."""
     logger.debug('Got back from sso.')
     if creds:  # Have credentials already
         logger.debug('Already got credentials.')
         logger.info('Starting control panel.')
-        utils.start_control_panel(with_icon=False)
+        start_control_panel(with_icon=False)
         logger.info('Checking updates.')
         yield check_updates(gui, logger)
         logger.info('Stopping.')
@@ -72,37 +72,6 @@
         window.show()
 
 
[e-mail]
-def check_credentials(credentials_tool, gui, logger,
-                      installer=False):
-    """Check credentials and either start u1cp or show the wizard."""
-    credtool = credentials_tool()
-    # pylint: disable=W0703
-    try:
-        creds = yield credtool.find_credentials()
-    except Exception, exc:
-        error_cb(exc, logger)
-    else:
-        yield success_cb(creds, gui, installer, logger)
-
-
[e-mail]
-def check_updates(gui, logger):
-    """Check for updates."""
-    logger.info('Checking for updates.')
-    # the idea is simple, check if there are updates, ask user if we perform
-    # the update and continue.
-    are_updates_present = yield utils.are_updates_present(logger)
-    logger.debug('Updates present: %r', are_updates_present)
-    if are_updates_present:
-        logger.info('Updates are present.')
-        if gui.user_wants_to_update():
-            logger.info('Performing auto-update in diff process.')
-            utils.perform_update()
-    else:
-        logger.info('No updates are present.')
-
-
 def main(installing=False):
     """Perform a client request to be logged in."""
     # pylint: disable=W0612
@@ -113,8 +82,10 @@
     from ubuntuone_installer.gui.qt import gui
     from twisted.internet import reactor
     # All this has to be imported here because it installs a reactor
-    from ubuntuone.platform.credentials import CredentialsManagementTool
     from ubuntuone_installer.logger import setup_logging
+    from ubuntuone_installer.gui.qt.utils import check_credentials
+
     logger = setup_logging('qt.gui')
-    check_credentials(CredentialsManagementTool, gui, logger, installing)
+    check_credentials(gui, logger, success_cb,
+                      error_cb, installing)
     reactor.run()

=== modified file 'ubuntuone_installer/gui/qt/utils/__init__.py'
--- ubuntuone_installer/gui/qt/utils/__init__.py	2011-10-06 10:42:01 +0000
+++ ubuntuone_installer/gui/qt/utils/__init__.py	2011-10-21 15:53:24 +0000
@@ -33,6 +33,8 @@
     perform_update = windows.perform_update
     uninstall_old_beta = windows.uninstall_old_beta
     migrate_old_data = windows.migrate_old_data
+    check_updates = windows.check_updates
+    check_credentials = windows.check_credentials
 else:
     from ubuntuone_installer.gui.qt.utils import linux
     uninstall_application = linux.uninstall_application
@@ -44,3 +46,5 @@
     perform_update = lambda *args, **kwargs: None
     uninstall_old_beta = lambda *args, **kwargs: None
     migrate_old_data = lambda *args, **kwargs: None
+    check_updates = lambda *args, **kwargs: None
+    check_credentials = lambda *args, **kwargs: None

=== modified file 'ubuntuone_installer/gui/qt/utils/tests/test_windows.py'
--- ubuntuone_installer/gui/qt/utils/tests/test_windows.py	2011-10-18 13:42:46 +0000
+++ ubuntuone_installer/gui/qt/utils/tests/test_windows.py	2011-10-21 15:53:24 +0000
@@ -29,7 +29,11 @@
 # pylint: enable=F0401
 
 from twisted.internet import defer
+# pylint: disable=E0611
+from ubuntuone.platform import tools
+# pylint: enable=E0611
 
+from ubuntuone_installer.gui.qt import gui
 from ubuntuone_installer.gui.qt import utils
 from ubuntuone_installer.gui.qt.tests import BaseTestCase
 
@@ -269,7 +273,7 @@
 
         self.patch(utils.windows, 'default_folders',
                    fake_get_default_folders)
-        self.patch(utils.windows.tools, 'SyncDaemonTool',
+        self.patch(tools, 'SyncDaemonTool',
                 FakeSDTool)
         self.patch(utils.windows, 'deferToThread', fake_defer_to_thread)
 
@@ -541,3 +545,124 @@
 
     def test_get_auto_update_path(self):
         """Test the method used to get the autoupdate."""
+
+
+class CheckUpdatesTestCase(BaseTestCase):
+    """Test the code that is used for the auto update check process."""
+
+    @defer.inlineCallbacks
+    def setUp(self):
+        """Set the different tests."""
+        yield super(CheckUpdatesTestCase, self).setUp()
+        self.are_present = False
+        self.user_wants_update = False
+        self.logger = FakeLogger()
+        self.called = []
+
+        def fake_are_present(logger):
+            """Fake are updates present."""
+            self.called.append('are_updates_present')
+            return self.are_present
+
+        def fake_perform_update():
+            """Fake perform update."""
+            self.called.append('perform_update')
+
+        def fake_user_wants_to_update():
+            """Fake user_wants_to_update."""
+            self.called.append('user_wants_to_update')
+            return self.user_wants_update
+
+        self.patch(utils.windows, 'are_updates_present', fake_are_present)
+        self.patch(utils.windows, 'perform_update', fake_perform_update)
+        self.patch(gui, 'user_wants_to_update', fake_user_wants_to_update)
+
+    @defer.inlineCallbacks
+    def test_check_updates_not_present(self):
+        """Test the method that interacts with the user."""
+        self.are_present = False
+        yield utils.check_updates(gui, self.logger)
+        self.assertTrue('are_updates_present' in self.called)
+        self.assertFalse('perform_update' in self.called)
+
+    @defer.inlineCallbacks
+    def test_check_updates_present_not_user(self):
+        """Test the method that interacts with the user."""
+        self.are_present = True
+        self.user_wants_update = False
+        yield utils.check_updates(gui, self.logger)
+        self.assertTrue('are_updates_present' in self.called)
+        self.assertTrue('user_wants_to_update' in self.called)
+        self.assertFalse('perform_update' in self.called)
+
+    @defer.inlineCallbacks
+    def test_check_updates_present_user(self):
+        """Test the method that interacts with the user."""
+        self.are_present = True
+        self.user_wants_update = True
+        yield utils.check_updates(gui, self.logger)
+        self.assertTrue('are_updates_present' in self.called)
+        self.assertTrue('user_wants_to_update' in self.called)
+        self.assertTrue('perform_update' in self.called)
+
+
+class FakeCredsManagementTool(object):
+    """Fake a creds management tool."""
+
+    raise_error = False
+    credentials = None
+
+    def __init__(self):
+        """Create a new instance."""
+
+    def find_credentials(self):
+        """Fake find credentials."""
+        if FakeCredsManagementTool.raise_error:
+            return defer.fail(Exception('Test!'))
+        else:
+            return defer.succeed(FakeCredsManagementTool.credentials)
+
+
+class CheckCredentialsTestCase(BaseTestCase):
+    """Test the code that is used to check the credentials."""
+
+    @defer.inlineCallbacks
+    def setUp(self):
+        """Set the different tests."""
+        yield super(CheckCredentialsTestCase, self).setUp()
+        self.logger = FakeLogger()
+        self.called = []
+
+        def success(creds, gui_ref, installing, logger, start_control_panel,
+                       check_updates):
+            """Success cb."""
+            self.called.append(('success', creds, gui_ref, installing, logger,
+                                start_control_panel, check_updates))
+
+        def error(exc, logger):
+            """Error cb."""
+            self.called.append(('error', exc, logger))
+
+        self.success_cb = success
+        self.error_cb = error
+        self.patch(utils.windows, 'CredentialsManagementTool',
+                   FakeCredsManagementTool)
+
+    @defer.inlineCallbacks
+    def test_check_credentials_not_present(self):
+        """Test when creds are not present."""
+        FakeCredsManagementTool.raise_error = True
+        yield utils.check_credentials(gui, self.logger, self.success_cb,
+                                self.error_cb)
+        self.assertTrue('error' in self.called[0])
+
+    @defer.inlineCallbacks
+    def test_check_credentials_present(self):
+        """Test when creds are present."""
+        FakeCredsManagementTool.raise_error = False
+        FakeCredsManagementTool.credentials = 'creds'
+        yield utils.check_credentials(gui, self.logger, self.success_cb,
+                                self.error_cb)
+        self.assertTrue('success' in self.called[0])
+        self.assertEqual(FakeCredsManagementTool.credentials,
+                         self.called[0][1])

=== modified file 'ubuntuone_installer/gui/qt/utils/windows.py'
--- ubuntuone_installer/gui/qt/utils/windows.py	2011-10-18 13:42:46 +0000
+++ ubuntuone_installer/gui/qt/utils/windows.py	2011-10-21 15:53:24 +0000
@@ -38,7 +38,10 @@
 from twisted.internet.utils import getProcessValue
 from twisted.internet.threads import deferToThread
 
+# pylint: disable=E0611
 from ubuntuone.platform import tools
+# pylint: enable=E0611
+from ubuntuone.platform.credentials import CredentialsManagementTool
 
 AUTORUN_KEY = r"Software\Microsoft\Windows\CurrentVersion\Run"
 
@@ -98,6 +101,21 @@
 
 
 @defer.inlineCallbacks
+def check_credentials(gui, logger, success_cb, error_cb,
+                      installer=False):
+    """Check credentials and either start u1cp or show the wizard."""
+    credtool = CredentialsManagementTool()
+    # pylint: disable=W0703
+    try:
+        creds = yield credtool.find_credentials()
+    except Exception, exc:
+        error_cb(exc, logger)
+    else:
+        yield success_cb(creds, gui, installer, logger, start_control_panel,
+                         check_updates)
+
+
[e-mail]
 def are_updates_present(logger):
     """Return if there are updates for Ubuntu One."""
     update_path = _get_update_path()
@@ -125,6 +143,23 @@
             '--unattendedmodeui none', '', 0)
 
 
[e-mail]
+def check_updates(gui, logger):
+    """Check for updates."""
+    logger.info('Checking for updates.')
+    # the idea is simple, check if there are updates, ask user if we perform
+    # the update and continue.
+    are_present = yield are_updates_present(logger)
+    logger.debug('Updates present: %r', are_updates_present)
+    if are_present:
+        logger.info('Updates are present.')
+        if gui.user_wants_to_update():
+            logger.info('Performing auto-update in diff process.')
+            perform_update()
+    else:
+        logger.info('No updates are present.')
+
+
 def start_control_panel(with_icon=True):
     """Start the control panel."""
     # If we are in windows and "frozen", assume it's in