Merge lp:~mandel/ubuntuone-windows-installer/connect_to_ubuntuone into lp:ubuntuone-windows-installer/beta

Proposed by Manuel de la Peña
Status: Merged
Approved by: John Lenton
Approved revision: 107
Merged at revision: 135
Proposed branch: lp:~mandel/ubuntuone-windows-installer/connect_to_ubuntuone
Merge into: lp:ubuntuone-windows-installer/beta
Diff against target: 78 lines (+30/-6)
3 files modified
src/Canonical.Ubuntu.SSO.Views/LoginDialog.xaml (+4/-4)
src/Canonical.Ubuntu.SSO.Views/Resources/Resources.Designer.cs (+18/-0)
src/Canonical.Ubuntu.SSO.Views/Resources/Resources.resx (+8/-2)
To merge this branch: bzr merge lp:~mandel/ubuntuone-windows-installer/connect_to_ubuntuone
Reviewer Review Type Date Requested Status
John Lenton (community) Approve
Review via email: mp+40819@code.launchpad.net

Description of the change

Changed the login view to use the data from the resource file and added the correct text.

To post a comment you must log in.
Revision history for this message
John Lenton (chipaca) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Canonical.Ubuntu.SSO.Views/LoginDialog.xaml'
2--- src/Canonical.Ubuntu.SSO.Views/LoginDialog.xaml 2010-10-05 15:20:36 +0000
3+++ src/Canonical.Ubuntu.SSO.Views/LoginDialog.xaml 2010-11-14 22:06:14 +0000
4@@ -61,11 +61,11 @@
5 <Grid Grid.Row="1">
6 <Grid.ColumnDefinitions>
7 <ColumnDefinition Width="*"/>
8- <ColumnDefinition Width="85"/>
9- <ColumnDefinition Width="85"/>
10+ <ColumnDefinition Width="Auto"/>
11+ <ColumnDefinition Width="Auto"/>
12 </Grid.ColumnDefinitions>
13- <Button Name="LoginButton" Grid.Column="1" Margin="3" Click="ConnectButtonClick">Connect</Button>
14- <Button Name="CancelButton" Grid.Column="2" Margin="3" Click="CancelButtonClick">Cancel</Button>
15+ <Button Name="LoginButton" Grid.Column="1" Margin="3" Click="ConnectButtonClick" Content="{x:Static resx:Resources.LoginViewConnectButtonText}"/>
16+ <Button Name="CancelButton" Grid.Column="2" Margin="3" Click="CancelButtonClick" Content="{x:Static resx:Resources.LoginViewCancelButtonText}"/>
17 </Grid>
18 </Grid>
19 </Window>
20
21=== modified file 'src/Canonical.Ubuntu.SSO.Views/Resources/Resources.Designer.cs'
22--- src/Canonical.Ubuntu.SSO.Views/Resources/Resources.Designer.cs 2010-10-12 12:42:38 +0000
23+++ src/Canonical.Ubuntu.SSO.Views/Resources/Resources.Designer.cs 2010-11-14 22:06:14 +0000
24@@ -88,6 +88,24 @@
25 }
26
27 /// <summary>
28+ /// Looks up a localized string similar to Cancel.
29+ /// </summary>
30+ public static string LoginViewCancelButtonText {
31+ get {
32+ return ResourceManager.GetString("LoginViewCancelButtonText", resourceCulture);
33+ }
34+ }
35+
36+ /// <summary>
37+ /// Looks up a localized string similar to Connect to Ubuntu One.
38+ /// </summary>
39+ public static string LoginViewConnectButtonText {
40+ get {
41+ return ResourceManager.GetString("LoginViewConnectButtonText", resourceCulture);
42+ }
43+ }
44+
45+ /// <summary>
46 /// Looks up a localized string similar to To connect this computer to Ubuntu One enter your details below..
47 /// </summary>
48 public static string LoginViewInfo {
49
50=== modified file 'src/Canonical.Ubuntu.SSO.Views/Resources/Resources.resx'
51--- src/Canonical.Ubuntu.SSO.Views/Resources/Resources.resx 2010-10-05 11:19:52 +0000
52+++ src/Canonical.Ubuntu.SSO.Views/Resources/Resources.resx 2010-11-14 22:06:14 +0000
53@@ -112,10 +112,10 @@
54 <value>2.0</value>
55 </resheader>
56 <resheader name="reader">
57- <value>System.Resources.ResXResourceReader, System.Windows.Forms, Version=2.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
58+ <value>System.Resources.ResXResourceReader, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
59 </resheader>
60 <resheader name="writer">
61- <value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=2.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
62+ <value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
63 </resheader>
64 <data name="LoginEmailAddressWatermark" xml:space="preserve">
65 <value>Email address</value>
66@@ -126,6 +126,12 @@
67 <data name="LoginPasswordWatermark" xml:space="preserve">
68 <value>Password</value>
69 </data>
70+ <data name="LoginViewCancelButtonText" xml:space="preserve">
71+ <value>Cancel</value>
72+ </data>
73+ <data name="LoginViewConnectButtonText" xml:space="preserve">
74+ <value>Connect to Ubuntu One</value>
75+ </data>
76 <data name="LoginViewInfo" xml:space="preserve">
77 <value>To connect this computer to Ubuntu One enter your details below.</value>
78 </data>

Subscribers

People subscribed via source and target branches

to all changes: