Merge lp:~mandel/ubuntuone-windows-installer/check_tomboy_installed into lp:ubuntuone-windows-installer/beta

Proposed by Manuel de la Peña
Status: Merged
Approved by: Tim Cole
Approved revision: 11
Merged at revision: 36
Proposed branch: lp:~mandel/ubuntuone-windows-installer/check_tomboy_installed
Merge into: lp:ubuntuone-windows-installer/beta
Diff against target: 12 lines (+1/-1)
1 file modified
install/InstallerProject.xml (+1/-1)
To merge this branch: bzr merge lp:~mandel/ubuntuone-windows-installer/check_tomboy_installed
Reviewer Review Type Date Requested Status
Tim Cole (community) Approve
Stuart Colville (community) Approve
Review via email: mp+30367@code.launchpad.net

Description of the change

Adds a step that will check if Tomboy has been installed in the system, if it is present the bootstrapper will not try to install tomboy.

To post a comment you must log in.
Revision history for this message
Stuart Colville (muffinresearch) wrote :

If I un-install tomboy and then run setup.exe it displays that tomboy is still installed. This persists after a reboot.

Tomboy was uninstalled with add or remove programs.

review: Needs Fixing
Revision history for this message
Manuel de la Peña (mandel) wrote :

Can you let me know if in your registry key the following path exists:

HKEY_LOCAL_MACHINE\SOFTWARE\Tomboy

After Tomboy has been removed this path should not be present.

Revision history for this message
Stuart Colville (muffinresearch) wrote :

The registry key was there so I installed and uninstalled Tomboy and the problem seems to have dissappeared along with the registry key.

+1

review: Approve
Revision history for this message
Tim Cole (tcole) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'install/InstallerProject.xml'
2--- install/InstallerProject.xml 2010-07-19 12:45:11 +0000
3+++ install/InstallerProject.xml 2010-07-20 09:17:41 +0000
4@@ -16,7 +16,7 @@
5 </downloaddialog>
6 </component>
7 <component package="#TEMPPATH\ubuntuone\tomboy.msi" cmdparameters="" cmdparameters_silent="/qn" cmdparameters_basic="/qb-" uninstall_package="" uninstall_cmdparameters="/qb-" uninstall_cmdparameters_silent="/qn" uninstall_cmdparameters_basic="/qb-" id="Tomboy.msi" display_name="Tomboy Notes" uninstall_display_name="" os_filter_greater="80" os_filter_smaller="" os_filter_lcid="" type="msi" installcompletemessage="" uninstallcompletemessage="" mustreboot="False" reboot_required="" must_reboot_required="False" failed_exec_command_continue="" allow_continue_on_error="True" required="False" selected="True" note="" processor_architecture_filter="x86" status_installed="" status_notinstalled="" supports_install="True" supports_uninstall="True">
8- <installedcheck path="SOFTWARE\MyCompany\MyApplication\1.0.1.0" fieldname="Installed" fieldvalue="1" defaultvalue="False" fieldtype="REG_DWORD" comparison="match" rootkey="HKEY_LOCAL_MACHINE" wowoption="NONE" type="check_registry_value" description="Installed Check" />
9+ <installedcheck path="SOFTWARE\Tomboy" fieldname="InstallDir" fieldvalue="1" defaultvalue="False" fieldtype="REG_SZ" comparison="exists" rootkey="HKEY_LOCAL_MACHINE" wowoption="NONE" type="check_registry_value" description="Installed Check" />
10 <downloaddialog dialog_caption="Tomboy - Downloading Components" dialog_message="Press 'Start' to download the required components for installing &quot;Tomboy&quot;." dialog_message_downloading="Downloading ..." dialog_message_copying="Copying ..." dialog_message_connecting="Connecting ..." dialog_message_sendingrequest="Sending request ..." autostartdownload="True" buttonstart_caption="Start" buttoncancel_caption="Cancel">
11 <download componentname="Download Tomboy installer" sourceurl="http://s3.amazonaws.com/u1wintest/Tomboy-1.2.2.msi" sourcepath="" destinationpath="#TEMPPATH\ubuntuone" destinationfilename="tomboy.msi" alwaysdownload="True" clear_cache="False" />
12 </downloaddialog>

Subscribers

People subscribed via source and target branches

to all changes: