Merge lp:~mandel/ubuntuone-windows-installer/check_gtk_installed into lp:ubuntuone-windows-installer/beta

Proposed by Manuel de la Peña
Status: Merged
Approved by: Tim Cole
Approved revision: 11
Merged at revision: 37
Proposed branch: lp:~mandel/ubuntuone-windows-installer/check_gtk_installed
Merge into: lp:ubuntuone-windows-installer/beta
Diff against target: 15 lines (+2/-3)
1 file modified
install/InstallerProject.xml (+2/-3)
To merge this branch: bzr merge lp:~mandel/ubuntuone-windows-installer/check_gtk_installed
Reviewer Review Type Date Requested Status
Tim Cole (community) Approve
Stuart Colville (community) Approve
Review via email: mp+30365@code.launchpad.net

Description of the change

The bootstrapper checks that gtk-sharp is not present, if it is present, the gtk-sharp installation will not be performed.

To post a comment you must log in.
Revision history for this message
Stuart Colville (muffinresearch) wrote :

Works as expected with gtk-sharp present and after removing it.

review: Approve
Revision history for this message
Tim Cole (tcole) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'install/InstallerProject.xml'
2--- install/InstallerProject.xml 2010-07-19 12:45:11 +0000
3+++ install/InstallerProject.xml 2010-07-20 08:54:46 +0000
4@@ -8,9 +8,8 @@
5 <download componentname="Download Ubuntu One installer" sourceurl="http://s3.amazonaws.com/u1wintest/UbuntuOne.msi" sourcepath="" destinationpath="#TEMPPATH\ubuntuone" destinationfilename="ubuntuone.msi" alwaysdownload="True" clear_cache="False" />
6 </downloaddialog>
7 </component>
8- <component package="#TEMPPATH\ubuntuone\gtksharp.msi" cmdparameters="" cmdparameters_silent="/qn" cmdparameters_basic="/qb-" uninstall_package="" uninstall_cmdparameters="/qb-" uninstall_cmdparameters_silent="/qn" uninstall_cmdparameters_basic="/qb-" id="gtksharp.msi" display_name="Gtk Sharp (required if you are installing Tomboy)" uninstall_display_name="" os_filter_greater="80" os_filter_smaller="" os_filter_lcid="" type="msi" installcompletemessage="" uninstallcompletemessage="" mustreboot="False" reboot_required="" must_reboot_required="False" failed_exec_command_continue="" allow_continue_on_error="True" required="True" selected="True" note="" processor_architecture_filter="" status_installed="" status_notinstalled="" supports_install="True" supports_uninstall="True">
9- <installedcheck path="SOFTWARE\MyCompany\MyApplication\1.0.1.0" fieldname="Installed" fieldvalue="1" defaultvalue="False" fieldtype="REG_DWORD" comparison="match" rootkey="HKEY_LOCAL_MACHINE" wowoption="NONE" type="check_registry_value" description="Installed Check" />
10- <installedcheck path="SOFTWARE\MyCompany\MyApplication\1.0.1.0" fieldname="Installed" fieldvalue="1" defaultvalue="False" fieldtype="REG_DWORD" comparison="match" rootkey="HKEY_LOCAL_MACHINE" wowoption="NONE" type="check_registry_value" description="Installed Check" />
11+ <component package="#TEMPPATH\ubuntuone\gtksharp.msi" cmdparameters="" cmdparameters_silent="/qn" cmdparameters_basic="/qb-" uninstall_package="" uninstall_cmdparameters="/qb-" uninstall_cmdparameters_silent="/qn" uninstall_cmdparameters_basic="/qb-" id="gtksharp.msi" display_name="Gtk Sharp" uninstall_display_name="" os_filter_greater="80" os_filter_smaller="" os_filter_lcid="" type="msi" installcompletemessage="" uninstallcompletemessage="" mustreboot="False" reboot_required="" must_reboot_required="False" failed_exec_command_continue="" allow_continue_on_error="True" required="True" selected="True" note="" processor_architecture_filter="" status_installed="" status_notinstalled="" supports_install="True" supports_uninstall="True">
12+ <installedcheck path="SOFTWARE\Novell\GtkSharp\Version" fieldname="" fieldvalue="2.12.10" defaultvalue="False" fieldtype="REG_SZ" comparison="version_ge" rootkey="HKEY_LOCAL_MACHINE" wowoption="NONE" type="check_registry_value" description="Gtk Installed" />
13 <downloaddialog dialog_caption="Gtk Sharp - Downloading Components" dialog_message="Press 'Start' to download the required components for installing &quot;Gtk Sharp&quot;." dialog_message_downloading="Downloading ..." dialog_message_copying="Copying ..." dialog_message_connecting="Connecting ..." dialog_message_sendingrequest="Sending request ..." autostartdownload="True" buttonstart_caption="Start" buttoncancel_caption="Cancel">
14 <download componentname="Download GtkSharp installer" sourceurl="http://s3.amazonaws.com/u1wintest/gtk-sharp-2.12.10.win32.msi" sourcepath="" destinationpath="#TEMPPATH\ubuntuone" destinationfilename="gtksharp.msi" alwaysdownload="True" clear_cache="False" />
15 </downloaddialog>

Subscribers

People subscribed via source and target branches

to all changes: