Merge lp:~mandel/ubuntuone-windows-installer/add_load_preferences_test into lp:ubuntuone-windows-installer/beta

[Manuel de la Peña]

Adds extra testing for the load preferences startup task.

[lp:~mandel/ubuntuone-windows-installer/add_load_preferences_test]

101. By Manuel de la Peña on 2010-11-12

Added forgoten dir.

[John Lenton (chipaca)]

review: Approve

=== modified file 'src/Canonical.UbuntuOne.Client.Test/Canonical.UbuntuOne.Client.Test.csproj'
--- src/Canonical.UbuntuOne.Client.Test/Canonical.UbuntuOne.Client.Test.csproj	2010-10-12 13:07:02 +0000
+++ src/Canonical.UbuntuOne.Client.Test/Canonical.UbuntuOne.Client.Test.csproj	2010-11-12 14:14:32 +0000
@@ -87,9 +87,14 @@
     <Compile Include="Notification\OperationCompletenessEventArgsFixture.cs" />
     <Compile Include="Notification\RecentlyModifiedEventArgsFixture.cs" />
     <Compile Include="Notification\StateEventArgsFixture.cs" />
+    <Compile Include="Preferences\LoadPreferencesStartupTaskFixture.cs" />
     <Compile Include="Properties\AssemblyInfo.cs" />
   </ItemGroup>
   <ItemGroup>
+    <ProjectReference Include="..\Canonical.Ubuntu.SSO\Canonical.Ubuntu.SSO.csproj">
+      <Project>{9460A771-2589-45DA-9618-9FE8BB7D16E8}</Project>
+      <Name>Canonical.Ubuntu.SSO</Name>
+    </ProjectReference>
     <ProjectReference Include="..\Canonical.UbuntuOne.Client\Canonical.UbuntuOne.Client.csproj">
       <Project>{7467483A-D6D5-4362-8DF4-57A7254EB569}</Project>
       <Name>Canonical.UbuntuOne.Client</Name>

=== added directory 'src/Canonical.UbuntuOne.Client.Test/Preferences'
=== added file 'src/Canonical.UbuntuOne.Client.Test/Preferences/LoadPreferencesStartupTaskFixture.cs'
--- src/Canonical.UbuntuOne.Client.Test/Preferences/LoadPreferencesStartupTaskFixture.cs	1970-01-01 00:00:00 +0000
+++ src/Canonical.UbuntuOne.Client.Test/Preferences/LoadPreferencesStartupTaskFixture.cs	2010-11-12 14:14:32 +0000
@@ -0,0 +1,149 @@
+/* Copyright 2010 Canonical Ltd.
+ * 
+ * This file is part of UbuntuOne on Windows.
+ * 
+ * UbuntuOne on Windows is free software: you can redistribute it and/or modify		
+ * it under the terms of the GNU Lesser General Public License version 		
+ * as published by the Free Software Foundation.		
+ *		
+ * Ubuntu One on Windows is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the	
+ * GNU Lesser General Public License for more details.	
+ *
+ * You should have received a copy of the GNU Lesser General Public License	
+ * along with UbuntuOne for Windows.  If not, see <http://www.gnu.org/licenses/>.
+ * 
+ * Authors: Manuel de la Peña <[e-mail]>
+ */
+using System.Collections.Generic;
+using Canonical.Ubuntu.SSO;
+using Canonical.UbuntuOne.Client.Preferences;
+using Canonical.UbuntuOne.Common;
+using NUnit.Framework;
+using Rhino.Mocks;
+using Rhino.Mocks.Interfaces;
+
+namespace Canonical.UbuntuOne.Client.Test.Preferences
+{
+    [TestFixture]
+    public class LoadPreferencesStartupTaskFixture
+    {
+        #region Variables
+
+        private ISSOCredentialsProvider _ssoProvider;
+        private IPreferencesManager _preferencesManager;
+        private ISyncDaemon _syncdaemon;
+        private IMessageBox _messageBox;
+        private MockRepository _mocks;
+        private LoadPreferencesStartupTask _task;
+
+        #endregion
+
+        #region Setup
+
+        [SetUp]
+        public void Setup()
+        {
+            _mocks = new MockRepository();
+            _ssoProvider = _mocks.StrictMock<ISSOCredentialsProvider>();
+            _preferencesManager = _mocks.StrictMock<IPreferencesManager>();
+            _syncdaemon = _mocks.StrictMock<ISyncDaemon>();
+            _messageBox = _mocks.StrictMock<IMessageBox>();
+            _task = new LoadPreferencesStartupTask
+            {
+                SSOCredentialsProvider = _ssoProvider,
+                PreferencesManager = _preferencesManager,
+                SyncDaemon = _syncdaemon,
+                MessageBox = _messageBox
+            };
+            // we start recording again, the reason is that the assigment of the SSOProvider does
+            // register the callback used for the events.
+            _mocks.BackToRecordAll();
+        }
+
+        #endregion
+
+        #region Tests
+
+        [Test]
+        public void ExecuteNotAutoSyncEnabledTest()
+        {
+            using(_mocks.Record())
+            {
+                Expect.Call(_preferencesManager.IsAutoSyncEnable)
+                    .Return(false)
+                    .Repeat.Once();
+            }
+            using(_mocks.Playback())
+            {
+                // we execute and expect nothing to occur
+                _task.Exeucte();
+            }
+        }
+
+        [Test]
+        public void ExecuteAutoSyncEnabledTest()
+        {
+            using (_mocks.Record())
+            {
+                Expect.Call(_preferencesManager.IsAutoSyncEnable)
+                    .Return(true)
+                    .Repeat.Once();
+                Expect.Call(() => _ssoProvider.LoginToGetCredentials(LoadPreferencesStartupTask.EventName,
+                                                                     LoadPreferencesStartupTask.ApplicationName))
+                    .Repeat.Once();
+            }
+            using (_mocks.Playback())
+            {
+                _task.Exeucte();
+            }
+        }
+
+        [Test]
+        public void CredentialsFoundTest()
+        {
+            // we reassign the sso provider, so that we test that the events are correctly set,
+            // then throw an event and esure that the correct operation is performed
+            var credentials = new Dictionary<string, string>
+            {
+                {"Token", "Token"},
+                {"TokenSecret", "TokenSecret"},
+                {"ConsumerKey", "ConsumerKey"},
+                {"ConsumerSecret", "ConsumerSecret"}
+            };
+            IEventRaiser onCredentialsFound;
+            var args = new CredentialsFoundEventArgs(LoadPreferencesStartupTask.EventName, credentials);
+            using (_mocks.Record())
+            {
+                _ssoProvider.OnCredentialsError += null;
+                LastCall.IgnoreArguments();
+                _ssoProvider.OnCredentialsFound += null;
+                onCredentialsFound = LastCall.IgnoreArguments().GetEventRaiser();
+                _ssoProvider.OnCredetialsDenied += null;
+                LastCall.IgnoreArguments();
+                // code expected to execute once the event is raised
+                Expect.Call(_preferencesManager.AutoSyncFrequency)
+                    .Return(10)
+                    .Repeat.Once();
+                // TODO: We ougth to either patch RhinoMocks to allo to ignore one param, or create an object to mock that
+                // will return the path, I'm inclened towards the second option
+                Expect.Call(() => _syncdaemon.EnableManualSyncAutoExecution(
+                    "",
+                    credentials["Token"],
+                    credentials["TokenSecret"],
+                    credentials["ConsumerKey"],
+                    credentials["ConsumerSecret"], 10))
+                    .IgnoreArguments()
+                    .Repeat.Once();
+            }
+            using(_mocks.Playback())
+            {
+                _task.SSOCredentialsProvider = _ssoProvider;
+                onCredentialsFound.Raise(this, args);
+            }
+        }
+
+        #endregion
+    }
+}

=== modified file 'src/Canonical.UbuntuOne.Client/Preferences/LoadPreferencesStartupTask.cs'
--- src/Canonical.UbuntuOne.Client/Preferences/LoadPreferencesStartupTask.cs	2010-11-11 11:43:38 +0000
+++ src/Canonical.UbuntuOne.Client/Preferences/LoadPreferencesStartupTask.cs	2010-11-12 14:14:32 +0000
@@ -34,8 +34,8 @@
         #region Variables
 
         private ISSOCredentialsProvider _ssoProvider;
-        private const string EventName = "PreferencesStartupLoad";
-        private const string ApplicationName = "UbuntuOne";
+        internal const string EventName = "PreferencesStartupLoad";
+        internal const string ApplicationName = "UbuntuOne";
         private ILog _logger;
         private readonly object _loggerLock = new object();
 

=== modified file 'src/UbuntuOneClient/App.config'
--- src/UbuntuOneClient/App.config	2010-11-10 13:47:12 +0000
+++ src/UbuntuOneClient/App.config	2010-11-12 14:14:32 +0000
@@ -29,13 +29,13 @@
   
   <spring>
     <context>
-      <resource uri="assembly://UbuntuOneClient/UbuntuOneClient/objects.xml"/>
       <resource uri="assembly://Canonical.Ubuntu.SSO/Canonical.Ubuntu.SSO/objects.xml"/>
       <resource uri="assembly://Canonical.Ubuntu.SSO.Views/Canonical.Ubuntu.SSO.Views/objects.xml"/>
       <resource uri="assembly://Canonical.UbuntuOne.Client/Canonical.UbuntuOne.Client/objects.xml"/>
       <resource uri="assembly://Canonical.UbuntuOne.Client.Views/Canonical.UbuntuOne.Client.Views/objects.xml"/>
       <resource uri="assembly://Canonical.UbuntuOne.Common/Canonical.UbuntuOne.Common/objects.xml"/>
       <resource uri="assembly://Canonical.UbuntuOne.ProcessDispatcher/Canonical.UbuntuOne.ProcessDispatcher/objects.xml"/>
+      <resource uri="assembly://UbuntuOneClient/UbuntuOneClient/objects.xml"/>
     </context>
     
   </spring>

=== modified file 'src/UbuntuOneClient/Program.cs'
--- src/UbuntuOneClient/Program.cs	2010-10-19 12:34:50 +0000
+++ src/UbuntuOneClient/Program.cs	2010-11-12 14:14:32 +0000
@@ -160,9 +160,6 @@
 
             ObjectsContainer.Initialize(new SpringContainer());
             var program = ObjectsContainer.GetImplementationOf<Program>();
-            // HACK: This should be done by the IoC and not manually
-            program.Application.StartupTasks.Add(ObjectsContainer.GetImplementationOf<PipeListeningStartupTask>());
-            program.Application.StartupTasks.Add(ObjectsContainer.GetImplementationOf<LoadPreferencesStartupTask>());
             program.StartApplication();
 
         }

=== modified file 'src/UbuntuOneClient/objects.xml'
--- src/UbuntuOneClient/objects.xml	2010-10-19 12:34:50 +0000
+++ src/UbuntuOneClient/objects.xml	2010-11-12 14:14:32 +0000
@@ -48,10 +48,9 @@
   </object>
   
   <object id="Application"
-          type="UbuntuOneClient.ApplicationWrapper, UbuntuOneClient" >
+          type="Canonical.UbuntuOne.Common.Utils.ApplicationWrapper, Canonical.UbuntuOne.Common" >
     <property name="StartupTasks">
       <list element-type="Canonical.UbuntuOne.Common.Utils.IStartupTask, Canonical.UbuntuOne.Common">
-        <value>1</value>
         <ref object="PipeListeningStartupTask"/> <!-- task that ensures that we listen to messages from python-->
         <ref object="LoadPreferencesStartupTask"/> <!-- Load the preferences -->
       </list>