ubuntuone-dev-tools

Merge lp:~mandel/ubuntuone-dev-tools/remove-redundancy into lp:ubuntuone-dev-tools

  1. remove-redundancy
  2. Merge into trunk
Proposed by Manuel de la Peña on 2012-05-22
Status: Merged
Approved by: Alejandro J. Cura on 2012-05-22
Approved revision: 73
Merged at revision: 73
Proposed branch: lp:~mandel/ubuntuone-dev-tools/remove-redundancy
Merge into: lp:ubuntuone-dev-tools
Diff against target: 11 lines (+0/-1)
1 file modified
ubuntuone/devtools/testcases/txsocketserver.py (+0/-1)
To merge this branch: bzr merge lp:~mandel/ubuntuone-dev-tools/remove-redundancy
Reviewer Review Type Date Requested Status
Alejandro J. Cura (community) Approve on 2012-05-22
Eric Casteleijn (community) 2012-05-22 Approve on 2012-05-22
Review via email: mp+106816@code.launchpad.net

Commit Message

Remove a line of code that is redundant. Less code == less bugs.

Description of the Change

Remove a line of code that is redundant. Less code == less bugs.

To post a comment you must log in.
Eric Casteleijn (thisfred) wrote :

yeah makes sense

review: Approve
Alejandro J. Cura (alecu) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubuntuone/devtools/testcases/txsocketserver.py'
2--- ubuntuone/devtools/testcases/txsocketserver.py 2012-05-22 12:07:22 +0000
3+++ ubuntuone/devtools/testcases/txsocketserver.py 2012-05-22 14:23:18 +0000
4@@ -276,7 +276,6 @@
5 """Clean the server and client."""
6 if self.server_runner:
7 return self.server_runner.clean_up()
8- return defer.succeed(None)
9
10
11 class TCPServerTestCase(ServerTestCase):

Subscribers

People subscribed via source and target branches

to all changes: