Merge lp:~mandel/ubuntuone-dev-tools/give-me-batch into lp:ubuntuone-dev-tools

[Manuel de la Peña]

This branch provides the batch scripts that allow to execute u1trial and u1lint without the need of calling python as long as the C:\Python27\Scripts has been added to the search path.

This branch provides the batch scripts that allow to execute u1trial and u1lint without the need of calling python as long as the C:\Python27\Scripts has been added to the search path.

This makes the executing from being:

python C:\Python27\Scripts\u1trial path_to_tests

to

u1trial path_to_tests.

[lp:~mandel/ubuntuone-dev-tools/give-me-batch]

55. By Manuel de la Peña on 2012-01-12

Added the missing scripts.

[Diego Sarmentero (diegosarmentero)]

== Python Lint Notices ==

bin/u1lint:
    237: [W0511] XXX Testing that W0511 does not cause a failure
    237: [W0511] XXX Testing that W0511 does not cause a failure

setup.py:
    47: [C0322] Operator not preceded by a space
           ^
             'bin/u1trial',]
    47: [C0103] Invalid name "scripts" (should match (([A-Z_][A-Z0-9_]*)|(__.*__))$)

review: Needs Fixing

[lp:~mandel/ubuntuone-dev-tools/give-me-batch]

56. By Manuel de la Peña on 2012-01-12

Fixed the style issues.

57. By Manuel de la Peña on 2012-01-12

Cleaned style issues and ensure that .bat files are not checked for style.

[Diego Sarmentero (diegosarmentero)]

+1
Tests OK, Test it IRL ok.

Great! :D

review: Approve

[Roberto Alsina (ralsina)]

+1 nice!

review: Approve

=== added file 'bin/u1lint.bat'
--- bin/u1lint.bat	1970-01-01 00:00:00 +0000
+++ bin/u1lint.bat	2012-01-12 12:16:05 +0000
@@ -0,0 +1,17 @@
+::
+:: Copyright 2012 Canonical Ltd.
+::
+:: This program is free software: you can redistribute it and/or modify it
+:: under the terms of the GNU General Public License version 3, as published
+:: by the Free Software Foundation.
+::
+:: This program is distributed in the hope that it will be useful, but
+:: WITHOUT ANY WARRANTY; without even the implied warranties of
+:: MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR
+:: PURPOSE.  See the GNU General Public License for more details.
+::
+:: You should have received a copy of the GNU General Public License along
+:: with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+:: Use python to execute the script having the same name as this batch
+python "%~dpn0" %*

=== added file 'bin/u1trial.bat'
--- bin/u1trial.bat	1970-01-01 00:00:00 +0000
+++ bin/u1trial.bat	2012-01-12 12:16:05 +0000
@@ -0,0 +1,17 @@
+::
+:: Copyright 2012 Canonical Ltd.
+::
+:: This program is free software: you can redistribute it and/or modify it
+:: under the terms of the GNU General Public License version 3, as published
+:: by the Free Software Foundation.
+::
+:: This program is distributed in the hope that it will be useful, but
+:: WITHOUT ANY WARRANTY; without even the implied warranties of
+:: MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR
+:: PURPOSE.  See the GNU General Public License for more details.
+::
+:: You should have received a copy of the GNU General Public License along
+:: with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+:: Use python to execute the script having the same name as this batch
+python "%~dpn0" %*

=== modified file 'run-tests'
--- run-tests	2011-11-29 17:42:55 +0000
+++ run-tests	2012-01-12 12:16:05 +0000
@@ -20,6 +20,6 @@
 bin/u1trial --reactor=twisted ubuntuone
 echo "Running style checks..."
 bin/u1lint
-pep8 --repeat . bin/*
+pep8 --repeat . bin/* --exclude=*.bat
 rm -rf _trial_temp
 rm -rf .coverage

=== modified file 'setup.py'
--- setup.py	2012-01-09 21:03:29 +0000
+++ setup.py	2012-01-12 12:16:05 +0000
@@ -44,6 +44,15 @@
         if retcode != 0:
             sys.exit(retcode)
 
+# pylint: disable=C0103
+scripts = ['bin/u1lint',
+           'bin/u1trial']
+# pylint: enable=C0103
+
+if sys.platform == 'win32':
+    # lets add the .bat so that windows users are happy
+    scripts.extend(['bin/u1lint.bat', 'bin/u1trial.bat'])
+
 setup(name=PACKAGE,
       version=VERSION,
       description='Ubuntu One development tools and utilities',
@@ -55,9 +64,7 @@
                 'ubuntuone.devtools.testing',
                 'ubuntuone.devtools.testcases'],
       extra_path='ubuntuone-dev-tools',
-      scripts=['bin/u1lint',
-               'bin/u1trial',
-               ],
+      scripts=scripts,
       data_files=[('share/%s' % PACKAGE,
                    ['pylintrc',
                     'data/dbus-session.conf.in',