Code review comment for lp:~mandel/ubuntuone-control-panel/auto-update-looping-call

Alejandro J. Cura (alecu) wrote :

The TrayIcon constructor takes a LoopingCall as a parameter, but it's never used in production code.
It should be either removed or used.

---

Both FakeMainWindow and FakeTrayIcon are modifying the class attributes.
For instance:
   FakeMainWindow.close_callback = close_callback

The tests should be operating on object instances instead of classes, since modifying classes is bad form and causes maintenance issues.

review: Needs Fixing

« Back to merge proposal