Code review comment for lp:~mandel/ubuntuone-control-panel/auto-update-looping-call

Natalia Bidart (nataliabidart) wrote :

This import code:

from ubuntuone.controlpanel.utils import (autoupdate,
    AUTOUPDATE_INTERVAL,
)

should be:

from ubuntuone.controlpanel.utils import (
    autoupdate,
    AUTOUPDATE_INTERVAL,
)

Also, in ubuntuone/controlpanel/gui/qt/gui.py, seems like this change is unrelated and may not be the desired one?

47 - if with_icon or minimized:
48 + if with_icon:

review: Needs Fixing

« Back to merge proposal