Ubuntu One Client

Merge lp:~mandel/ubuntuone-client/sys-init-done-darwin into lp:ubuntuone-client

  1. sys-init-done-darwin
  2. Merge into trunk
Proposed by Manuel de la Peña on 2012-06-19
Status: Merged
Approved by: Mike McCracken on 2012-06-19
Approved revision: 1262
Merged at revision: 1261
Proposed branch: lp:~mandel/ubuntuone-client/sys-init-done-darwin
Merge into: lp:ubuntuone-client
Diff against target: 9 lines (+1/-1)
1 file modified
ubuntuone/platform/os_helper/darwin.py (+1/-1)
To merge this branch: bzr merge lp:~mandel/ubuntuone-client/sys-init-done-darwin
Reviewer Review Type Date Requested Status
Mike McCracken (community) Approve on 2012-06-19
Diego Sarmentero (community) 2012-06-19 Approve on 2012-06-19
Review via email: mp+110967@code.launchpad.net

Commit Message

- Do not raise exception in set_application_name so that the sys_init_done signal is pushed to the state machine (LP: #1015003).

Description of the Change

- Do not raise exception in set_application_name so that the sys_init_done signal is pushed to the state machine (LP: #1015003).

To post a comment you must log in.
Diego Sarmentero (diegosarmentero) wrote :

+1

review: Approve
lp:~mandel/ubuntuone-client/sys-init-done-darwin updated on 2012-06-19
1262. By Manuel de la Peña on 2012-06-19

Remove the TODO comment.

Mike McCracken (mikemc) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubuntuone/platform/os_helper/darwin.py'
2--- ubuntuone/platform/os_helper/darwin.py 2012-05-17 12:23:12 +0000
3+++ ubuntuone/platform/os_helper/darwin.py 2012-06-19 15:00:28 +0000
4@@ -107,4 +107,4 @@
5
6 def set_application_name(app_name):
7 """Set the name of the application."""
8- raise Exception("This is not the way to do it on OS X")
9+ # nothing to be done let the plist take care of it

Subscribers

People subscribed via source and target branches