Merge lp:~mandel/ubuntuone-client/ignore-ds-store into lp:ubuntuone-client

[Manuel de la Peña]

- Add the pattern to ignore the .DS_Store files coming from darwin (LP: #1034138).

- Add the pattern to ignore the .DS_Store files coming from darwin (LP: #1034138).

[Eric Casteleijn (thisfred)]

review: Approve

[dobey (dobey)]

Please fix the indentation to use only spaces instead of tabs and spaces, like the rest of the lines in the config file. This is why the diff appears off.

review: Needs Fixing

[lp:~mandel/ubuntuone-client/ignore-ds-store]

1305. By Manuel de la Peña on 2012-08-30

Do not mix tabs and spaces.

[dobey (dobey)]

review: Approve

[Vincent Ladeuil (vila)]

I can't help but notice that .DS_Store contains data relevant to OSX users and as such may be interesting to sync between OSX machines.

Now, like you, I'm annoyed to see .DS_Store come up on my non-OSX machines...

But the right solution may not be to just ignore them no ?

[Manuel de la Peña (mandel)]

Vincent,

The DS_Store file is a hidden file that stores metadata. Those files are created by the finder and are simple custom attributes (icon positions, views settings, etc..) While it might be useful for the user to sync those settings that does not out weight how annoying it will be to have such files on Windows and Linux. Apple already had a bug filled prior 10.4 because users did not like the fact that the finder would create .ds_store files in remote drives, I think we can assume that the most common use case would be users being annoyed by these files.

=== modified file 'data/syncdaemon.conf'
--- data/syncdaemon.conf	2012-07-17 10:51:43 +0000
+++ data/syncdaemon.conf	2012-08-30 15:21:17 +0000
@@ -86,6 +86,7 @@
                  \A\.~lock\..*#\Z
                  \A\.goutputstream-.*\Z
                  \A.*-Spotlight\Z
+                 \A\.DS_Store\Z
  
 use_trash.default = True
 use_trash.parser = bool