Ubuntu One Client

Merge lp:~mandel/ubuntuone-client/fsevents-new-api into lp:ubuntuone-client

  1. fsevents-new-api
  2. Merge into trunk
Proposed by Manuel de la Peña on 2012-08-23
Status: Merged
Approved by: Mike McCracken on 2012-08-23
Approved revision: 1293
Merged at revision: 1293
Proposed branch: lp:~mandel/ubuntuone-client/fsevents-new-api
Merge into: lp:ubuntuone-client
Diff against target: 12 lines (+1/-1)
1 file modified
ubuntuone/platform/filesystem_notifications/monitor/darwin/fsevents_client.py (+1/-1)
To merge this branch: bzr merge lp:~mandel/ubuntuone-client/fsevents-new-api
Reviewer Review Type Date Requested Status
Mike McCracken (community) 2012-08-23 Approve on 2012-08-23
Review via email: mp+121053@code.launchpad.net

Commit Message

- Used the new API (LP: #1040170).
- Create events now have in_modify thx to the new API (LP: #1034127).

Description of the Change

- Used the new API (LP: #1040170).
- Create events now have in_modify thx to the new API (LP: #1034127).

Please take a look at https://github.com/mandel-macaque/macfsevents to find the fork of the macfsevents code that fixes the issues. We will attempt to fix this in the future with upstream.

To post a comment you must log in.
Mike McCracken (mikemc) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubuntuone/platform/filesystem_notifications/monitor/darwin/fsevents_client.py'
2--- ubuntuone/platform/filesystem_notifications/monitor/darwin/fsevents_client.py 2012-07-13 15:08:15 +0000
3+++ ubuntuone/platform/filesystem_notifications/monitor/darwin/fsevents_client.py 2012-08-23 16:55:21 +0000
4@@ -124,7 +124,7 @@
5 def __init__(self, log):
6 """Init the manager to keep track of the different watches."""
7 self.log = log
8- self.observer = fsevents.Observer()
9+ self.observer = fsevents.Observer(latency=0, process_asap=True)
10 self.observer.start()
11
12 def stop_watch(self, watch):

Subscribers

People subscribed via source and target branches