Merge lp:~mandel/ubuntuone-client/add_dbus_folders_tests into lp:ubuntuone-client

Proposed by Manuel de la Peña
Status: Merged
Approved by: Manuel de la Peña
Approved revision: 866
Merged at revision: 882
Proposed branch: lp:~mandel/ubuntuone-client/add_dbus_folders_tests
Merge into: lp:ubuntuone-client
Prerequisite: lp:~mandel/ubuntuone-client/add_dbus_shares_signal_tests
Diff against target: 84 lines (+74/-0)
1 file modified
tests/platform/linux/test_dbus.py (+74/-0)
To merge this branch: bzr merge lp:~mandel/ubuntuone-client/add_dbus_folders_tests
Reviewer Review Type Date Requested Status
Alejandro J. Cura (community) Approve
Guillermo Gonzalez Approve
Review via email: mp+50564@code.launchpad.net

Commit message

Add extra tests that will ensure that the emit methods in the Folders dbus class are correct.

Description of the change

Add extra tests that will ensure that the emit methods in the Folders dbus class are correct.

To post a comment you must log in.
Revision history for this message
Guillermo Gonzalez (verterok) wrote :

+1

review: Approve
Revision history for this message
Alejandro J. Cura (alecu) wrote :

More tests, yay!

review: Approve
Revision history for this message
Ubuntu One Auto Pilot (otto-pilot) wrote :
Revision history for this message
Ubuntu One Auto Pilot (otto-pilot) wrote :
Revision history for this message
Ubuntu One Auto Pilot (otto-pilot) wrote :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/platform/linux/test_dbus.py'
2--- tests/platform/linux/test_dbus.py 2011-02-21 09:30:55 +0000
3+++ tests/platform/linux/test_dbus.py 2011-02-21 09:30:55 +0000
4@@ -3807,6 +3807,80 @@
5 self.shares.emit_share_unsubscribe_error(share_id, error)
6
7
8+class TestFoldersEmitSignals(DBusTwistedTestCase, MockerTestCase):
9+ """Test that the emit method have been correctly implemented."""
10+
11+ def setUp(self):
12+ """Setup tests."""
13+ super(TestFoldersEmitSignals, self).setUp()
14+ self.signal_method = self.mocker.mock()
15+ self.get_udf_dict = self.mocker.replace(
16+ 'ubuntuone.syncdaemon.interaction_interfaces.get_udf_dict')
17+
18+ def test_emit_folder_deleted(self):
19+ """Emit the FolderCreated signal"""
20+ folder = 'folder'
21+ udf_dict = {'udf':'id'}
22+ self.get_udf_dict(folder)
23+ self.mocker.result(udf_dict)
24+ self.folders.FolderDeleted = self.signal_method
25+ self.signal_method(udf_dict)
26+ self.mocker.replay()
27+ self.folders.emit_folder_deleted(folder)
28+
29+ def test_emit_folder_delete_error(self):
30+ """Emit the FolderCreateError signal"""
31+ folder = 'folder'
32+ error = 'error'
33+ udf_dict = {'udf':'id'}
34+ self.get_udf_dict(folder)
35+ self.mocker.result(udf_dict)
36+ self.folders.FolderDeleteError = self.signal_method
37+ self.signal_method(udf_dict, str(error))
38+ self.mocker.replay()
39+ self.folders.emit_folder_delete_error(folder, error)
40+
41+ def test_emit_folder_subscribed(self):
42+ """Emit the FolderSubscribed signal"""
43+ folder = 'folder'
44+ udf_dict = {'udf':'id'}
45+ self.get_udf_dict(folder)
46+ self.mocker.result(udf_dict)
47+ self.folders.FolderSubscribed = self.signal_method
48+ self.signal_method(udf_dict)
49+ self.mocker.replay()
50+ self.folders.emit_folder_subscribed(folder)
51+
52+ def test_emit_folder_subscribe_error(self):
53+ """Emit the FolderSubscribeError signal"""
54+ folder_id = 'id'
55+ error = 'error'
56+ self.folders.FolderSubscribeError = self.signal_method
57+ self.signal_method({'id':folder_id}, str(error))
58+ self.mocker.replay()
59+ self.folders.emit_folder_subscribe_error(folder_id, error)
60+
61+ def test_emit_folder_unsubscribed(self):
62+ """Emit the FolderUnSubscribed signal"""
63+ folder = 'folder'
64+ udf_dict = {'udf':'id'}
65+ self.get_udf_dict(folder)
66+ self.mocker.result(udf_dict)
67+ self.folders.FolderUnSubscribed = self.signal_method
68+ self.signal_method(udf_dict)
69+ self.mocker.replay()
70+ self.folders.emit_folder_unsubscribed(folder)
71+
72+ def test_emit_folder_unsubscribe_error(self):
73+ """Emit the FolderUnSubscribeError signal"""
74+ folder_id = 'id'
75+ error = 'error'
76+ self.folders.FolderUnSubscribeError= self.signal_method
77+ self.signal_method({'id':folder_id}, str(error))
78+ self.mocker.replay()
79+ self.folders.emit_folder_unsubscribe_error(folder_id, error)
80+
81+
82 def test_suite():
83 """Collect these tests only on linux."""
84 import sys

Subscribers

People subscribed via source and target branches