Merge lp:~mandel/ubuntu-system-settings/invalidate-credentials into lp:ubuntu-system-settings

[Manuel de la Peña]

Invalidate creds in the sso service when they are not valid.

Even when we find creds in the system, they ight be invalid. This branch ensure that it they are not the system invalidates them and we are requested to log before even looking for updates.

[lp:~mandel/ubuntu-system-settings/invalidate-credentials]

1512. By Manuel de la Peña on 2015-08-25

Readd wrongly deleted line.

[dobey (dobey)]

This is wrong.

The isValid() method on the Token object does not validate the token against the server. It only validates that the token object has all the data fields necessary to sign a request. Any token you get in the signal as a result of the request to get the credentials, from libubuntuoneauth, will be valid in that sense.

review: Disapprove

[Manuel de la Peña (mandel)]

Lame... We will need to do a lot more work to fix this :-/

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1512
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/2352/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/3856
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-vivid-amd64-ci/127
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-vivid-i386-ci/536
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/3167
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3853
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3853/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/22821

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/2352/rebuild

review: Needs Fixing (continuous-integration)

[Sebastien Bacher (seb128)]

changing to work in progress to get out of the review queue since the previous comment showed issues that need to be resolved

Unmerged revisions

1512. By Manuel de la Peña on 2015-08-25

Readd wrongly deleted line.

1511. By Manuel de la Peña on 2015-08-25

Invalidate credentials if they are found yet not valid.

=== modified file 'plugins/system-update/update_manager.cpp'
--- plugins/system-update/update_manager.cpp	2015-08-25 16:39:45 +0000
+++ plugins/system-update/update_manager.cpp	2015-08-25 16:39:45 +0000
@@ -164,11 +164,15 @@
 
 void UpdateManager::handleCredentialsFound(Token token)
 {
-    m_token = token;
-    QStringList args("list");
-    args << "--manifest";
-    QString command = getClickCommand();
-    m_process.start(command, args);
+    if (token.isValid()) {
+        m_token = token;
+        QStringList args("list");
+        args << "--manifest";
+        QString command = getClickCommand();
+        m_process.start(command, args);
+    } else {
+        m_service.invalidateCredentials();
+    }
 }
 
 QString UpdateManager::getClickCommand()