Merge lp:~mandel/ubuntu-sso-client/use-qt4-webclient-backend into lp:ubuntu-sso-client
Proposed by
Manuel de la Peña
Status: | Merged |
---|---|
Approved by: | Roberto Alsina |
Approved revision: | 923 |
Merged at revision: | 924 |
Proposed branch: | lp:~mandel/ubuntu-sso-client/use-qt4-webclient-backend |
Merge into: | lp:ubuntu-sso-client |
Diff against target: |
162 lines (+46/-34) 4 files modified
ubuntu_sso/utils/webclient/__init__.py (+15/-2) ubuntu_sso/utils/webclient/common.py (+1/-0) ubuntu_sso/utils/webclient/qtnetwork.py (+10/-25) ubuntu_sso/utils/webclient/tests/test_webclient.py (+20/-7) |
To merge this branch: | bzr merge lp:~mandel/ubuntu-sso-client/use-qt4-webclient-backend |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Roberto Alsina (community) | Approve | ||
Alejandro J. Cura (community) | Approve | ||
Review via email: mp+97934@code.launchpad.net |
Description of the change
- Stopped listening to the proxyAuthentica
- Made changes in the way the webclient is selected to ensure that qt is used when possible (LP: #957169)
Some tests have been skipped because Qt sucks in some areas which has been filled as bug #957313
To post a comment you must log in.
Tested IRL, seems to work both with authenticated proxies, with non-authenticated proxies and with no proxies.