Ubuntu Single Sign On Client

Merge lp:~mandel/ubuntu-sso-client/send-signals into lp:ubuntu-sso-client

  1. send-signals
  2. Merge into trunk
Proposed by Mike McCracken on 2012-09-11
Status: Merged
Approved by: Roberto Alsina on 2012-09-11
Approved revision: 999
Merged at revision: 997
Proposed branch: lp:~mandel/ubuntu-sso-client/send-signals
Merge into: lp:ubuntu-sso-client
Diff against target: 14 lines (+3/-1)
1 file modified
ubuntu_sso/utils/runner/__init__.py (+3/-1)
To merge this branch: bzr merge lp:~mandel/ubuntu-sso-client/send-signals
Reviewer Review Type Date Requested Status
Roberto Alsina (community) 2012-09-11 Approve on 2012-09-11
Review via email: mp+123801@code.launchpad.net

Commit Message

- Use twisted process runner on darwin so we get process-finished notifications. (LP: #1043754)

Description of the Change

- Use twisted process runner on darwin so we get process-finished notifications. (LP: #1043754)

Using the Qt runner on darwin doesn't correctly send the notification when the backend completes.
This causes a client app such as u1-control-panel to be frozen waiting for SSO. See e.g. bug #1037322.

NOTE: Since this is a workaround, the original Qt issue has been filed as bug #1049283 .

To post a comment you must log in.
Roberto Alsina (ralsina) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubuntu_sso/utils/runner/__init__.py'
2--- ubuntu_sso/utils/runner/__init__.py 2012-04-09 17:38:24 +0000
3+++ ubuntu_sso/utils/runner/__init__.py 2012-09-11 18:01:35 +0000
4@@ -77,7 +77,9 @@
5 logger.debug('spawn_program: requested to spawn %r.', repr(args))
6 d = defer.Deferred()
7
8- if use_reactor:
9+ # HACK: The qt runner does have problem in mac os x and does not raise the
10+ # finish signal
11+ if use_reactor or sys.platform == 'darwin':
12 from ubuntu_sso.utils.runner import tx
13 source = tx
14 elif is_qt4_main_loop_installed():

Subscribers

People subscribed via source and target branches