Merge lp:~mandel/ubuntu-sso-client/ping_url_issues_windows into lp:ubuntu-sso-client

Proposed by Manuel de la Peña
Status: Merged
Approved by: Manuel de la Peña
Approved revision: 712
Merged at revision: 712
Proposed branch: lp:~mandel/ubuntu-sso-client/ping_url_issues_windows
Merge into: lp:ubuntu-sso-client
Diff against target: 22 lines (+3/-2)
1 file modified
ubuntu_sso/qt/controllers.py (+3/-2)
To merge this branch: bzr merge lp:~mandel/ubuntu-sso-client/ping_url_issues_windows
Reviewer Review Type Date Requested Status
dobey (community) Approve
Shane Fagan (community) Approve
Review via email: mp+59799@code.launchpad.net

Commit message

Fixes lp:776488

Ensures that the QStrings from the UI are casted to str.

Description of the change

Fixes lp:776488

Ensures that the QStrings from the UI are casted to str.

To post a comment you must log in.
Revision history for this message
Shane Fagan (shanepatrickfagan) wrote :

+1

review: Approve
Revision history for this message
dobey (dobey) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubuntu_sso/qt/controllers.py'
2--- ubuntu_sso/qt/controllers.py 2011-04-15 09:04:10 +0000
3+++ ubuntu_sso/qt/controllers.py 2011-05-03 16:47:58 +0000
4@@ -707,7 +707,7 @@
5 def on_login_success(self, app_name, email):
6 """Process the success of a login."""
7 logger.debug('UbuntuSSOWizardController.on_login_success')
8- result = yield self.login_success_callback(app_name, email)
9+ result = yield self.login_success_callback(str(app_name), str(email))
10 logger.debug('Result from callback is %s', result)
11 if result == 0:
12 logger.info('Success in calling the given success_callback')
13@@ -720,7 +720,8 @@
14 def on_registration_success(self, app_name, email):
15 """Process the success of a registration."""
16 logger.debug('UbuntuSSOWizardController.on_registration_success')
17- result = yield self.registration_success_callback(app_name, email)
18+ result = yield self.registration_success_callback(str(app_name),
19+ str(email))
20 # TODO: what to do?
21 logger.debug('Result from callback is %s', result)
22 if result == 0:

Subscribers

People subscribed via source and target branches