Merge lp:~mandel/ubuntu-download-manager/support-data-uri into lp:ubuntu-download-manager

[Manuel de la Peña]

Add support for data uris.

Add support to data uri to download manager with out changing the client API/ABI. The idea is that a client can provide a data uri and the download manager will extract as much information as possible from it regarding the mime type etc.. and will write the data in the file system following the exact same security checks and supporting things such as the post processing of the files and its deflation.

[lp:~mandel/ubuntu-download-manager/support-data-uri]

336. By Manuel de la Peña on 2015-01-22

Remove no needed header added by the IDE. Remove some left over debug msgs.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:336
http://jenkins.qa.ubuntu.com/job/ubuntu-download-manager-ci/748/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-download-manager-vivid-amd64-ci/8
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-download-manager-vivid-armhf-ci/8
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-download-manager-vivid-armhf-ci/8/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-download-manager-ci/748/rebuild

review: Approve (continuous-integration)

[lp:~mandel/ubuntu-download-manager/support-data-uri]

337. By Manuel de la Peña on 2015-01-22

Deal with the case in which http is in the data uri.

338. By Manuel de la Peña on 2015-01-22

Ensure we use the entire path.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:337
http://jenkins.qa.ubuntu.com/job/ubuntu-download-manager-ci/749/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-download-manager-vivid-amd64-ci/9
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-download-manager-vivid-armhf-ci/9
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-download-manager-vivid-armhf-ci/9/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-download-manager-ci/749/rebuild

review: Approve (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:338
http://jenkins.qa.ubuntu.com/job/ubuntu-download-manager-ci/750/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-download-manager-vivid-amd64-ci/10
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-download-manager-vivid-armhf-ci/10
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-download-manager-vivid-armhf-ci/10/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-download-manager-ci/750/rebuild

review: Approve (continuous-integration)

[lp:~mandel/ubuntu-download-manager/support-data-uri]

339. By Manuel de la Peña on 2015-01-23

Remove log that brings not info.

340. By Manuel de la Peña on 2015-01-23

Add a comment stating the hack.

[Michael Sheldon (michael-sheldon)]

Looks good :)

review: Approve

=== modified file 'src/downloads/priv/ubuntu/downloads/file_download.cpp'
--- src/downloads/priv/ubuntu/downloads/file_download.cpp	2014-11-17 20:34:24 +0000
+++ src/downloads/priv/ubuntu/downloads/file_download.cpp	2015-01-23 11:59:29 +0000
@@ -16,20 +16,22 @@
  * Boston, MA 02110-1301, USA.
  */
 
+#include <map>
+
+#include <glog/logging.h>
+
+#include <QBuffer>
+#include <QCryptographicHash>
 #include <QDBusConnection>
 #include <QDBusMessage>
-#include <QBuffer>
-#include <QCryptographicHash>
 #include <QDir>
-#include <QStringList>
 #include <QFile>
 #include <QFileInfo>
+#include <QMimeDatabase>
+#include <QMimeType>
+#include <QStringList>
 #include <QSslError>
 
-#include <glog/logging.h>
-
-#include <map>
-
 #include <ubuntu/transfers/metadata.h>
 #include <ubuntu/transfers/system/dbus_connection.h>
 #include <ubuntu/transfers/system/hash_algorithm.h>
@@ -45,15 +47,6 @@
 
 #define DOWN_LOG(LEVEL) LOG(LEVEL) << ((parent() != nullptr)?"GroupDownload {" + parent()->objectName() + " } ":"") << "Download ID{" << objectName() << " } "
 
-namespace {
-    const QString PROPERTIES_INTERFACE = "org.freedesktop.DBus.Properties";
-    const QString DOWNLOAD_INTERFACE = "com.canonical.applications.Download";
-    const QString PROPERTIES_CHANGED = "PropertiesChanged";
-    const QString CLICK_PACKAGE_PROPERTY = "ClickPackage";
-    const QString SHOW_INDICATOR_PROPERTY = "ShowInIndicator";
-    const QString TITLE_PROPERTY = "Title";
-}
-
 std::ostream& operator<<(std::ostream &out, QNetworkReply::NetworkError err) {
     static std::map<QNetworkReply::NetworkError, std::string> errorsMap {
         {QNetworkReply::ConnectionRefusedError, "ConnectionRefusedError: the remote "
@@ -148,7 +141,12 @@
 }
 
 namespace {
-
+    const QString PROPERTIES_INTERFACE = "org.freedesktop.DBus.Properties";
+    const QString DOWNLOAD_INTERFACE = "com.canonical.applications.Download";
+    const QString PROPERTIES_CHANGED = "PropertiesChanged";
+    const QString CLICK_PACKAGE_PROPERTY = "ClickPackage";
+    const QString SHOW_INDICATOR_PROPERTY = "ShowInIndicator";
+    const QString TITLE_PROPERTY = "Title";
     const QString DATA_FILE_NAME = "data.download";
     const QString NETWORK_ERROR = "NETWORK ERROR";
     const QString HASH_ERROR = "HASH ERROR";
@@ -161,6 +159,7 @@
     const QString UNEXPECTED_ERROR = "UNEXPECTED_ERROR";
     const QByteArray CONTENT_DISPOSITION = "Content-Disposition";
     const QByteArray CONTENT_TYPE = "Content-Type";
+    const QString DATA_URI_PREFIX = "data:";
 }
 
 namespace Ubuntu {
@@ -245,31 +244,37 @@
 void
 FileDownload::pauseTransfer() {
     TRACE << _url;
-    if (_reply == nullptr) {
-        // cannot pause because is not running
-        DOWN_LOG(INFO) << "Cannot pause download because reply is NULL";
-        DOWN_LOG(INFO) << "EMIT paused(false)";
-        emit paused(false);
-        return;
-    }
-
-    DOWN_LOG(INFO) << "Pausing download" << _url;
-    // we need to disconnect the signals to ensure that they are not
-    // emitted due to the operation we are going to perform. We read
-    // the data in the reply and store it in a file
-    disconnectFromReplySignals();
-
-    // do abort before reading
-    _reply->abort();
-    _currentData->write(_reply->readAll());
-    if (!flushFile()) {
+    if (_url.toString().contains(DATA_URI_PREFIX)) {
+        DOWN_LOG(INFO) << "EMIT paused(false) since we are using a data uri";
+        _downloading = false;
         emit paused(false);
     } else {
-        _reply->deleteLater();
-        _reply = nullptr;
-        DOWN_LOG(INFO) << "EMIT paused(true)";
-        _downloading = false;
-        emit paused(true);
+        if (_reply == nullptr) {
+            // cannot pause because is not running
+            DOWN_LOG(INFO) << "Cannot pause download because reply is NULL";
+            DOWN_LOG(INFO) << "EMIT paused(false)";
+            emit paused(false);
+            return;
+        }
+
+        DOWN_LOG(INFO) << "Pausing download" << _url;
+        // we need to disconnect the signals to ensure that they are not
+        // emitted due to the operation we are going to perform. We read
+        // the data in the reply and store it in a file
+        disconnectFromReplySignals();
+
+        // do abort before reading
+        _reply->abort();
+        _currentData->write(_reply->readAll());
+        if (!flushFile()) {
+            emit paused(false);
+        } else {
+            _reply->deleteLater();
+            _reply = nullptr;
+            DOWN_LOG(INFO) << "EMIT paused(true)";
+            _downloading = false;
+            emit paused(true);
+        }
     }
 }
 
@@ -285,23 +290,32 @@
         return;
     }
 
-    DOWN_LOG(INFO) << "Resuming download.";
-    QNetworkRequest request = buildRequest();
-
-    // overrides the range header, we do not let clients set the range!!!
-    qint64 currentDataSize = _currentData->size();
-    QByteArray rangeHeaderValue = "bytes=" +
-        QByteArray::number(currentDataSize) + "-";
-    request.setRawHeader("Range", rangeHeaderValue);
-
-    _reply = _requestFactory->get(request);
-    _reply->setReadBufferSize(throttle());
-
-    connectToReplySignals();
-
-    DOWN_LOG(INFO) << "EMIT resumed(true)";
-    _downloading = true;
-    emit resumed(true);
+    // it is not very probable, yet possible that we do reach this point with a data uri
+
+    if (_url.toString().contains(DATA_URI_PREFIX)) {
+        DOWN_LOG(INFO) << "EMIT resumed(true)";
+        _downloading = true;
+        emit resumed(true);
+        writeDataUri();
+    } else {
+        DOWN_LOG(INFO) << "Resuming download.";
+        QNetworkRequest request = buildRequest();
+
+        // overrides the range header, we do not let clients set the range!!!
+        qint64 currentDataSize = _currentData->size();
+        QByteArray rangeHeaderValue = "bytes=" +
+                QByteArray::number(currentDataSize) + "-";
+        request.setRawHeader("Range", rangeHeaderValue);
+
+        _reply = _requestFactory->get(request);
+        _reply->setReadBufferSize(throttle());
+
+        connectToReplySignals();
+
+        DOWN_LOG(INFO) << "EMIT resumed(true)";
+        _downloading = true;
+        emit resumed(true);
+    }
 }
 
 void
@@ -326,16 +340,29 @@
         return;
     }
 
-    DOWN_LOG(INFO) << "Network is accessible, performing download request";
-    // signals should take care of calling deleteLater on the
-    // NetworkReply object
-    _reply = _requestFactory->get(buildRequest());
-    _reply->setReadBufferSize(throttle());
-
-    connectToReplySignals();
-    DOWN_LOG(INFO) << "EMIT started(true)";
-    _downloading = true;
-    emit started(true);
+    // make a diff between a data uri and a "normal" download
+    if (_url.toString().contains(DATA_URI_PREFIX)) {
+        DOWN_LOG(INFO) << "Performing a data uri download.";
+        // we emit the signals and then write the data in the file system, which will emit the download finished signal
+        // the signals are queued so they will happen in the correct order
+
+        DOWN_LOG(INFO) << "EMIT started(true)";
+        _downloading = true;
+        emit started(true);
+
+        writeDataUri();
+    } else {
+        DOWN_LOG(INFO) << "Performing a network download.";
+        // signals should take care of calling deleteLater on the
+        // NetworkReply object
+        _reply = _requestFactory->get(buildRequest());
+        _reply->setReadBufferSize(throttle());
+
+        connectToReplySignals();
+        DOWN_LOG(INFO) << "EMIT started(true)";
+        _downloading = true;
+        emit started(true);
+    }
 }
 
 qulonglong
@@ -472,7 +499,7 @@
     if (!flushFile()) {
         return;
     }
-    qulonglong received = _currentData->size();
+    auto received = static_cast<qulonglong>(_currentData->size());
 
     if (bytesTotal == -1) {
         // we do not know the size of the download, simply return
@@ -481,12 +508,11 @@
         return;
     } else {
         if (_totalSize == 0) {
-            qlonglong uBytestTotal = bytesTotal;
             // bytesTotal is different when we have resumed because we
             // are not counting the size that  we already downloaded,
             // therefore we only do this once
             // update the metadata
-            _totalSize = uBytestTotal;
+            _totalSize = static_cast<qulonglong>(bytesTotal);
         }
         emit Download::progress(received, _totalSize);
         return;
@@ -579,122 +605,10 @@
     // ensure that if content-disposition is present we will use it
     updateFileNamePerContentDisposition();
 
-    if(!hashIsValid()) {
-        emitError(HASH_ERROR);
-        return;
-    }
-
-    // if the download was set to be deflated and the content type is correct
-    // we will do our best to deflate the file
-    if (_metadata.contains(Metadata::DEFLATE_KEY)
-            && _metadata[Metadata::DEFLATE_KEY].toBool()
-            && _reply->hasRawHeader(CONTENT_TYPE)
-	    && HeaderParser::isDeflatableContentType(
-                _reply->rawHeader(CONTENT_TYPE))){
-    }
-
-
-    // there are three possible cases, in the first case we are requested 
-    // to extract the file, in which case we start a special helper process.
-    // In the second case we are requested to execute a specific command, in
-    // either of these two cases we only raise the finished signal once the
-    // processing is complete. Or in the third case we have no special requests
-    // and we indicate that the download is finished.
-    if (_metadata.contains(Metadata::EXTRACT_KEY)
-            && _metadata[Metadata::EXTRACT_KEY].toBool()
-            && _reply->hasRawHeader(CONTENT_TYPE)
-            && _reply->rawHeader(CONTENT_TYPE) == "application/zip") {
-
-        Process* postDownloadProcess =
-                ProcessFactory::instance()->createProcess();
-
-        CHECK(connect(postDownloadProcess, &Process::finished,
-                this, &FileDownload::onProcessFinished))
-                    << "Could not connect to signal";
-        CHECK(connect(postDownloadProcess, &Process::error,
-                this, &FileDownload::onProcessError))
-                    << "Could not connect to signal";
-
-        DOWN_LOG(INFO) << "Renaming '" << _tempFilePath << "'"
-            << "' to '" << _filePath << "'";
-
-        auto fileMan = FileManager::instance();
-        if (fileMan->exists(_tempFilePath)) {
-            LOG(INFO) << "Renaming: '" << _tempFilePath << "' to '"
-                << _filePath << "'";
-            fileMan->rename(_tempFilePath, _filePath);
-        }
-
-        QFileInfo fileInfo(filePath());
-
-        QString command = HELPER_DIR + QString(QDir::separator()) + "udm-extractor";
-        QStringList args;
-        args << "--unzip";
-        args << "--path";
-        args << filePath();
-        args << "--destination";
-        args << fileInfo.dir().absolutePath();
-
-        DOWN_LOG(INFO) << "Executing" << command << args;
-        postDownloadProcess->start(command, args);
-        return;
-    } else if (_metadata.contains(Metadata::COMMAND_KEY)) {
-        // just emit processing if we DO NOT have a hash because else we
-        // already emitted it.
-        if (_hash.isEmpty()) {
-            emit processing(filePath());
-        }
-        // toStringList will return an empty list if it cannot be converted
-        QStringList commandData =
-            _metadata[Metadata::COMMAND_KEY].toStringList();
-        if (commandData.count() == 0) {
-            DOWN_LOG(ERROR) << "COMMAND DATA MISSING";
-            emitError(COMMAND_ERROR);
-            return;
-        } else {
-            // first item of the string list is the command
-            // the rest is the arguments
-            DOWN_LOG(INFO) << "Renaming '" << _tempFilePath << "'"
-                << "' to '" << _filePath << "'";
-
-            auto fileMan = FileManager::instance();
-            if (fileMan->exists(_tempFilePath)) {
-                LOG(INFO) << "Renaming: '" << _tempFilePath << "' to '"
-                    << _filePath << "'";
-                fileMan->rename(_tempFilePath, _filePath);
-            }
-
-            QString command = commandData.at(0);
-            commandData.removeAt(0);
-            QStringList args;
-
-            foreach(const QString& arg, commandData) {
-                if (arg == Metadata::COMMAND_FILE_KEY)
-                    args << filePath();
-                else
-                    args << arg;
-            }
-
-            Process* postDownloadProcess =
-                ProcessFactory::instance()->createProcess();
-
-            // connect to signals so that we can tell the clients that
-            // the operation succeed
-
-            CHECK(connect(postDownloadProcess, &Process::finished,
-                this, &FileDownload::onProcessFinished))
-                    << "Could not connect to signal";
-            CHECK(connect(postDownloadProcess, &Process::error,
-                this, &FileDownload::onProcessError))
-                    << "Could not connect to signal";
-
-            DOWN_LOG(INFO) << "Executing" << command << args;
-            postDownloadProcess->start(command, args);
-            return;
-        }
-    } else {
-        emitFinished();
-    }
+    auto contentType = (_reply->hasRawHeader(CONTENT_TYPE))?
+            QString(_reply->rawHeader(CONTENT_TYPE)) : QString();
+
+    downloadPostProcessing(contentType);
 
     // clean the reply
     _reply->deleteLater();
@@ -702,6 +616,114 @@
 }
 
 void
+FileDownload::writeDataUri() {
+    // the expected format of the data is as follows:
+    //
+    // data:[<MIME-type>][;charset=<encoding>][;base64],<data>
+    //
+    // The encoding is indicated by ;base64. If it is present the data is encoded as base64. Without it the data
+    // (as a sequence of octets) is represented using ASCII encoding for octets inside the range of safe URL
+    // characters.  If <MIME-type> is omitted, it defaults to text/plain;charset=US-ASCII.
+    // An example uri is:
+    //
+    // data:image/gif;base64,R0lGODlhAQABAIAAAP///////yH5BAEKAAEALAAAAAABAAEAAAICTAEAOw==
+
+    // HACK:
+    // it can also be seen with the url prefixed as it happens in google images:
+    //
+    // http://images.google.com/data:image/gif;base64,R0lGODlhAQABAIAAAP///////yH5BAEKAAEALAAAAAABAAEAAAICTAEAOw==
+    //
+    // this is due to a bug found in oxide:  https://bugs.launchpad.net/oxide/+bug/1413964 and should be removed
+    // whenever asap
+    QString urlString = QString::null;
+    auto urlStringParts = _url.toString().split(DATA_URI_PREFIX);
+    if (urlStringParts.count() > 1) {
+        urlString = urlStringParts[1];
+    } else {
+        urlString = urlStringParts[0];
+    }
+
+    QByteArray data;
+    QMimeDatabase db;
+    QMimeType mimeType;  // init to an invalid type
+    QString extension = QString::null;
+    bool isBase64 = false;
+
+    foreach(const QMimeType& type, db.allMimeTypes()) {
+        // we need to check for each of the aliases that a mime type has
+        foreach(const QString& alias, type.aliases()) {
+            if (urlString.startsWith(alias)) {
+                DOWN_LOG(INFO) << "Data mime type is " << alias.toStdString();
+                mimeType = type;
+                urlString = urlString.replace(alias + ";", "");
+                break;
+            }
+        }
+
+        // we could have set the mime type and jumped outside the previous loop
+        if (mimeType.isValid()) {
+            break;
+        }
+    }
+    if (!mimeType.isValid()) {
+        LOG(INFO) << "MIME TYPE IS NOT VALID";
+        if (!urlString.startsWith(';')) {
+            DOWN_LOG(INFO) << "Database does not have type yet it is present.";
+            auto parts = urlString.split(';');
+            extension = parts[0].split('/')[1];
+            urlString = parts[1];
+        } else {
+            //defaults to text/plain;charset=US-ASCII.
+            mimeType = db.mimeTypeForData("text/plain");
+            urlString = urlString.split(';')[1];
+        }
+    }
+
+    if (urlString.startsWith("base64,")) {
+        DOWN_LOG(INFO) << "Data uri is base64 encoded";
+        isBase64 = true;
+        urlString = urlString.replace("base64,", "");
+    } else {
+        auto parts = urlString.split(',');
+        if (parts.count() != 2) {
+            DOWN_LOG(WARNING) << "Data uri malformed.";
+        } else {
+            urlString = parts[1];
+        }
+    }
+    // load the data from the string and write it in the file system, the uuid will be used as the
+    // file name + the mime type extension
+    if (isBase64) {
+        QByteArray encoded;
+        encoded.append(urlString);
+        data = QByteArray::fromBase64(encoded);
+    } else {
+        QByteArray encoded;
+        encoded.append(urlString);
+        data = QByteArray::fromPercentEncoding(encoded);
+    }
+
+    _totalSize = static_cast<qulonglong>(data.size());
+
+    // we need to update the file name using the mime type extension (the file name should be ok already), nevertheless
+    // we are going to write the data in the temp file so that the post processing of the download works correctky
+    QFileInfo fiFilePath(_filePath);
+    auto currentFileName = fiFilePath.fileName();
+    extension = (mimeType.isValid())?mimeType.suffixes()[0]:extension;
+    auto newPath = _filePath.replace(currentFileName, transferId() + "." + extension);
+
+    // unlock the old path and lock the new one
+    _fileNameMutex->unlockFileName(_filePath);
+    _filePath = _fileNameMutex->lockFileName(newPath);
+
+    DOWN_LOG(INFO) << "Data uri file path is '" << _filePath << "'";
+    _currentData->write(data);
+
+    // deal with the post processing of the created file
+    downloadPostProcessing(mimeType.aliases()[0]);
+}
+
+void
 FileDownload::onFinished() {
     TRACE << _url;
     // the reply has finished but the resource might have been moved
@@ -907,10 +929,10 @@
         // addData is smart enough to not load the entire file in memory
         hash->addData(_currentData->device());
         QString fileSig = QString(hash->result().toHex());
-	if (fileSig != _hash) {
+        if (fileSig != _hash) {
             DOWN_LOG(ERROR) << HASH_ERROR << fileSig << "!=" << _hash;
             return false;
-	}
+        }
     }
     return true;
 }
@@ -948,6 +970,115 @@
 }
 
 void
+FileDownload::downloadPostProcessing(const QString& contentType) {
+    TRACE << _url;
+
+    if(!hashIsValid()) {
+        emitError(HASH_ERROR);
+        return;
+    }
+
+    // there are three possible cases, in the first case we are requested
+    // to extract the file, in which case we start a special helper process.
+    // In the second case we are requested to execute a specific command, in
+    // either of these two cases we only raise the finished signal once the
+    // processing is complete. Or in the third case we have no special requests
+    // and we indicate that the download is finished.
+    if (_metadata.contains(Metadata::EXTRACT_KEY)
+            && _metadata[Metadata::EXTRACT_KEY].toBool()
+            && contentType == "application/zip") {
+
+        auto postDownloadProcess = ProcessFactory::instance()->createProcess();
+
+        CHECK(connect(postDownloadProcess, &Process::finished,
+                this, &FileDownload::onProcessFinished))
+                << "Could not connect to signal";
+        CHECK(connect(postDownloadProcess, &Process::error,
+                this, &FileDownload::onProcessError))
+                << "Could not connect to signal";
+
+        DOWN_LOG(INFO) << "Renaming '" << _tempFilePath << "'"
+                << "' to '" << _filePath << "'";
+
+        auto fileMan = FileManager::instance();
+        if (fileMan->exists(_tempFilePath)) {
+            LOG(INFO) << "Renaming: '" << _tempFilePath << "' to '"
+                    << _filePath << "'";
+            fileMan->rename(_tempFilePath, _filePath);
+        }
+
+        QFileInfo fileInfo(filePath());
+
+        QString command = HELPER_DIR + QString(QDir::separator()) + "udm-extractor";
+        QStringList args;
+        args << "--unzip";
+        args << "--path";
+        args << filePath();
+        args << "--destination";
+        args << fileInfo.dir().absolutePath();
+
+        DOWN_LOG(INFO) << "Executing" << command << args;
+        postDownloadProcess->start(command, args);
+        return;
+    } else if (_metadata.contains(Metadata::COMMAND_KEY)) {
+        // just emit processing if we DO NOT have a hash because else we
+        // already emitted it.
+        if (_hash.isEmpty()) {
+            emit processing(filePath());
+        }
+        // toStringList will return an empty list if it cannot be converted
+        QStringList commandData =
+                _metadata[Metadata::COMMAND_KEY].toStringList();
+        if (commandData.count() == 0) {
+            DOWN_LOG(ERROR) << "COMMAND DATA MISSING";
+            emitError(COMMAND_ERROR);
+            return;
+        } else {
+            // first item of the string list is the command
+            // the rest is the arguments
+            DOWN_LOG(INFO) << "Renaming '" << _tempFilePath << "'"
+                    << "' to '" << _filePath << "'";
+
+            auto fileMan = FileManager::instance();
+            if (fileMan->exists(_tempFilePath)) {
+                LOG(INFO) << "Renaming: '" << _tempFilePath << "' to '"
+                        << _filePath << "'";
+                fileMan->rename(_tempFilePath, _filePath);
+            }
+
+            QString command = commandData.at(0);
+            commandData.removeAt(0);
+            QStringList args;
+
+            foreach(const QString& arg, commandData) {
+                if (arg == Metadata::COMMAND_FILE_KEY)
+                    args << filePath();
+                else
+                    args << arg;
+            }
+
+            auto postDownloadProcess = ProcessFactory::instance()->createProcess();
+
+            // connect to signals so that we can tell the clients that
+            // the operation succeed
+
+            CHECK(connect(postDownloadProcess, &Process::finished,
+                    this, &FileDownload::onProcessFinished))
+                    << "Could not connect to signal";
+            CHECK(connect(postDownloadProcess, &Process::error,
+                    this, &FileDownload::onProcessError))
+                    << "Could not connect to signal";
+
+            DOWN_LOG(INFO) << "Executing" << command << args;
+            postDownloadProcess->start(command, args);
+            return;
+        }
+    } else {
+        emitFinished();
+    }
+}
+
+void
 FileDownload::emitFinished() {
     auto fileMan = FileManager::instance();
 

=== modified file 'src/downloads/priv/ubuntu/downloads/file_download.h'
--- src/downloads/priv/ubuntu/downloads/file_download.h	2014-10-22 23:40:53 +0000
+++ src/downloads/priv/ubuntu/downloads/file_download.h	2015-01-23 11:59:29 +0000
@@ -16,8 +16,7 @@
  * Boston, MA 02110-1301, USA.
  */
 
-#ifndef DOWNLOADER_LIB_SINGLE_DOWNLOAD_H
-#define DOWNLOADER_LIB_SINGLE_DOWNLOAD_H
+#pragma once
 
 #include <QDBusContext>
 #include <QFile>
@@ -123,8 +122,10 @@
     bool hashIsValid();
     void init();
     void initFileNames();
+    void downloadPostProcessing(const QString& contentType);
     void unlockFilePath();
     void updateFileNamePerContentDisposition();
+    void writeDataUri();
 
     // slots used to react to signals
     void onDownloadProgress(qint64 currentProgress, qint64);
@@ -161,5 +162,3 @@
 }  // DownloadManager
 
 }  // Ubuntu
-
-#endif  // DOWNLOADER_LIB_SINGLE_DOWNLOAD_H

=== modified file 'tests/downloads/daemon/CMakeLists.txt'
--- tests/downloads/daemon/CMakeLists.txt	2014-12-01 09:20:00 +0000
+++ tests/downloads/daemon/CMakeLists.txt	2015-01-23 11:59:29 +0000
@@ -15,26 +15,26 @@
 # Authored by: Manuel de la Peña <[e-mail]>
 
 set(DAEMON_TESTS
-	test_apn_request_factory
-	test_apparmor
+        test_apn_request_factory
+        test_apparmor
         test_base_download
-	test_cancel_download_transition
+        test_cancel_download_transition
         test_daemon
-	test_download
+        test_download
         test_download_factory
-	test_download_manager
-	test_downloads_db
-	test_file_download_sm
-	test_filename_mutex
-	test_final_state
+        test_download_manager
+        test_downloads_db
+        test_file_download_sm
+        test_filename_mutex
+        test_final_state
         test_group_download
         test_metadata
-	test_mms_download
-	test_network_error_transition
-	test_resume_download_transition
-	test_ssl_error_transition
-	test_start_download_transition
-	test_stop_request_transition
+        test_mms_download
+        test_network_error_transition
+        test_resume_download_transition
+        test_ssl_error_transition
+        test_start_download_transition
+        test_stop_request_transition
         test_transfers_queue
 )
 
@@ -47,14 +47,14 @@
         set(${test}_DAEMON_HEADERS
                 application.h
                 cryptographic_hash.h
-		database.h
-		dbus_proxy.h
-		dbus_proxy_factory.h
-		download.h
+                database.h
+                dbus_proxy.h
+                dbus_proxy_factory.h
+                download.h
                 factory.h
                 filename_mutex.h
-		manager.h
-		pending_reply.h
+                manager.h
+                pending_reply.h
                 queue.h
                 sm_file_download.h
                 timer.h
@@ -86,18 +86,18 @@
 link_directories(${GLOG_DBUS_LIBDIR})
 
 set(DAEMON_TESTS_LIBS
-	${NIH_DBUS_LIBRARIES}
-	${GLOG_LIBRARIES}
+        ${NIH_DBUS_LIBRARIES}
+        ${GLOG_LIBRARIES}
         ${Qt5Core_LIBRARIES}
         ${Qt5Sql_LIBRARIES}
         ${Qt5DBus_LIBRARIES}
-	${Qt5Test_LIBRARIES}
+        ${Qt5Test_LIBRARIES}
         ${GMOCK_LIBRARY}
         ${GTEST_BOTH_LIBRARIES}
-	udm-common
-	udm-priv-common
-	ubuntu-download-manager-common
-	ubuntu-download-manager-priv
+        udm-common
+        udm-priv-common
+        ubuntu-download-manager-common
+        ubuntu-download-manager-priv
         ubuntu-download-manager-test-lib
 )
 

=== modified file 'tests/downloads/daemon/test_download.cpp'
--- tests/downloads/daemon/test_download.cpp	2014-11-17 20:34:24 +0000
+++ tests/downloads/daemon/test_download.cpp	2015-01-23 11:59:29 +0000
@@ -1262,7 +1262,8 @@
         .WillOnce(Return(QVariant(200)));
 
     EXPECT_CALL(*reply.data(), hasRawHeader(_))
-        .Times(1)
+        .Times(2)
+        .WillOnce(Return(false))
         .WillOnce(Return(false));
 
     // file system expectations
@@ -1331,7 +1332,8 @@
         .WillOnce(Return(QVariant(200)));
 
     EXPECT_CALL(*reply.data(), hasRawHeader(_))
-        .Times(1)
+        .Times(2)
+        .WillOnce(Return(false))
         .WillOnce(Return(false));
 
     // file system expectations
@@ -1421,7 +1423,8 @@
         .WillOnce(Return(QVariant(200)));
 
     EXPECT_CALL(*reply.data(), hasRawHeader(_))
-        .Times(1)
+        .Times(2)
+        .WillOnce(Return(false))
         .WillOnce(Return(false));
 
     // file system expectations
@@ -2143,7 +2146,8 @@
         .WillOnce(Return(QVariant(200)));
 
     EXPECT_CALL(*reply, hasRawHeader(_))
-        .Times(1)
+        .Times(2)
+        .WillOnce(Return(false))
         .WillOnce(Return(false));
 
     // file system expectations
@@ -2196,6 +2200,7 @@
     QVERIFY(Mock::VerifyAndClearExpectations(reply));
     QVERIFY(Mock::VerifyAndClearExpectations(process.data()));
     verifyMocks();
+    delete reply;
 }
 
 void
@@ -2254,7 +2259,8 @@
         .WillOnce(Return(QVariant(200)));
 
     EXPECT_CALL(*reply, hasRawHeader(_))
-        .Times(1)
+        .Times(2)
+        .WillOnce(Return(false))
         .WillOnce(Return(false));
 
     // file system expectations
@@ -2307,6 +2313,8 @@
     QVERIFY(Mock::VerifyAndClearExpectations(reply));
     QVERIFY(Mock::VerifyAndClearExpectations(process.data()));
     verifyMocks();
+
+    delete reply;
 }
 
 void
@@ -2365,7 +2373,8 @@
         .WillOnce(Return(QVariant(200)));
 
     EXPECT_CALL(*reply, hasRawHeader(_))
-        .Times(1)
+        .Times(2)
+        .WillOnce(Return(false))
         .WillOnce(Return(false));
 
     // file system expectations
@@ -2426,6 +2435,8 @@
     QVERIFY(Mock::VerifyAndClearExpectations(reply));
     QVERIFY(Mock::VerifyAndClearExpectations(process.data()));
     verifyMocks();
+
+    delete reply;
 }
 
 void
@@ -2458,7 +2469,8 @@
         .WillOnce(Return(QVariant(200)));
 
     EXPECT_CALL(*reply.data(), hasRawHeader(_))
-        .Times(1)
+        .Times(2)
+        .WillOnce(Return(false))
         .WillOnce(Return(false));
 
     // file system expectations
@@ -2572,7 +2584,8 @@
         .WillOnce(Return(QVariant(200)));
 
     EXPECT_CALL(*reply.data(), hasRawHeader(_))
-        .Times(1)
+        .Times(2)
+        .WillOnce(Return(false))
         .WillOnce(Return(false));
 
     // file system expectations
@@ -2677,7 +2690,8 @@
         .WillOnce(Return(QVariant(200)));
 
     EXPECT_CALL(*reply.data(), hasRawHeader(_))
-        .Times(1)
+        .Times(2)
+        .WillOnce(Return(false))
         .WillOnce(Return(false));
 
     // file system expectations
@@ -3169,7 +3183,8 @@
         .WillOnce(Return(QVariant(200)));
 
     EXPECT_CALL(*reply, hasRawHeader(_))
-        .Times(1)
+        .Times(2)
+        .WillOnce(Return(false))
         .WillOnce(Return(false));
 
     // file system expectations
@@ -3234,6 +3249,8 @@
     QVERIFY(Mock::VerifyAndClearExpectations(file));
     QVERIFY(Mock::VerifyAndClearExpectations(reply));
     verifyMocks();
+
+    delete reply;
 }
 
 void
@@ -3508,7 +3525,8 @@
         .WillOnce(Return(QVariant()));
 
     EXPECT_CALL(*secondReply.data(), hasRawHeader(_))
-        .Times(1)
+        .Times(2)
+        .WillOnce(Return(false))
         .WillOnce(Return(false));
 
     // file system expectations
@@ -3667,7 +3685,8 @@
         .WillOnce(Return(QVariant(200)));
 
     EXPECT_CALL(*reply, hasRawHeader(_))
-        .Times(1)
+        .Times(2)
+        .WillOnce(Return(false))
         .WillOnce(Return(false));
 
     // file system expectations
@@ -3722,6 +3741,8 @@
     QVERIFY(Mock::VerifyAndClearExpectations(mutex));
     verifyMocks();
     FileNameMutex::deleteInstance();
+
+    delete reply;
 }
 
 void
@@ -3930,4 +3951,225 @@
     verifyMocks();
 }
 
+void
+TestDownload::testDataUriIsValid() {
+    EXPECT_CALL(*_networkSession, isOnline())
+            .WillRepeatedly(Return(true));
+
+    QUrl url("data:image/gif;base64,R0lGODlhAQABAIAAAP///////yH5BAEKAAEALAAAAAABAAEAAAICTAEAOw==");
+    QScopedPointer<FileDownload> download(new FileDownload(_id, _appId, _path,
+            _isConfined, _rootPath, url, _metadata, _headers));
+
+    QVERIFY(download->isValid());
+    verifyMocks();
+}
+
+void
+TestDownload::testDataUriIsValidWithHttpPrefix() {
+    // perform the download and assert that the mime extension used is txt
+    auto file = new MockFile("test");
+    EXPECT_CALL(*_networkSession, isOnline())
+            .WillRepeatedly(Return(true));
+
+    QUrl url("http://images.google.com/data:;base64,R0lGODlhAQABAIAAAP///////yH5BAEKAAEALAAAAAABAAEAAAICTAEAOw==");
+    QScopedPointer<FileDownload> download(new FileDownload(_id, _appId, _path,
+            _isConfined, _rootPath, url, _metadata, _headers));
+
+    QVERIFY(download->isValid());
+
+    // file system expectations
+    EXPECT_CALL(*_fileManager, createFile(_))
+            .Times(1)
+            .WillOnce(Return(file));
+
+    EXPECT_CALL(*file, open(QIODevice::ReadWrite | QFile::Append))
+            .Times(1)
+            .WillOnce(Return(true));
+
+    EXPECT_CALL(*file, write(_))
+            .Times(1)
+            .WillOnce(Return(0));
+
+    EXPECT_CALL(*file, close())
+            .Times(1);
+
+    download->startTransfer();
+    QVERIFY(download->filePath().endsWith("txt"));
+}
+
+void
+TestDownload::testDataUriMissingMimeType() {
+    // perform the download and assert that the mime extension used is txt
+    auto file = new MockFile("test");
+    EXPECT_CALL(*_networkSession, isOnline())
+            .WillRepeatedly(Return(true));
+
+    QUrl url("data:;base64,R0lGODlhAQABAIAAAP///////yH5BAEKAAEALAAAAAABAAEAAAICTAEAOw==");
+    QScopedPointer<FileDownload> download(new FileDownload(_id, _appId, _path,
+            _isConfined, _rootPath, url, _metadata, _headers));
+
+    QVERIFY(download->isValid());
+
+    // file system expectations
+    EXPECT_CALL(*_fileManager, createFile(_))
+            .Times(1)
+            .WillOnce(Return(file));
+
+    EXPECT_CALL(*file, open(QIODevice::ReadWrite | QFile::Append))
+            .Times(1)
+            .WillOnce(Return(true));
+
+    EXPECT_CALL(*file, write(_))
+            .Times(1)
+            .WillOnce(Return(0));
+
+    EXPECT_CALL(*file, close())
+            .Times(1);
+
+    download->startTransfer();
+    QVERIFY(download->filePath().endsWith("txt"));
+}
+
+void
+TestDownload::testDataUriMimeType_data() {
+    QTest::addColumn<QString>("mime");
+    QTest::addColumn<QString>("extension");
+
+    QTest::newRow("Image gif") << "image/gif" << "gif";
+    QTest::newRow("Image ief") << "image/ief" << "ief";
+    QTest::newRow("Image jpg") << "image/jpeg" << "jpeg";
+    QTest::newRow("Image tiff") << "image/tiff" << "tiff";
+    QTest::newRow("Image rgb") << "image/x-rgb" << "rgb";
+    QTest::newRow("Image bitmap") << "image/x-xbitmap" << "x-xbitmap";
+    QTest::newRow("View MPG") << "video/mpeg" << "mpeg";
+
+}
+
+void
+TestDownload::testDataUriMimeType() {
+    QFETCH(QString, mime);
+    QFETCH(QString, extension);
+    auto file = new MockFile("test");
+    EXPECT_CALL(*_networkSession, isOnline())
+            .WillRepeatedly(Return(true));
+
+    QUrl url("data:" + mime + ";base64,R0lGODlhAQABAIAAAP///////yH5BAEKAAEALAAAAAABAAEAAAICTAEAOw==");
+    QScopedPointer<FileDownload> download(new FileDownload(_id, _appId, _path,
+            _isConfined, _rootPath, url, _metadata, _headers));
+
+    QVERIFY(download->isValid());
+
+    // file system expectations
+    EXPECT_CALL(*_fileManager, createFile(_))
+            .Times(1)
+            .WillOnce(Return(file));
+
+    EXPECT_CALL(*file, open(QIODevice::ReadWrite | QFile::Append))
+            .Times(1)
+            .WillOnce(Return(true));
+
+    EXPECT_CALL(*file, write(_))
+            .Times(1)
+            .WillOnce(Return(0));
+
+    EXPECT_CALL(*file, close())
+            .Times(1);
+
+    download->startTransfer();
+    QVERIFY(download->filePath().endsWith(extension));
+}
+
+void
+TestDownload::testDataUriPostProcessing_data() {
+    QTest::addColumn<QString>("command");
+    QTest::addColumn<QVariantMap>("metadata");
+    QVariantMap first, second, third;
+    QStringList firstCommand, secondCommand, thirdCommand;
+
+    firstCommand << "touch";
+    first["post-download-command"] = firstCommand;
+
+    QTest::newRow("First row") << firstCommand[0] << first;
+
+    secondCommand << "sudo";
+    second["post-download-command"] = secondCommand;
+
+    QTest::newRow("Second row") << secondCommand[0] << second;
+
+    thirdCommand << "grep";
+    third["post-download-command"] = thirdCommand;
+
+    QTest::newRow("Third row") << thirdCommand[0] << third;
+}
+
+void
+TestDownload::testDataUriPostProcessing() {
+    QFETCH(QString, command);
+    QFETCH(QVariantMap, metadata);
+    QStringList args;  // not args
+
+    QUrl url("data:image/gif;base64,R0lGODlhAQABAIAAAP///////yH5BAEKAAEALAAAAAABAAEAAAICTAEAOw==");
+    QScopedPointer<MockFile> file(new MockFile("test"));
+    QScopedPointer<MockProcess> process(new MockProcess());
+
+    // write the expectations of the reply which is what we are
+    // really testing
+
+    EXPECT_CALL(*_networkSession, isOnline())
+            .WillRepeatedly(Return(true));
+
+    // file system expectations
+    EXPECT_CALL(*_fileManager, createFile(_))
+            .Times(1)
+            .WillOnce(Return(file.data()));
+
+    EXPECT_CALL(*file.data(), open(QIODevice::ReadWrite | QFile::Append))
+            .Times(1)
+            .WillOnce(Return(true));
+
+    EXPECT_CALL(*file, write(_))
+            .Times(1)
+            .WillOnce(Return(0));
+
+    EXPECT_CALL(*file.data(), remove())
+            .Times(1)
+            .WillOnce(Return(true));
+
+    EXPECT_CALL(*_cryptoFactory, createCryptographicHash(_, _))
+            .Times(0);
+
+    // process factory and process expectation
+    EXPECT_CALL(*_processFactory, createProcess())
+            .Times(1)
+            .WillOnce(Return(process.data()));
+
+    EXPECT_CALL(*process.data(), start(command, StringListEq(args), _))
+            .Times(1);
+
+    auto download = new FileDownload(_id, _appId, _path,
+            _isConfined, _rootPath, url, metadata, _headers);
+
+    SignalBarrier spy(download, SIGNAL(finished(QString)));
+    SignalBarrier startedSpy(download, SIGNAL(started(bool)));
+    SignalBarrier processingSpy(download, SIGNAL(processing(QString)));
+
+    download->start();  // change state
+    download->startTransfer();
+
+    QVERIFY(startedSpy.ensureSignalEmitted());
+
+    // emit the finish signal and expect it to be raised
+    emit process->finished(0, QProcess::NormalExit);
+
+    QTRY_COMPARE_WITH_TIMEOUT(spy.count(), 1, 20000);
+    QTRY_COMPARE_WITH_TIMEOUT(processingSpy.count(), 1, 20000);
+    QCOMPARE(download->state(), Download::FINISH);
+
+    delete download;
+
+    QVERIFY(Mock::VerifyAndClearExpectations(file.data()));
+    QVERIFY(Mock::VerifyAndClearExpectations(process.data()));
+    verifyMocks();
+}
+
 QTEST_MAIN(TestDownload)

=== modified file 'tests/downloads/daemon/test_download.h'
--- tests/downloads/daemon/test_download.h	2014-11-17 20:34:24 +0000
+++ tests/downloads/daemon/test_download.h	2015-01-23 11:59:29 +0000
@@ -186,6 +186,15 @@
     void testDeflateConstructorNoError();
     void testDeflateOnRequest();
 
+    // void data uri tests
+    void testDataUriIsValid();
+    void testDataUriIsValidWithHttpPrefix();
+    void testDataUriMissingMimeType();
+    void testDataUriMimeType_data();
+    void testDataUriMimeType();
+    void testDataUriPostProcessing_data();
+    void testDataUriPostProcessing();
+
  private:
     QString _id;
     QString _appId;