lp:~mandel/ubuntu-download-manager/remove-network-reply-pimpl

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:ubuntu-download-manager at revision 195

PS Jenkins bot: Approve (continuous-integration) on 2013-12-02

Manuel de la Peña (community): Approve on 2013-11-25

Diego Sarmentero (community): Approve on 2013-11-20

Diff: 392 lines (+57/-252)

5 files modified

libubuntudownloadmanager/system/network_reply.cpp (+52/-98)
libubuntudownloadmanager/system/network_reply.h (+5/-5)
ubuntu-download-manager-tests/system/test_network_reply.cpp (+0/-93)
ubuntu-download-manager-tests/system/test_network_reply.h (+0/-54)
ubuntu-download-manager-tests/ubuntu-download-manager-tests.pro (+0/-2)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1250990: NetworkReply uses the pimpl patter when it is not needed

Medium

Fix Released

Link a bug report

Related blueprints

177. By Manuel de la Peña on 2013-12-02

Remove the need of the tests because the signal connection checks are done at compile time thx to the new connection style.

176. By Manuel de la Peña on 2013-11-21

Use try compare to make sure the CI has no problems with the signal spies and merge with trunk.

175. By Manuel de la Peña on 2013-11-21

Merged with trunk.

174. By Manuel de la Peña on 2013-11-18

Merged with trunk.

173. By Manuel de la Peña on 2013-11-14

Use the new connect style.

172. By Manuel de la Peña on 2013-11-13

Remove pimpl from the network reply object.

171. By Mike McCracken on 2013-11-08

- change command for 'make check' to work when not in tree (LP: #1249470). Fixes: https://bugs.launchpad.net/bugs/1249470.

Approved by PS Jenkins bot, Alejandro J. Cura.

170. By Manuel de la Peña on 2013-11-08

Provide setters and getters for the daemon command line args. Added self signed ssl certs for testing purposes. Fixes: https://bugs.launchpad.net/bugs/1249336.

Approved by Roberto Alsina, PS Jenkins bot, Diego Sarmentero.

169. By Manuel de la Peña on 2013-11-08

Provide a processing signal for when the downloading is done and a process is being executed. Fixes: https://bugs.launchpad.net/bugs/1248770.

Approved by Alejandro J. Cura, PS Jenkins bot, Roberto Alsina, Diego Sarmentero.

168. By Manuel de la Peña on 2013-11-08

Create the download state machine and add the states defined in the docs diagram.

Approved by Mike McCracken, PS Jenkins bot, Diego Sarmentero.