lp:~mandel/ubuntu-download-manager/remove-dbusconn-pimpl

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:ubuntu-download-manager at revision 175

PS Jenkins bot: Approve (continuous-integration) on 2013-11-16

Diego Sarmentero (community): Approve on 2013-11-14

Diff: 116 lines (+10/-59)

2 files modified

libubuntudownloadmanager/system/dbus_connection.cpp (+9/-56)
libubuntudownloadmanager/system/dbus_connection.h (+1/-3)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1251008: DBusConnection class uses the pimpl pattern when not needed

Medium

Fix Released

Link a bug report

Related blueprints

172. By Manuel de la Peña on 2013-11-13

Remove not needed pimpl pattern.

171. By Mike McCracken on 2013-11-08

- change command for 'make check' to work when not in tree (LP: #1249470). Fixes: https://bugs.launchpad.net/bugs/1249470.

Approved by PS Jenkins bot, Alejandro J. Cura.

170. By Manuel de la Peña on 2013-11-08

Provide setters and getters for the daemon command line args. Added self signed ssl certs for testing purposes. Fixes: https://bugs.launchpad.net/bugs/1249336.

Approved by Roberto Alsina, PS Jenkins bot, Diego Sarmentero.

169. By Manuel de la Peña on 2013-11-08

Provide a processing signal for when the downloading is done and a process is being executed. Fixes: https://bugs.launchpad.net/bugs/1248770.

Approved by Alejandro J. Cura, PS Jenkins bot, Roberto Alsina, Diego Sarmentero.

168. By Manuel de la Peña on 2013-11-08

Create the download state machine and add the states defined in the docs diagram.

Approved by Mike McCracken, PS Jenkins bot, Diego Sarmentero.

167. By Manuel de la Peña on 2013-11-08

Allow to pass the path of the service to be started so that it is easier to test. Fixes: https://bugs.launchpad.net/bugs/1195657.

Approved by Diego Sarmentero, PS Jenkins bot.

166. By Manuel de la Peña on 2013-11-06

Ensure that finished is raised when the group download is empty. Fixes: https://bugs.launchpad.net/bugs/1245597.

Approved by PS Jenkins bot, Diego Sarmentero.

165. By Manuel de la Peña on 2013-10-31

Add documentation about the state machine to be used for the downloads and its initial skeleton.

Approved by PS Jenkins bot, Mike McCracken, Diego Sarmentero.

164. By Manuel de la Peña on 2013-10-30

Sort the files under the test project so that working on it is simpler.

Approved by PS Jenkins bot, Diego Sarmentero.

163. By Manuel de la Peña on 2013-10-29

Add the use of a new namespace for system realted classes.

Approved by Diego Sarmentero, PS Jenkins bot.