Merge lp:~mandel/ubuntu-download-manager/remove-db-pimpl into lp:ubuntu-download-manager
Proposed by
Manuel de la Peña
Status: | Merged |
---|---|
Approved by: | Manuel de la Peña |
Approved revision: | 197 |
Merged at revision: | 196 |
Proposed branch: | lp:~mandel/ubuntu-download-manager/remove-db-pimpl |
Merge into: | lp:ubuntu-download-manager |
Diff against target: |
432 lines (+170/-207) 2 files modified
libubuntudownloadmanager/downloads/downloads_db.cpp (+160/-203) libubuntudownloadmanager/downloads/downloads_db.h (+10/-4) |
To merge this branch: | bzr merge lp:~mandel/ubuntu-download-manager/remove-db-pimpl |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michał Karnicki (community) | Approve | ||
PS Jenkins bot | continuous-integration | Approve | |
Review via email: mp+197041@code.launchpad.net |
Commit message
Remove the pimpl pattern from the DownloadsDb because that class will never be exposed to other projects.
Description of the change
Remove the pimpl pattern from the DownloadsDb because that class will never be exposed to other projects.
To post a comment you must log in.
PASSED: Continuous integration, rev:196 jenkins. qa.ubuntu. com/job/ ubuntu- download- manager- ci/249/ jenkins. qa.ubuntu. com/job/ ubuntu- download- manager- trusty- amd64-ci/ 138 jenkins. qa.ubuntu. com/job/ ubuntu- download- manager- trusty- armhf-ci/ 138
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/ubuntu- download- manager- ci/249/ rebuild
http://