Merge lp:~mandel/ubuntu-download-manager/install-correct-path into lp:ubuntu-download-manager

[Manuel de la Peña]

This fix ensures that the temp file is renamed to the final file before the post-command is executed.

This fix ensures that the temp file is renamed to the final file before the post-command is executed. Please do follow the full test plan of udm (https://wiki.ubuntu.com/Process/Merges/TestPlan/ubuntu-download-manager) with special care related to the click scope tests. If you can please follow the test plan for the click scope too (https://wiki.ubuntu.com/Process/Merges/TestPlan/unity-scope-click)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:249
http://jenkins.qa.ubuntu.com/job/ubuntu-download-manager-ci/361/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-download-manager-trusty-amd64-ci/250
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-download-manager-trusty-armhf-ci/250

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-download-manager-ci/361/rebuild

review: Approve (continuous-integration)

=== modified file 'ubuntu-download-manager-priv/downloads/file_download.cpp'
--- ubuntu-download-manager-priv/downloads/file_download.cpp	2014-02-22 10:41:59 +0000
+++ ubuntu-download-manager-priv/downloads/file_download.cpp	2014-03-01 15:50:30 +0000
@@ -389,6 +389,16 @@
         } else {
             // first item of the string list is the command
             // the rest is the arguments
+            DOWN_LOG(INFO) << "Renaming '" << _tempFilePath << "'"
+                << "' to '" << _filePath << "'";
+
+            auto fileMan = FileManager::instance();
+            if (fileMan->exists(_tempFilePath)) {
+                LOG(INFO) << "Renaming: '" << _tempFilePath << "' to '"
+                    << _filePath << "'";
+                fileMan->rename(_tempFilePath, _filePath);
+            }
+
             QString command = commandData.at(0);
             commandData.removeAt(0);
             QStringList args;

=== modified file 'ubuntu-download-manager-tests/downloads/test_download.cpp'
--- ubuntu-download-manager-tests/downloads/test_download.cpp	2014-02-19 19:01:37 +0000
+++ ubuntu-download-manager-tests/downloads/test_download.cpp	2014-03-01 15:50:30 +0000
@@ -1459,6 +1459,8 @@
     QStringList processArgs = listWrapper->value();
     QCOMPARE(processCommand, command);
     QVERIFY(processArgs.contains(download->filePath()));
+    QVERIFY(QFile::exists(download->filePath()));
+    QVERIFY(!QFile::exists(download->filePath() + ".tmp"));
     QCOMPARE(processingSpy.count(), 1);
 }