Merge lp:~mandel/ubuntu-download-manager/execute-post-download into lp:ubuntu-download-manager

[Manuel de la Peña]

Allow process execution after download.
Fix broken tests.

Allow process execution after download.
Fix broken tests.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:75
http://jenkins.qa.ubuntu.com/job/ubuntu-download-manager-ci/6/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-download-manager-saucy-amd64-ci/6
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-download-manager-saucy-armfh-ci/6/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-download-manager-ci/6/rebuild

review: Needs Fixing (continuous-integration)

[Alejandro J. Cura (alecu)]

+1

review: Approve

[Manuel de la Peña (mandel)]

review: Approve

=== modified file 'libubuntudownloadmanager/download.cpp'
--- libubuntudownloadmanager/download.cpp	2013-07-20 18:26:02 +0000
+++ libubuntudownloadmanager/download.cpp	2013-07-21 19:10:31 +0000
@@ -41,6 +41,8 @@
 #define ALGO "algo"
 #define DATA_FILE_NAME "data"
 #define METADATA_FILE_NAME "metadata"
+#define METADATA_COMMAND_KEY "post-download-command"
+#define METADATA_COMMAND_FILE_KEY "$file"
 
 
 /**
@@ -52,10 +54,11 @@
     Q_DECLARE_PUBLIC(Download)
 public:
     explicit DownloadPrivate(const QUuid& id, const QString& path, const QUrl& url, const QVariantMap& metadata,
-        const QMap<QString, QString>& headers, SystemNetworkInfo* networkInfo, RequestFactory* nam, Download* parent);
+        const QMap<QString, QString>& headers, SystemNetworkInfo* networkInfo, RequestFactory* nam, ProcessFactory* processFactory,
+        Download* parent);
     explicit DownloadPrivate(const QUuid& id, const QString& path, const QUrl& url, const QString& hash,
         QCryptographicHash::Algorithm algo, const QVariantMap& metadata, const QMap<QString, QString>& headers,
-        SystemNetworkInfo* networkInfo, RequestFactory* nam,
+        SystemNetworkInfo* networkInfo, RequestFactory* nam, ProcessFactory* processFactory,
         Download* parent);
     ~DownloadPrivate();
 
@@ -97,6 +100,10 @@
     void onFinished();
     void onSslErrors(const QList<QSslError>& errors);
 
+    // slots executed to keep track of the post download process
+    void onProcessError(QProcess::ProcessError error);
+    void onProcessFinished(int exitCode, QProcess::ExitStatus exitStatus);
+
 private:
     void init();
     void connectToReplySignals();
@@ -123,6 +130,7 @@
     QMap<QString, QString> _headers;
     SystemNetworkInfo* _networkInfo;
     RequestFactory* _requestFactory;
+    ProcessFactory* _processFactory;
     NetworkReply* _reply;
     QFile* _currentData;
     Download* q_ptr;
@@ -130,7 +138,8 @@
 };
 
 DownloadPrivate::DownloadPrivate(const QUuid& id, const QString& path, const QUrl& url, const QVariantMap& metadata,
-    const QMap<QString, QString>& headers, SystemNetworkInfo* networkInfo, RequestFactory* nam, Download* parent):
+    const QMap<QString, QString>& headers, SystemNetworkInfo* networkInfo, RequestFactory* nam, ProcessFactory* processFactory,
+    Download* parent):
         _id(id),
         _totalSize(0),
         _throttle(0),
@@ -144,6 +153,7 @@
         _headers(headers),
         _networkInfo(networkInfo),
         _requestFactory(nam),
+        _processFactory(processFactory),
         q_ptr(parent)
 {
     init();
@@ -151,7 +161,7 @@
 
 DownloadPrivate::DownloadPrivate(const QUuid& id, const QString& path, const QUrl& url, const QString& hash,
     QCryptographicHash::Algorithm algo, const QVariantMap& metadata, const QMap<QString, QString>& headers,
-    SystemNetworkInfo* networkInfo, RequestFactory* nam, Download* parent):
+    SystemNetworkInfo* networkInfo, RequestFactory* nam, ProcessFactory* processFactory, Download* parent):
         _id(id),
         _totalSize(0),
         _throttle(0),
@@ -165,6 +175,7 @@
         _headers(headers),
         _networkInfo(networkInfo),
         _requestFactory(nam),
+        _processFactory(processFactory),
         q_ptr(parent)
 {
     init();
@@ -496,7 +507,6 @@
 
     qDebug() << "Starting download.";
     // create file that will be used to mantain the state of the download when resumed.
-    // TODO: Use a better name
     _currentData = new QFile(saveFileName());
     _currentData->open(QIODevice::ReadWrite | QFile::Append);
 
@@ -655,23 +665,94 @@
             return;
         }
     }
+
+    // there are two possible cases, the first, we do no have the metadata info to execute a
+    // commnad once the download was finished and that means we are done here else we execute the
+    // command AND raise the finish signals once the command was done (or an error ocurred in the
+    // command execution.
+    if (_metadata.contains(METADATA_COMMAND_KEY))
+    {
+        // toStringList will return an empty list if it cannot be converted
+        QStringList commandData = _metadata[METADATA_COMMAND_KEY].toStringList();
+        if (commandData.count() == 0)
+        {
+            // raise error, command metadata was passed without the commnad
+            qCritical() << "COMMAND DATA MISSING";
+            _state = Download::FINISHED;
+            emit q->stateChanged();
+            emit q->error("COMMAND ERROR");
+            return;
+        }
+        else
+        {
+            // first item of the string list is the commnad, rest is the arguments
+            QString command = commandData.at(0);
+            commandData.removeAt(0);
+            QStringList args;
+
+            foreach(const QString& arg, commandData)
+            {
+                if (arg == METADATA_COMMAND_FILE_KEY)
+                    args << filePath();
+                else
+                    args << arg;
+            }
+
+            Process* postDownloadProcess = _processFactory->createProcess();
+
+            // connect to signals so that we can tell the clients that the operation succeed
+
+            q->connect(postDownloadProcess, SIGNAL(finished(int, QProcess::ExitStatus)),
+                q, SLOT(onProcessFinished(int, QProcess::ExitStatus)));
+            q->connect(postDownloadProcess, SIGNAL(error(QProcess::ProcessError)),
+                q, SLOT(onProcessError(QProcess::ProcessError)));
+
+            qDebug() << "Executing" << command << args;
+            postDownloadProcess->start(command, args);
+            return;
+        }
+    }
+    else
+    {
+        _state = Download::FINISHED;
+    	qDebug() << "EMIT stateChanged";
+        emit q->stateChanged();
+    	qDebug() << "EMIT finished" << filePath();
+        emit q->finished(filePath());
+    }
+
+    // clean the reply
+    _reply->deleteLater();
+    _reply = NULL;
+}
+
+void DownloadPrivate::onSslErrors(const QList<QSslError>& errors)
+{
+    qDebug() << __FUNCTION__ << _url;
+    // TODO: emit ssl errors signal?
+    Q_UNUSED(errors);
+    Q_Q(Download);
+    emit q->error("SSL ERROR");
+}
+
+void DownloadPrivate::onProcessError(QProcess::ProcessError error)
+{
+    // TODO: better error fowarding
+    Q_UNUSED(error);
+    Q_Q(Download);
+    emit q->error("COMMAND ERROR");
+}
+
+void DownloadPrivate::onProcessFinished(int exitCode, QProcess::ExitStatus exitStatus)
+{
+    qDebug() << __FUNCTION__ << exitCode << exitStatus;
+    // TODO: send the command exit code and status
+    Q_Q(Download);
     _state = Download::FINISHED;
     qDebug() << "EMIT stateChanged";
     emit q->stateChanged();
     qDebug() << "EMIT finished" << filePath();
     emit q->finished(filePath());
-    _reply->deleteLater();
-    _reply = NULL;
-
-}
-
-void DownloadPrivate::onSslErrors(const QList<QSslError>& errors)
-{
-    qDebug() << __FUNCTION__ << _url;
-    // TODO: emit ssl errors signal?
-    Q_UNUSED(errors);
-    Q_Q(Download);
-    emit q->error("SSL ERROR");
 }
 
 /**
@@ -679,16 +760,17 @@
  */
 
 Download::Download(const QUuid& id, const QString& path, const QUrl& url, const QVariantMap& metadata,
-    const QMap<QString, QString>& headers, SystemNetworkInfo* networkInfo, RequestFactory* nam, QObject* parent):
+    const QMap<QString, QString>& headers, SystemNetworkInfo* networkInfo, RequestFactory* nam, ProcessFactory* processFactory, QObject* parent):
         QObject(parent),
-        d_ptr(new DownloadPrivate(id, path, url, metadata, headers, networkInfo, nam, this))
+        d_ptr(new DownloadPrivate(id, path, url, metadata, headers, networkInfo, nam, processFactory, this))
 {
 }
 
 Download::Download(const QUuid& id, const QString& path, const QUrl& url, const QString& hash, QCryptographicHash::Algorithm algo,
-    const QVariantMap& metadata, const QMap<QString, QString> &headers, SystemNetworkInfo* networkInfo, RequestFactory* nam, QObject* parent):
+    const QVariantMap& metadata, const QMap<QString, QString> &headers, SystemNetworkInfo* networkInfo, RequestFactory* nam,
+    ProcessFactory* processFactory, QObject* parent):
         QObject(parent),
-        d_ptr(new DownloadPrivate(id, path, url, hash, algo, metadata, headers, networkInfo, nam, this))
+        d_ptr(new DownloadPrivate(id, path, url, hash, algo, metadata, headers, networkInfo, nam, processFactory, this))
 {
 }
 

=== modified file 'libubuntudownloadmanager/download.h'
--- libubuntudownloadmanager/download.h	2013-07-20 18:26:02 +0000
+++ libubuntudownloadmanager/download.h	2013-07-21 19:10:31 +0000
@@ -24,9 +24,11 @@
 #include <QBuffer>
 #include <QCryptographicHash>
 #include <QNetworkReply>
+#include <QProcess>
 #include <QUrl>
 #include <QUuid>
 #include "system_network_info.h"
+#include "process_factory.h"
 #include "request_factory.h"
 #include "app-downloader-lib_global.h"
 
@@ -48,10 +50,10 @@
     };
 
     explicit Download(const QUuid& id, const QString& path, const QUrl& url, const QVariantMap& metadata,
-        const QMap<QString, QString>& headers, SystemNetworkInfo* networkInfo, RequestFactory* nam, QObject* parent=0);
+        const QMap<QString, QString>& headers, SystemNetworkInfo* networkInfo, RequestFactory* nam, ProcessFactory* processFactory, QObject* parent=0);
     explicit Download(const QUuid& id, const QString& path, const QUrl& url, const QString& hash, QCryptographicHash::Algorithm algo,
         const QVariantMap& metadata, const QMap<QString, QString>& headers, SystemNetworkInfo* networkInfo, RequestFactory* nam,
-        QObject* parent=0);
+        ProcessFactory* processFactory, QObject* parent=0);
 
     // gets for internal state
     QUuid downloadId();
@@ -110,6 +112,11 @@
     Q_PRIVATE_SLOT(d_func(), void onFinished())
     Q_PRIVATE_SLOT(d_func(), void onSslErrors(const QList<QSslError>&))
 
+    // private slots used to keep track of the post download command
+
+    Q_PRIVATE_SLOT(d_func(), void onProcessError(QProcess::ProcessError error))
+    Q_PRIVATE_SLOT(d_func(), void onProcessFinished(int exitCode, QProcess::ExitStatus exitStatus))
+
 private:
     // use pimpl so that we can mantains ABI compatibility
     DownloadPrivate* d_ptr;

=== modified file 'libubuntudownloadmanager/download_manager.cpp'
--- libubuntudownloadmanager/download_manager.cpp	2013-07-20 18:26:02 +0000
+++ libubuntudownloadmanager/download_manager.cpp	2013-07-21 19:10:31 +0000
@@ -18,6 +18,7 @@
 
 #include <QRegExp>
 #include "request_factory.h"
+#include "process_factory.h"
 #include "download_adaptor.h"
 #include "download_queue.h"
 #include "download_manager.h"
@@ -58,6 +59,7 @@
     DownloadQueue* _downloadsQueue;
     DBusConnection* _conn;
     RequestFactory* _reqFactory;
+    ProcessFactory* _processFactory;
     UuidFactory* _uuidFactory;
     DownloadManager* q_ptr;
 };
@@ -98,6 +100,7 @@
         q, SLOT(onDownloadRemoved(QString)));
 
     _reqFactory = new RequestFactory();
+    _processFactory = new ProcessFactory();
 }
 
 void DownloadManagerPrivate::addDownload(Download* download)
@@ -141,9 +144,9 @@
     {
         Download* download;
         if (hash.isEmpty())
-            download = new Download(id, path, url, metadata, headers, _networkInfo, _reqFactory);
+            download = new Download(id, path, url, metadata, headers, _networkInfo, _reqFactory, _processFactory);
         else
-            download = new Download(id, path, url, hash, algo, metadata, headers, _networkInfo, _reqFactory);
+            download = new Download(id, path, url, hash, algo, metadata, headers, _networkInfo, _reqFactory, _processFactory);
 
         download->setThrottle(_throttle);
         DownloadAdaptor* adaptor = new DownloadAdaptor(download);

=== modified file 'libubuntudownloadmanager/libubuntudownloadmanager.pro'
--- libubuntudownloadmanager/libubuntudownloadmanager.pro	2013-07-20 14:08:52 +0000
+++ libubuntudownloadmanager/libubuntudownloadmanager.pro	2013-07-21 19:10:31 +0000
@@ -19,7 +19,9 @@
     request_factory.cpp \
     system_network_info.cpp \
     uuid_factory.cpp \
-    xdg_basedir.cpp
+    xdg_basedir.cpp \
+    process.cpp \
+    process_factory.cpp
 
 HEADERS +=\
     app-downloader-lib_global.h \
@@ -35,6 +37,8 @@
     system_network_info.h \
     uuid_factory.h \
     xdg_basedir.h \
+    process.h \
+    process_factory.h \
     metatypes.h
 
 OTHER_FILES += \

=== added file 'libubuntudownloadmanager/process.cpp'
--- libubuntudownloadmanager/process.cpp	1970-01-01 00:00:00 +0000
+++ libubuntudownloadmanager/process.cpp	2013-07-21 19:10:31 +0000
@@ -0,0 +1,95 @@
+/*
+ * Copyright 2013 2013 Canonical Ltd.
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of version 3 of the GNU Lesser General Public
+ * License as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the
+ * Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+ * Boston, MA 02110-1301, USA.
+ */
+
+#include <QProcess>
+#include "process.h"
+
+/*
+ * PRIVATE IMPLEMENTATION
+ */
+
+class ProcessPrivate
+{
+    Q_DECLARE_PUBLIC(Process)
+public:
+    explicit ProcessPrivate(Process* parent);
+    ~ProcessPrivate();
+
+    void start(const QString& program, const QStringList& arguments, QProcess::OpenMode mode = QProcess::ReadWrite);
+
+    void onError(QProcess::ProcessError error);
+    void onFinished(int exitCode, QProcess::ExitStatus exitStatus);
+
+private:
+    QProcess* _process;
+    Process* q_ptr;
+
+};
+
+ProcessPrivate::ProcessPrivate(Process* parent) :
+    q_ptr(parent)
+{
+    Q_Q(Process);
+    _process = new QProcess();
+
+    q->connect(_process, SIGNAL(finished(int, QProcess::ExitStatus)),
+        q, SLOT(onFinished(int, QProcess::ExitStatus)));
+    q->connect(_process, SIGNAL(error(QProcess::ProcessError)),
+        q, SLOT(onError(QProcess::ProcessError)));
+}
+
+ProcessPrivate::~ProcessPrivate()
+{
+    if (_process != NULL)
+        delete _process;
+}
+
+void ProcessPrivate::start(const QString& program, const QStringList& arguments, QProcess::OpenMode mode)
+{
+    _process->start(program, arguments, mode);
+}
+
+void ProcessPrivate::onError(QProcess::ProcessError error)
+{
+    Q_Q(Process);
+    emit q->error(error);
+}
+
+void ProcessPrivate::onFinished(int exitCode, QProcess::ExitStatus exitStatus)
+{
+    Q_Q(Process);
+    emit q->finished(exitCode, exitStatus);
+}
+
+/*
+ * PUBLIC IMPLEMENTATION
+ */
+
+Process::Process(QObject *parent) :
+    QObject(parent),
+    d_ptr(new ProcessPrivate(this))
+{
+}
+
+void Process::start(const QString& program, const QStringList& arguments, QProcess::OpenMode mode)
+{
+    Q_D(Process);
+    d->start(program, arguments, mode);
+}
+
+#include "moc_process.cpp"

=== added file 'libubuntudownloadmanager/process.h'
--- libubuntudownloadmanager/process.h	1970-01-01 00:00:00 +0000
+++ libubuntudownloadmanager/process.h	2013-07-21 19:10:31 +0000
@@ -0,0 +1,49 @@
+/*
+ * Copyright 2013 2013 Canonical Ltd.
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of version 3 of the GNU Lesser General Public
+ * License as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the
+ * Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+ * Boston, MA 02110-1301, USA.
+ */
+
+#ifndef DOWNLOADER_LIB_PROCESS_H
+#define DOWNLOADER_LIB_PROCESS_H
+
+#include <QObject>
+#include <QProcess>
+
+class ProcessPrivate;
+class Process : public QObject
+{
+    Q_OBJECT
+    Q_DECLARE_PRIVATE(Process)
+
+public:
+    explicit Process(QObject *parent = 0);
+    
+    virtual void start(const QString& program, const QStringList& arguments, QProcess::OpenMode mode = QProcess::ReadWrite);
+
+signals:
+    void error(QProcess::ProcessError error);
+    void finished(int exitCode, QProcess::ExitStatus exitStatus);
+    
+private:
+    Q_PRIVATE_SLOT(d_func(), void onError(QProcess::ProcessError error))
+    Q_PRIVATE_SLOT(d_func(), void onFinished(int exitCode, QProcess::ExitStatus exitStatus))
+
+private:
+    // use pimpl so that we can mantains ABI compatibility
+    ProcessPrivate* d_ptr;
+};
+
+#endif // PROCESS_H

=== added file 'libubuntudownloadmanager/process_factory.cpp'
--- libubuntudownloadmanager/process_factory.cpp	1970-01-01 00:00:00 +0000
+++ libubuntudownloadmanager/process_factory.cpp	2013-07-21 19:10:31 +0000
@@ -0,0 +1,63 @@
+/*
+ * Copyright 2013 2013 Canonical Ltd.
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of version 3 of the GNU Lesser General Public
+ * License as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the
+ * Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+ * Boston, MA 02110-1301, USA.
+ */
+
+#include "process_factory.h"
+
+/*
+ * PRIVATE IMPLEMENTATION
+ */
+
+class ProcessFactoryPrivate
+{
+    Q_DECLARE_PUBLIC(ProcessFactory)
+public:
+    explicit ProcessFactoryPrivate(ProcessFactory* parent);
+
+    Process* createProcess();
+
+private:
+    ProcessFactory* q_ptr;
+
+};
+
+
+ProcessFactoryPrivate::ProcessFactoryPrivate(ProcessFactory* parent):
+    q_ptr(parent)
+{
+}
+
+Process* ProcessFactoryPrivate::createProcess()
+{
+    return new Process();
+}
+
+/*
+ * PUBLIC IMPLEMENTATION
+ */
+
+ProcessFactory::ProcessFactory(QObject *parent) :
+    QObject(parent),
+    d_ptr(new ProcessFactoryPrivate(this))
+{
+}
+
+Process* ProcessFactory::createProcess()
+{
+    Q_D(ProcessFactory);
+    return d->createProcess();
+}

=== added file 'libubuntudownloadmanager/process_factory.h'
--- libubuntudownloadmanager/process_factory.h	1970-01-01 00:00:00 +0000
+++ libubuntudownloadmanager/process_factory.h	2013-07-21 19:10:31 +0000
@@ -0,0 +1,41 @@
+/*
+ * Copyright 2013 2013 Canonical Ltd.
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of version 3 of the GNU Lesser General Public
+ * License as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the
+ * Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+ * Boston, MA 02110-1301, USA.
+ */
+
+#ifndef DOWNLOADER_LIB_PROCESS_FACTORY_H
+#define DOWNLOADER_LIB_PROCESS_FACTORY_H
+
+#include <QObject>
+#include "process.h"
+
+class ProcessFactoryPrivate;
+class ProcessFactory : public QObject
+{
+    Q_OBJECT
+    Q_DECLARE_PRIVATE(ProcessFactory)
+
+public:
+    explicit ProcessFactory(QObject *parent = 0);
+
+    virtual Process* createProcess();
+
+private:
+    // use pimpl so that we can mantains ABI compatibility
+    ProcessFactoryPrivate* d_ptr;
+};
+
+#endif

=== modified file 'ubuntu-download-manager-tests/fake.cpp'
--- ubuntu-download-manager-tests/fake.cpp	2013-07-08 16:46:16 +0000
+++ ubuntu-download-manager-tests/fake.cpp	2013-07-21 19:10:31 +0000
@@ -60,6 +60,27 @@
 }
 
 /*
+ * STRING LIST WRAPPER
+ */
+
+
+StringListWrapper::StringListWrapper(const QStringList& list, QObject* parent) :
+    QObject(parent)
+{
+    _value = list;
+}
+
+QStringList StringListWrapper::value()
+{
+    return _value;
+}
+
+void StringListWrapper::setValue(const QStringList& value)
+{
+    _value = value;
+}
+
+/*
  * UINT WRAPPER
  */
 

=== modified file 'ubuntu-download-manager-tests/fake.h'
--- ubuntu-download-manager-tests/fake.h	2013-07-08 16:46:16 +0000
+++ ubuntu-download-manager-tests/fake.h	2013-07-21 19:10:31 +0000
@@ -22,6 +22,7 @@
 #include <QList>
 #include <QObject>
 #include <QPair>
+#include <QStringList>
 
 
 class BoolWrapper : public QObject
@@ -52,6 +53,20 @@
 };
 
 
+class StringListWrapper : public QObject
+{
+    Q_OBJECT
+
+public:
+    StringListWrapper(const QStringList& list, QObject* parent=0);
+
+    QStringList value();
+    void setValue(const QStringList& value);
+
+private:
+    QStringList _value;
+};
+
 class UintWrapper : public QObject
 {
     Q_OBJECT

=== modified file 'ubuntu-download-manager-tests/fake_download.cpp'
--- ubuntu-download-manager-tests/fake_download.cpp	2013-07-20 18:26:02 +0000
+++ ubuntu-download-manager-tests/fake_download.cpp	2013-07-21 19:10:31 +0000
@@ -19,15 +19,16 @@
 #include "fake_download.h"
 
 FakeDownload::FakeDownload(const QUuid& id, const QString& path, const QUrl& url, const QVariantMap& metadata,
-    const QMap<QString, QString> &headers, SystemNetworkInfo* networkInfo, RequestFactory* nam, QObject* parent):
-        Download(id, path, url, metadata, headers, networkInfo, nam, parent),
+    const QMap<QString, QString> &headers, SystemNetworkInfo* networkInfo, RequestFactory* nam, ProcessFactory* processFactory, QObject* parent):
+        Download(id, path, url, metadata, headers, networkInfo, nam, processFactory, parent),
         _canDownload(true)
 {
 }
 
 FakeDownload::FakeDownload(const QUuid& id, const QString& path, const QUrl& url, const QString& hash, QCryptographicHash::Algorithm algo,
-        const QVariantMap& metadata, const QMap<QString ,QString>& headers, SystemNetworkInfo* networkInfo, RequestFactory* nam, QObject* parent) :
-        Download(id, path, url, hash, algo, metadata, headers, networkInfo, nam, parent),
+        const QVariantMap& metadata, const QMap<QString ,QString>& headers, SystemNetworkInfo* networkInfo, RequestFactory* nam,
+        ProcessFactory* processFactory, QObject* parent) :
+        Download(id, path, url, hash, algo, metadata, headers, networkInfo, nam, processFactory, parent),
         _canDownload(true)
 {
 }

=== modified file 'ubuntu-download-manager-tests/fake_download.h'
--- ubuntu-download-manager-tests/fake_download.h	2013-07-20 18:26:02 +0000
+++ ubuntu-download-manager-tests/fake_download.h	2013-07-21 19:10:31 +0000
@@ -28,10 +28,11 @@
     Q_OBJECT
 public:
     explicit FakeDownload(const QUuid& id, const QString& path, const QUrl& url, const QVariantMap& metadata,
-        const QMap<QString, QString>& headers, SystemNetworkInfo* networkInfo, RequestFactory* nam, QObject* parent=0);
+        const QMap<QString, QString>& headers, SystemNetworkInfo* networkInfo, RequestFactory* nam, ProcessFactory* processFactory,
+        QObject* parent=0);
     explicit FakeDownload(const QUuid& id, const QString& path, const QUrl& url, const QString& hash,
         QCryptographicHash::Algorithm algo, const QVariantMap& metadata, const QMap<QString, QString> &headers,
-        SystemNetworkInfo* networkInfo, RequestFactory* nam, QObject* parent=0);
+        SystemNetworkInfo* networkInfo, RequestFactory* nam, ProcessFactory* processFactory, QObject* parent=0);
 
     bool canDownload() override;
     void setCanDownload(bool canDownload);

=== modified file 'ubuntu-download-manager-tests/fake_network_reply.cpp'
--- ubuntu-download-manager-tests/fake_network_reply.cpp	2013-07-08 16:46:16 +0000
+++ ubuntu-download-manager-tests/fake_network_reply.cpp	2013-07-21 19:10:31 +0000
@@ -69,3 +69,8 @@
         _called.append(methodData);
     }
 }
+
+void FakeNetworkReply::emitFinished()
+{
+    emit finished();
+}

=== modified file 'ubuntu-download-manager-tests/fake_network_reply.h'
--- ubuntu-download-manager-tests/fake_network_reply.h	2013-07-08 16:46:16 +0000
+++ ubuntu-download-manager-tests/fake_network_reply.h	2013-07-21 19:10:31 +0000
@@ -38,6 +38,7 @@
     QByteArray readAll() override;
     void abort() override;
     void setReadBufferSize(uint size) override;
+    void emitFinished();
 
 private:
     QByteArray _data;

=== added file 'ubuntu-download-manager-tests/fake_process.cpp'
--- ubuntu-download-manager-tests/fake_process.cpp	1970-01-01 00:00:00 +0000
+++ ubuntu-download-manager-tests/fake_process.cpp	2013-07-21 19:10:31 +0000
@@ -0,0 +1,57 @@
+/*
+ * Copyright 2013 2013 Canonical Ltd.
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of version 3 of the GNU Lesser General Public
+ * License as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the
+ * Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+ * Boston, MA 02110-1301, USA.
+ */
+
+#include "fake_process.h"
+
+OpenModeWrapper::OpenModeWrapper(QProcess::OpenMode mode, QObject* parent) :
+    QObject(parent)
+{
+    _value = mode;
+}
+
+QProcess::OpenMode OpenModeWrapper::value()
+{
+    return _value;
+}
+
+void OpenModeWrapper::setValue(QProcess::OpenMode value)
+{
+    _value = value;
+}
+
+FakeProcess::FakeProcess(QObject *parent) :
+    Process(parent),
+    Fake()
+{
+}
+
+void FakeProcess::start(const QString& program, const QStringList& arguments, QProcess::OpenMode mode)
+{
+    if (_recording)
+    {
+        QList<QObject*> inParams;
+        inParams.append(new StringWrapper(program));
+        inParams.append(new StringListWrapper(arguments));
+        inParams.append(new OpenModeWrapper(mode));
+
+        QList<QObject*> outParams;
+        MethodParams params(inParams, outParams);
+        MethodData methodData("start", params);
+        _called.append(methodData);
+    }
+}

=== added file 'ubuntu-download-manager-tests/fake_process.h'
--- ubuntu-download-manager-tests/fake_process.h	1970-01-01 00:00:00 +0000
+++ ubuntu-download-manager-tests/fake_process.h	2013-07-21 19:10:31 +0000
@@ -0,0 +1,50 @@
+/*
+ * Copyright 2013 2013 Canonical Ltd.
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of version 3 of the GNU Lesser General Public
+ * License as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the
+ * Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+ * Boston, MA 02110-1301, USA.
+ */
+
+#ifndef FAKE_PROCESS_H
+#define FAKE_PROCESS_H
+
+#include <QObject>
+#include <process.h>
+#include "fake.h"
+
+class OpenModeWrapper: public QObject
+{
+    Q_OBJECT
+
+public:
+    OpenModeWrapper(QProcess::OpenMode mode, QObject* parent=0);
+
+    QProcess::OpenMode value();
+    void setValue(QProcess::OpenMode value);
+
+private:
+    QProcess::OpenMode _value;
+};
+
+class FakeProcess : public Process, public Fake
+{
+    Q_OBJECT
+public:
+    explicit FakeProcess(QObject *parent = 0);
+    
+    void start(const QString& program, const QStringList& arguments, QProcess::OpenMode mode = QProcess::ReadWrite) override;
+    
+};
+
+#endif // FAKE_PROCESS_H

=== added file 'ubuntu-download-manager-tests/fake_process_factory.cpp'
--- ubuntu-download-manager-tests/fake_process_factory.cpp	1970-01-01 00:00:00 +0000
+++ ubuntu-download-manager-tests/fake_process_factory.cpp	2013-07-21 19:10:31 +0000
@@ -0,0 +1,48 @@
+/*
+ * Copyright 2013 2013 Canonical Ltd.
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of version 3 of the GNU Lesser General Public
+ * License as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the
+ * Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+ * Boston, MA 02110-1301, USA.
+ */
+
+#include "fake_process_factory.h"
+#include "fake_process.h"
+
+FakeProcessFactory::FakeProcessFactory(QObject *parent) :
+    ProcessFactory(parent),
+    Fake()
+{
+}
+
+Process* FakeProcessFactory::createProcess()
+{
+
+    FakeProcess* process = new FakeProcess();
+
+    if (_recording)
+    {
+        QList<QObject*> inParams;
+
+        QList<QObject*> outParams;
+        outParams.append(process);
+        MethodParams params(inParams, outParams);
+
+        MethodData methodData("createProcess", params);
+        _called.append(methodData);
+
+        // if we are recording we do set the recording of the returned process
+        process->record();
+    }
+    return process;
+}

=== added file 'ubuntu-download-manager-tests/fake_process_factory.h'
--- ubuntu-download-manager-tests/fake_process_factory.h	1970-01-01 00:00:00 +0000
+++ ubuntu-download-manager-tests/fake_process_factory.h	2013-07-21 19:10:31 +0000
@@ -0,0 +1,36 @@
+/*
+ * Copyright 2013 2013 Canonical Ltd.
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of version 3 of the GNU Lesser General Public
+ * License as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the
+ * Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+ * Boston, MA 02110-1301, USA.
+ */
+
+#ifndef FAKE_PROCESS_FACTORY_H
+#define FAKE_PROCESS_FACTORY_H
+
+#include <QObject>
+#include <process_factory.h>
+#include "fake.h"
+
+class FakeProcessFactory : public ProcessFactory, public Fake
+{
+    Q_OBJECT
+public:
+    explicit FakeProcessFactory(QObject *parent = 0);
+    
+    Process* createProcess() override;
+    
+};
+
+#endif // FAKE_PROCESS_FACTORY_H

=== modified file 'ubuntu-download-manager-tests/test_download.cpp'
--- ubuntu-download-manager-tests/test_download.cpp	2013-07-20 18:26:02 +0000
+++ ubuntu-download-manager-tests/test_download.cpp	2013-07-21 19:10:31 +0000
@@ -22,6 +22,7 @@
 #include <QSignalSpy>
 #include <QSslError>
 #include "fake_network_reply.h"
+#include "fake_process.h"
 #include "test_download.h"
 
 TestDownload::TestDownload(QObject* parent) :
@@ -73,6 +74,7 @@
     _algo = QCryptographicHash::Sha256;
     _networkInfo = new FakeSystemNetworkInfo();
     _reqFactory = new FakeRequestFactory();
+    _processFactory = new FakeProcessFactory();
 }
 
 void TestDownload::cleanup()
@@ -81,6 +83,8 @@
         delete _networkInfo;
     if (_reqFactory)
         delete _reqFactory;
+    if (_processFactory)
+        delete _processFactory;
 
     // try to remove the test dir
     removeDir(_testDir.absolutePath());
@@ -105,7 +109,7 @@
     QFETCH(QString, path);
     QFETCH(QUrl, url);
 
-    Download* download = new Download(id, path, url, _metadata, _headers, _networkInfo, _reqFactory);
+    Download* download = new Download(id, path, url, _metadata, _headers, _networkInfo, _reqFactory, _processFactory);
 
     // assert that we did set the intial state correctly
     // gets for internal state
@@ -147,7 +151,7 @@
     QFETCH(int, algo);
 
     Download* download = new Download(id, path, url, hash, (QCryptographicHash::Algorithm)algo, _metadata, _headers, _networkInfo,
-        _reqFactory);
+        _reqFactory, _processFactory);
 
     QCOMPARE(download->downloadId(), id);
     QCOMPARE(download->path(), path);
@@ -176,7 +180,7 @@
 {
     // create an app download and assert that the returned data is correct
     QFETCH(QString, path);
-    Download* download = new Download(_id, path, _url, _metadata, _headers, _networkInfo, _reqFactory);
+    Download* download = new Download(_id, path, _url, _metadata, _headers, _networkInfo, _reqFactory, _processFactory);
     QCOMPARE(download->path(), path);
 }
 
@@ -195,7 +199,7 @@
 {
     // create an app download and assert that the returned data is correct
     QFETCH(QUrl, url);
-    Download* download = new Download(_id, _path, url, _metadata, _headers, _networkInfo, _reqFactory);
+    Download* download = new Download(_id, _path, url, _metadata, _headers, _networkInfo, _reqFactory, _processFactory);
     QCOMPARE(download->url(), url);
     delete download;
 }
@@ -219,7 +223,7 @@
     QFETCH(qulonglong, total);
 
     _reqFactory->record();
-    Download* download = new Download(_id, _path, _url, _metadata, _headers, _networkInfo, _reqFactory);
+    Download* download = new Download(_id, _path, _url, _metadata, _headers, _networkInfo, _reqFactory, _processFactory);
     QSignalSpy spy(download , SIGNAL(progress(qulonglong, qulonglong)));
 
     // start the download so that we do have access to the reply
@@ -248,7 +252,7 @@
 
     // assert that the total size is just set once by emitting two signals with diff sizes
     _reqFactory->record();
-    Download* download = new Download(_id, _path, _url, _metadata, _headers, _networkInfo, _reqFactory);
+    Download* download = new Download(_id, _path, _url, _metadata, _headers, _networkInfo, _reqFactory, _processFactory);
     QSignalSpy spy(download , SIGNAL(progress(qulonglong, qulonglong)));
 
     // start the download so that we do have access to the reply
@@ -267,7 +271,7 @@
 
 void TestDownload::testTotalSizeNoProgress()
 {
-    Download* download = new Download(_id, _path, _url, _metadata, _headers, _networkInfo, _reqFactory);
+    Download* download = new Download(_id, _path, _url, _metadata, _headers, _networkInfo, _reqFactory, _processFactory);
     QCOMPARE(0ULL, download->totalSize());
     delete download;
 }
@@ -285,7 +289,7 @@
 void TestDownload::testSetThrottleNoReply()
 {
     QFETCH(qulonglong, speed);
-    Download* download = new Download(_id, _path, _url, _metadata, _headers, _networkInfo, _reqFactory);
+    Download* download = new Download(_id, _path, _url, _metadata, _headers, _networkInfo, _reqFactory, _processFactory);
     download->setThrottle(speed);
     QCOMPARE(speed, download->throttle());
 }
@@ -305,7 +309,7 @@
     QFETCH(uint, speed);
 
     _reqFactory->record();
-    Download* download = new Download(_id, _path, _url, _metadata, _headers, _networkInfo, _reqFactory);
+    Download* download = new Download(_id, _path, _url, _metadata, _headers, _networkInfo, _reqFactory, _processFactory);
     download->setThrottle(speed);
 
     download->start();  // change state
@@ -332,7 +336,7 @@
 {
     QFETCH(bool, value);
 
-    Download* download = new Download(_id, _path, _url, _metadata, _headers, _networkInfo, _reqFactory);
+    Download* download = new Download(_id, _path, _url, _metadata, _headers, _networkInfo, _reqFactory, _processFactory);
     download->allowGSMDownload(value);
     QSignalSpy spy(download , SIGNAL(stateChanged()));
 
@@ -354,7 +358,7 @@
     QFETCH(bool, oldValue);
     QFETCH(bool, newValue);
 
-    Download* download = new Download(_id, _path, _url, _metadata, _headers, _networkInfo, _reqFactory);
+    Download* download = new Download(_id, _path, _url, _metadata, _headers, _networkInfo, _reqFactory, _processFactory);
     download->allowGSMDownload(oldValue);
     QSignalSpy spy(download , SIGNAL(stateChanged()));
 
@@ -395,7 +399,7 @@
     _networkInfo->setMode(mode.value<QNetworkInfo::NetworkMode>());
     _networkInfo->record();
 
-    Download* download = new Download(_id, _path, _url, _metadata, _headers, _networkInfo, _reqFactory);
+    Download* download = new Download(_id, _path, _url, _metadata, _headers, _networkInfo, _reqFactory, _processFactory);
     download->allowGSMDownload(true);
     QVERIFY(download->canDownload());
     QList<MethodData> calledMethods = _networkInfo->calledMethods();
@@ -439,7 +443,7 @@
     _networkInfo->setMode(mode.value<QNetworkInfo::NetworkMode>());
     _networkInfo->record();
 
-    Download* download = new Download(_id, _path, _url, _metadata, _headers, _networkInfo, _reqFactory);
+    Download* download = new Download(_id, _path, _url, _metadata, _headers, _networkInfo, _reqFactory, _processFactory);
     download->allowGSMDownload(false);
 
     QCOMPARE(result, download->canDownload());
@@ -449,7 +453,7 @@
 
 void TestDownload::testCancel()
 {
-    Download* download = new Download(_id, _path, _url, _metadata, _headers, _networkInfo, _reqFactory);
+    Download* download = new Download(_id, _path, _url, _metadata, _headers, _networkInfo, _reqFactory, _processFactory);
     QSignalSpy spy(download , SIGNAL(stateChanged()));
     download->cancel();
 
@@ -460,7 +464,7 @@
 
 void TestDownload::testPause()
 {
-    Download* download = new Download(_id, _path, _url, _metadata, _headers, _networkInfo, _reqFactory);
+    Download* download = new Download(_id, _path, _url, _metadata, _headers, _networkInfo, _reqFactory, _processFactory);
     QSignalSpy spy(download , SIGNAL(stateChanged()));
     download->pause();
 
@@ -471,7 +475,7 @@
 
 void TestDownload::testResume()
 {
-    Download* download = new Download(_id, _path, _url, _metadata, _headers, _networkInfo, _reqFactory);
+    Download* download = new Download(_id, _path, _url, _metadata, _headers, _networkInfo, _reqFactory, _processFactory);
     QSignalSpy spy(download , SIGNAL(stateChanged()));
     download->resume();
 
@@ -482,7 +486,7 @@
 
 void TestDownload::testStart()
 {
-    Download* download = new Download(_id, _path, _url, _metadata, _headers, _networkInfo, _reqFactory);
+    Download* download = new Download(_id, _path, _url, _metadata, _headers, _networkInfo, _reqFactory, _processFactory);
     QSignalSpy spy(download , SIGNAL(stateChanged()));
     download->start();
 
@@ -496,7 +500,7 @@
     // tell the fake nam to record so that we can access the reply
 
     _reqFactory->record();
-    Download* download = new Download(_id, _path, _url, _metadata, _headers, _networkInfo, _reqFactory);
+    Download* download = new Download(_id, _path, _url, _metadata, _headers, _networkInfo, _reqFactory, _processFactory);
     QSignalSpy spy(download , SIGNAL(canceled(bool)));
 
     download->start();  // change state
@@ -526,7 +530,7 @@
 void TestDownload::testCancelDownloadNotStarted()
 {
     _reqFactory->record();
-    Download* download = new Download(_id, _path, _url, _metadata, _headers, _networkInfo, _reqFactory);
+    Download* download = new Download(_id, _path, _url, _metadata, _headers, _networkInfo, _reqFactory, _processFactory);
     QSignalSpy spy(download , SIGNAL(canceled(bool)));
 
     download->cancel(); // change state
@@ -545,7 +549,7 @@
 void TestDownload::testPauseDownload()
 {
     _reqFactory->record();
-    Download* download = new Download(_id, _path, _url, _metadata, _headers, _networkInfo, _reqFactory);
+    Download* download = new Download(_id, _path, _url, _metadata, _headers, _networkInfo, _reqFactory, _processFactory);
     QSignalSpy spy(download , SIGNAL(paused(bool)));
 
     download->start();  // change state
@@ -579,7 +583,7 @@
 
 void TestDownload::testPauseDownloadNotStarted()
 {
-    Download* download = new Download(_id, _path, _url, _metadata, _headers, _networkInfo, _reqFactory);
+    Download* download = new Download(_id, _path, _url, _metadata, _headers, _networkInfo, _reqFactory, _processFactory);
     QSignalSpy spy(download , SIGNAL(paused(bool)));
 
     download->pause();
@@ -594,7 +598,7 @@
 
 void TestDownload::testResumeRunning()
 {
-    Download* download = new Download(_id, _path, _url, _metadata, _headers, _networkInfo, _reqFactory);
+    Download* download = new Download(_id, _path, _url, _metadata, _headers, _networkInfo, _reqFactory, _processFactory);
     QSignalSpy spy(download , SIGNAL(resumed(bool)));
 
     download->start();
@@ -612,7 +616,7 @@
 void TestDownload::testResumeDownload()
 {
     _reqFactory->record();
-    Download* download = new Download(_id, _path, _url, _metadata, _headers, _networkInfo, _reqFactory);
+    Download* download = new Download(_id, _path, _url, _metadata, _headers, _networkInfo, _reqFactory, _processFactory);
     QSignalSpy spy(download , SIGNAL(paused(bool)));
 
     download->start();  // change state
@@ -645,7 +649,7 @@
 void TestDownload::testStartDownload()
 {
     _reqFactory->record();
-    Download* download = new Download(_id, _path, _url, _metadata, _headers, _networkInfo, _reqFactory);
+    Download* download = new Download(_id, _path, _url, _metadata, _headers, _networkInfo, _reqFactory, _processFactory);
     QSignalSpy spy(download , SIGNAL(started(bool)));
 
     download->start();  // change state
@@ -665,7 +669,7 @@
 void TestDownload::testStartDownloadAlreadyStarted()
 {
     _reqFactory->record();
-    Download* download = new Download(_id, _path, _url, _metadata, _headers, _networkInfo, _reqFactory);
+    Download* download = new Download(_id, _path, _url, _metadata, _headers, _networkInfo, _reqFactory, _processFactory);
     QSignalSpy spy(download , SIGNAL(started(bool)));
 
     download->start();  // change state
@@ -686,7 +690,7 @@
 void TestDownload::testOnSuccessNoHash()
 {
     _reqFactory->record();
-    Download* download = new Download(_id, _path, _url, _metadata, _headers, _networkInfo, _reqFactory);
+    Download* download = new Download(_id, _path, _url, _metadata, _headers, _networkInfo, _reqFactory, _processFactory);
     QSignalSpy spy(download , SIGNAL(finished(QString)));
 
     download->start();  // change state
@@ -706,7 +710,7 @@
 {
     _reqFactory->record();
     Download* download = new Download(_id, _path, _url, "imposible-hash-is-not-hex", _algo, _metadata, _headers,
-        _networkInfo, _reqFactory);
+        _networkInfo, _reqFactory, _processFactory);
     QSignalSpy spy(download , SIGNAL(error(QString)));
 
     download->start();  // change state
@@ -763,7 +767,8 @@
     QFETCH(QString, hash);
 
     _reqFactory->record();
-    Download* download = new Download(_id, _path, _url, hash, _algo, _metadata, _headers, _networkInfo, _reqFactory);
+    Download* download = new Download(_id, _path, _url, hash, _algo, _metadata, _headers, _networkInfo, _reqFactory,
+        _processFactory);
     QSignalSpy spy(download , SIGNAL(finished(QString)));
 
     download->start();  // change state
@@ -797,7 +802,7 @@
 void TestDownload::testOnHttpError()
 {
     _reqFactory->record();
-    Download* download = new Download(_id, _path, _url, _metadata, _headers, _networkInfo, _reqFactory);
+    Download* download = new Download(_id, _path, _url, _metadata, _headers, _networkInfo, _reqFactory, _processFactory);
     QSignalSpy spy(download , SIGNAL(error(QString)));
 
     download->start();  // change state
@@ -845,7 +850,7 @@
 {
     QFETCH(StringMap, headers);
     _reqFactory->record();
-    Download* download = new Download(_id, _path, _url, _metadata, headers, _networkInfo, _reqFactory);
+    Download* download = new Download(_id, _path, _url, _metadata, headers, _networkInfo, _reqFactory, _processFactory);
 
     download->start();  // change state
     download->startDownload();
@@ -898,7 +903,7 @@
     // similar to the previous test but we want to ensure that range is not set
     QFETCH(StringMap, headers);
     _reqFactory->record();
-    Download* download = new Download(_id, _path, _url, _metadata, headers, _networkInfo, _reqFactory);
+    Download* download = new Download(_id, _path, _url, _metadata, headers, _networkInfo, _reqFactory, _processFactory);
 
     download->start();  // change state
     download->startDownload();
@@ -943,7 +948,7 @@
     QFETCH(StringMap, headers);
 
     _reqFactory->record();
-    Download* download = new Download(_id, _path, _url, _metadata, headers, _networkInfo, _reqFactory);
+    Download* download = new Download(_id, _path, _url, _metadata, headers, _networkInfo, _reqFactory, _processFactory);
     QSignalSpy spy(download , SIGNAL(paused(bool)));
 
     download->start();  // change state
@@ -1017,7 +1022,7 @@
     QFETCH(StringMap, headers);
 
     _reqFactory->record();
-    Download* download = new Download(_id, _path, _url, _metadata, headers, _networkInfo, _reqFactory);
+    Download* download = new Download(_id, _path, _url, _metadata, headers, _networkInfo, _reqFactory, _processFactory);
     QSignalSpy spy(download , SIGNAL(paused(bool)));
 
     download->start();  // change state
@@ -1047,3 +1052,165 @@
     QByteArray rangeHeaderValue = "bytes=" + QByteArray::number(reply->data().size()) + "-";
     QCOMPARE(rangeHeaderValue, request.rawHeader("Range"));
 }
+
+void TestDownload::testProcessExecutedNoParams_data()
+{
+    QTest::addColumn<QString>("command");
+    QTest::addColumn<QVariantMap>("metadata");
+    QVariantMap first, second, third;
+    QStringList firstCommand, secondCommand, thirdCommand;
+
+    firstCommand << "touch";
+    first["post-download-command"] = firstCommand;
+
+    QTest::newRow("First row") << firstCommand[0] << first;
+
+    secondCommand << "sudo";
+    second["post-download-command"] = secondCommand;
+
+    QTest::newRow("Second row") << secondCommand[0] << second;
+
+    thirdCommand << "grep";
+    third["post-download-command"] = thirdCommand;
+
+    QTest::newRow("Third row") << thirdCommand[0] << third;
+}
+
+void TestDownload::testProcessExecutedNoParams()
+{
+    QFETCH(QString, command);
+    QFETCH(QVariantMap, metadata);
+
+    _processFactory->record();
+    _reqFactory->record();
+    Download* download = new Download(_id, _path, _url, metadata, _headers, _networkInfo, _reqFactory, _processFactory);
+
+    download->start();  // change state
+    download->startDownload();
+
+    // we need to set the data before we pause!!!
+    QList<MethodData> calledMethods = _reqFactory->calledMethods();
+    QCOMPARE(1, calledMethods.count());
+    FakeNetworkReply* reply = (FakeNetworkReply*) calledMethods[0].params().outParams()[0];
+
+    // makes the process to be executed
+    reply->emitFinished();
+
+    calledMethods = _processFactory->calledMethods();
+    QCOMPARE(1, calledMethods.count());
+    FakeProcess* process = (FakeProcess*) calledMethods[0].params().outParams()[0];
+
+    calledMethods = process->calledMethods();
+    QString processCommand = ((StringWrapper*)calledMethods[0].params().inParams()[0])->value();
+    QStringList processArgs = ((StringListWrapper*)calledMethods[0].params().inParams()[1])->value();
+    QCOMPARE(processCommand, command);
+    QCOMPARE(0, processArgs.count());
+}
+
+void TestDownload::testProcessExecutedWithParams_data()
+{
+    QTest::addColumn<QString>("command");
+    QTest::addColumn<QVariantMap>("metadata");
+    QVariantMap first, second, third;
+    QStringList firstCommand, secondCommand, thirdCommand;
+
+    firstCommand << "touch" << "test-file";
+    first["post-download-command"] = firstCommand;
+
+    QTest::newRow("First row") << firstCommand[0] << first;
+
+    secondCommand << "sudo" << "apt-get" << "install" << "click";
+    second["post-download-command"] = secondCommand;
+
+    QTest::newRow("Second row") << secondCommand[0] << second;
+
+    thirdCommand << "grep" << "." << "-Rn";
+    third["post-download-command"] = thirdCommand;
+
+    QTest::newRow("Third row") << thirdCommand[0] << third;
+}
+
+void TestDownload::testProcessExecutedWithParams()
+{
+    QFETCH(QString, command);
+    QFETCH(QVariantMap, metadata);
+
+    _processFactory->record();
+    _reqFactory->record();
+    Download* download = new Download(_id, _path, _url, metadata, _headers, _networkInfo, _reqFactory, _processFactory);
+
+    download->start();  // change state
+    download->startDownload();
+
+    // we need to set the data before we pause!!!
+    QList<MethodData> calledMethods = _reqFactory->calledMethods();
+    QCOMPARE(1, calledMethods.count());
+    FakeNetworkReply* reply = (FakeNetworkReply*) calledMethods[0].params().outParams()[0];
+
+    // makes the process to be executed
+    reply->emitFinished();
+
+    calledMethods = _processFactory->calledMethods();
+    QCOMPARE(1, calledMethods.count());
+    FakeProcess* process = (FakeProcess*) calledMethods[0].params().outParams()[0];
+
+    calledMethods = process->calledMethods();
+    QString processCommand = ((StringWrapper*)calledMethods[0].params().inParams()[0])->value();
+    QStringList processArgs = ((StringListWrapper*)calledMethods[0].params().inParams()[1])->value();
+    QCOMPARE(processCommand, command);
+    QVERIFY(0 != processArgs.count());
+}
+
+void TestDownload::testProcessExecutedWithParamsFile_data()
+{
+    QTest::addColumn<QString>("command");
+    QTest::addColumn<QVariantMap>("metadata");
+    QVariantMap first, second, third;
+    QStringList firstCommand, secondCommand, thirdCommand;
+
+    firstCommand << "touch" << "$file";
+    first["post-download-command"] = firstCommand;
+
+    QTest::newRow("First row") << firstCommand[0] << first;
+
+    secondCommand << "sudo" << "apt-get" << "install" << "$file";
+    second["post-download-command"] = secondCommand;
+
+    QTest::newRow("Second row") << secondCommand[0] << second;
+
+    thirdCommand << "grep" << "$file" << "-Rn";
+    third["post-download-command"] = thirdCommand;
+
+    QTest::newRow("Third row") << thirdCommand[0] << third;
+}
+
+void TestDownload::testProcessExecutedWithParamsFile()
+{
+    QFETCH(QString, command);
+    QFETCH(QVariantMap, metadata);
+
+    _processFactory->record();
+    _reqFactory->record();
+    Download* download = new Download(_id, _path, _url, metadata, _headers, _networkInfo, _reqFactory, _processFactory);
+
+    download->start();  // change state
+    download->startDownload();
+
+    // we need to set the data before we pause!!!
+    QList<MethodData> calledMethods = _reqFactory->calledMethods();
+    QCOMPARE(1, calledMethods.count());
+    FakeNetworkReply* reply = (FakeNetworkReply*) calledMethods[0].params().outParams()[0];
+
+    // makes the process to be executed
+    reply->emitFinished();
+
+    calledMethods = _processFactory->calledMethods();
+    QCOMPARE(1, calledMethods.count());
+    FakeProcess* process = (FakeProcess*) calledMethods[0].params().outParams()[0];
+
+    calledMethods = process->calledMethods();
+    QString processCommand = ((StringWrapper*)calledMethods[0].params().inParams()[0])->value();
+    QStringList processArgs = ((StringListWrapper*)calledMethods[0].params().inParams()[1])->value();
+    QCOMPARE(processCommand, command);
+    QVERIFY(processArgs.contains(download->filePath()));
+}

=== modified file 'ubuntu-download-manager-tests/test_download.h'
--- ubuntu-download-manager-tests/test_download.h	2013-07-20 14:08:52 +0000
+++ ubuntu-download-manager-tests/test_download.h	2013-07-21 19:10:31 +0000
@@ -25,6 +25,7 @@
 #include <metatypes.h>
 #include "fake_system_network_info.h"
 #include "fake_request_factory.h"
+#include "fake_process_factory.h"
 #include "test_runner.h"
 
 class TestDownload: public QObject
@@ -59,6 +60,9 @@
     void testSetGSMDownloadDiff_data();
     void testCanDownloadGSM_data();
     void testCanDownloadNoGSM_data();
+    void testProcessExecutedNoParams_data();
+    void testProcessExecutedWithParams_data();
+    void testProcessExecutedWithParamsFile_data();
 
     // accessor methods
     void testPath();
@@ -97,6 +101,11 @@
     void testSetRawHeadersResume();
     void testSetRawHeadersWithRangeResume();
 
+    // process related tests
+    void testProcessExecutedNoParams();
+    void testProcessExecutedWithParams();
+    void testProcessExecutedWithParamsFile();
+
 private:
     bool removeDir(const QString& dirName);
 
@@ -110,6 +119,7 @@
     QCryptographicHash::Algorithm _algo;
     FakeSystemNetworkInfo* _networkInfo;
     FakeRequestFactory* _reqFactory;
+    FakeProcessFactory* _processFactory;
 
 };
 

=== modified file 'ubuntu-download-manager-tests/test_download_queue.cpp'
--- ubuntu-download-manager-tests/test_download_queue.cpp	2013-07-20 15:53:38 +0000
+++ ubuntu-download-manager-tests/test_download_queue.cpp	2013-07-21 19:10:31 +0000
@@ -29,9 +29,12 @@
 {
     _networkInfo = new FakeSystemNetworkInfo();
     _reqFactory = new FakeRequestFactory();
-    _first = new FakeDownload(QUuid::createUuid(), "first-path", QUrl(), QVariantMap(), QMap<QString, QString>(), _networkInfo, _reqFactory);
+    _processFactory = new FakeProcessFactory();
+    _first = new FakeDownload(QUuid::createUuid(), "first-path", QUrl(), QVariantMap(), QMap<QString, QString>(), _networkInfo,
+        _reqFactory, _processFactory);
     _firstAdaptor = new DownloadAdaptor(_first);
-    _second = new FakeDownload(QUuid::createUuid(), "second-path", QUrl(), QVariantMap(), QMap<QString, QString>(), _networkInfo, _reqFactory);
+    _second = new FakeDownload(QUuid::createUuid(), "second-path", QUrl(), QVariantMap(), QMap<QString, QString>(), _networkInfo,
+        _reqFactory, _processFactory);
     _secondAdaptor = new DownloadAdaptor(_second);
     _q = new DownloadQueue(_networkInfo);
 }
@@ -339,7 +342,6 @@
     // cancel the download and expect it to be done
     _first->record();
     QSignalSpy changedSpy(_q, SIGNAL(currentChanged(QString)));
-    QSignalSpy removedSpy(_q, SIGNAL(downloadRemoved(QString)));
     _q->add(_first, _firstAdaptor);
 
     QVERIFY(_q->currentDownload().isEmpty());
@@ -349,16 +351,12 @@
     QVERIFY(_q->currentDownload().isEmpty());
 
     QCOMPARE(changedSpy.count(), 2);
-    QCOMPARE(removedSpy.count(), 1);
 
     QList<QVariant> arguments = changedSpy.takeFirst();
     QCOMPARE(arguments.at(0).toString(), _first->path());
     arguments = changedSpy.takeFirst();
     QVERIFY(arguments.at(0).toString().isEmpty());
 
-    arguments = removedSpy.takeFirst();
-    QCOMPARE(arguments.at(0).toString(), _first->path());
-
     QList<MethodData> calledMethods = _first->calledMethods();
     QCOMPARE(3, calledMethods.count());
     QCOMPARE(QString("canDownload"), calledMethods[0].methodName());
@@ -373,7 +371,6 @@
     _second->record();
 
     QSignalSpy changedSpy(_q, SIGNAL(currentChanged(QString)));
-    QSignalSpy removedSpy(_q, SIGNAL(downloadRemoved(QString)));
     _q->add(_first, _firstAdaptor);
     _q->add(_second, _firstAdaptor);
 
@@ -386,16 +383,12 @@
     QCOMPARE(_q->currentDownload(), _second->path());
 
     QCOMPARE(changedSpy.count(), 2);
-    QCOMPARE(removedSpy.count(), 1);
 
     QList<QVariant> arguments = changedSpy.takeFirst();
     QCOMPARE(arguments.at(0).toString(), _first->path());
     arguments = changedSpy.takeFirst();
     QCOMPARE(arguments.at(0).toString(), _second->path());
 
-    arguments = removedSpy.takeFirst();
-    QCOMPARE(arguments.at(0).toString(), _first->path());
-
     QList<MethodData> calledMethods = _first->calledMethods();
     QCOMPARE(3, calledMethods.count());
     QCOMPARE(QString("canDownload"), calledMethods[0].methodName());
@@ -416,7 +409,6 @@
     _second->record();
 
     QSignalSpy changedSpy(_q, SIGNAL(currentChanged(QString)));
-    QSignalSpy removedSpy(_q, SIGNAL(downloadRemoved(QString)));
     _q->add(_first, _firstAdaptor);
     _q->add(_second, _firstAdaptor);
 
@@ -429,16 +421,12 @@
     QCOMPARE(_q->currentDownload(), QString(""));
 
     QCOMPARE(changedSpy.count(), 2);
-    QCOMPARE(removedSpy.count(), 1);
 
     QList<QVariant> arguments = changedSpy.takeFirst();
     QCOMPARE(arguments.at(0).toString(), _first->path());
     arguments = changedSpy.takeFirst();
     QCOMPARE(arguments.at(0).toString(), QString(""));
 
-    arguments = removedSpy.takeFirst();
-    QCOMPARE(arguments.at(0).toString(), _first->path());
-
     QList<MethodData> calledMethods = _first->calledMethods();
     QCOMPARE(3, calledMethods.count());
     QCOMPARE(QString("canDownload"), calledMethods[0].methodName());
@@ -461,11 +449,6 @@
 
     _first->cancel();
     QVERIFY(_q->currentDownload().isEmpty());
-
-    QCOMPARE(removedSpy.count(), 1);
-
-    QList<QVariant> arguments = removedSpy.takeFirst();
-    QCOMPARE(arguments.at(0).toString(), _first->path());
 }
 
 void TestDownloadQueue::testDownloads()

=== modified file 'ubuntu-download-manager-tests/test_download_queue.h'
--- ubuntu-download-manager-tests/test_download_queue.h	2013-07-20 15:53:38 +0000
+++ ubuntu-download-manager-tests/test_download_queue.h	2013-07-21 19:10:31 +0000
@@ -25,6 +25,7 @@
 #include "test_runner.h"
 #include "fake_download.h"
 #include "fake_request_factory.h"
+#include "fake_process_factory.h"
 #include "fake_system_network_info.h"
 
 class TestDownloadQueue : public QObject
@@ -57,6 +58,7 @@
 private:
     FakeSystemNetworkInfo* _networkInfo;
     FakeRequestFactory* _reqFactory;
+    FakeProcessFactory* _processFactory;
     FakeDownload* _first;
     DownloadAdaptor* _firstAdaptor;
     FakeDownload* _second;

=== modified file 'ubuntu-download-manager-tests/ubuntu-download-manager-tests.pro'
--- ubuntu-download-manager-tests/ubuntu-download-manager-tests.pro	2013-07-18 20:37:08 +0000
+++ ubuntu-download-manager-tests/ubuntu-download-manager-tests.pro	2013-07-21 19:10:31 +0000
@@ -29,7 +29,9 @@
     test_xdg_basedir.cpp \
     fake_download_queue.cpp \
     fake_uuid_factory.cpp \
-    fake_system_network_info.cpp
+    fake_system_network_info.cpp \
+    fake_process.cpp \
+    fake_process_factory.cpp
 
 HEADERS += \
     fake.h \
@@ -47,7 +49,9 @@
     test_xdg_basedir.h \
     fake_download_queue.h \
     fake_uuid_factory.h \
-    fake_system_network_info.h
+    fake_system_network_info.h \
+    fake_process.h \
+    fake_process_factory.h
 
 LIBS += -L$$OUT_PWD/../libubuntudownloadmanager/ -lubuntudownloadmanager