OpenConnect

~mamarley/openconnect/+git/gitlab-main:verbosity_fix

  1. Git
  2. lp:~mamarley/openconnect/+git/gitlab-main
  3. verbosity_fix
Last commit made on 2022-04-08
Get this branch:
git clone -b verbosity_fix https://git.launchpad.net/~mamarley/openconnect/+git/gitlab-main

Branch merges

Branch information

Name:
verbosity_fix
Repository:
lp:~mamarley/openconnect/+git/gitlab-main

Recent commits

d99137c... by Dan Lenski

Bugfix verbosity level

I messed things up in 48de4c0d240579fe8cfd71c5dff177ba14f78d3e
("Remove the 'verbose' global variable"), where I failed to account
for the fact that `vpninfo->verbose` defaults to `PRG_TRACE`, and that
it needs to be set (via `openconnect_set_loglevel`) immediately after
option parsing is complete.

Signed-off-by: Daniel Lenski <email address hidden>

b688b0a... by dwmw2

stoken: Fix const warnings

Signed-off-by: David Woodhouse <email address hidden>

6f8c5ed... by dwmw2

esp: Close socket on error

Previously we would just keep trying to read from it and consume all CPU.

Fixes: 389 (hopefully)

Signed-off-by: David Woodhouse <email address hidden>

5a981e5... by dwmw2

epoll: Handle EPOLLERR as 'readable'

When we use select(), an error event on a file descriptor causes it to
be reported as readable, and some of the handlers will only clean it up
if that happens. So set the 'readable' flag on EPOLLERR too.

This is part of #389.

Signed-off-by: David Woodhouse <email address hidden>

63e4b85... by Dimitri Papadopoulos <email address hidden>

Fix --reconnect-timeout documentation

Signed-off-by: Dimitri Papadopoulos <email address hidden>
Signed-off-by: Daniel Lenski <email address hidden>

a27a46f... by Luca Boccassi

Merge branch 'fix_388' into 'master'

Bugfix RSA SecurID token decryption and PIN entry forms

Closes #388

See merge request openconnect/openconnect!344

1eb9338... by Dan Lenski

Fix GP fake server parameters so that gateway-interface 2FA is actually tested

To match the actually-parsed parameters in tests/fake-gp-server.py, change
'gateway_2fa' → 'gw_2fa'.

Signed-off-by: Daniel Lenski <email address hidden>

bbd60a9... by Dan Lenski

Add changelog entry

Signed-off-by: Daniel Lenski <email address hidden>

1941713... by Dan Lenski

Bugfix RSA SecurID token decryption and PIN entry forms

As of
https://gitlab.com/openconnect/openconnect/-/commit/386a6edb6d2d1d2cd3e9c9de8d85dc7bfda60d34,
all auth forms are required to have a non-NULL `auth_id`.

However, we forget to make stoken.c set the `auth_id` for the forms that it
creates for RSA SecurID token decryption and PIN entry. Let's name these:

  - `_rsa_unlock`, for token decryption.
  - `_rsa_pin`, for PIN entry. Also, rename the numeric PIN field to `pin`
    rather than `password`; there can't be any existing users relying on
    `--form-entry` to set its value, because that wouldn't work without the
    `auth_id`.

Fixes #388.

Signed-off-by: Daniel Lenski <email address hidden>

70ffe7f... by Dan Lenski

Add changelog entry

For 6a2ffbbcd1c4ef0b689cce3d17154f6d4c2e3bc0 ("Fix Windows tun setup crash")

Signed-off-by: Daniel Lenski <email address hidden>