OpenConnect

~mamarley/openconnect/+git/gitlab-main:the_great_renaming

  1. Git
  2. lp:~mamarley/openconnect/+git/gitlab-main
  3. the_great_renaming
Last commit made on 2020-12-08
Get this branch:
git clone -b the_great_renaming https://git.launchpad.net/~mamarley/openconnect/+git/gitlab-main

Branch merges

Branch information

Name:
the_great_renaming
Repository:
lp:~mamarley/openconnect/+git/gitlab-main

Recent commits

10f20b1... by Dan Lenski

update man-page caveat regarding IPv6 and vpnc-script

Signed-off-by: Daniel Lenski <email address hidden>

8c24e60... by Dan Lenski

fix manual/usage for --reconnect-timeout=INTERVAL option

Signed-off-by: Daniel Lenski <email address hidden>

4d26460... by Dan Lenski

small renaming tweaks to Java test application

Signed-off-by: Daniel Lenski <email address hidden>

cf01eb7... by Dan Lenski

rename CLI options containing 'dtls' to 'udp', and 'csd' to 'trojan' where applicable

Many of the CLI options with 'dtls' in the string are in fact applicable to
all protocols' UDP transports. Likewise for 'csd' options, which are
applicable to all protocols' Trojan binary/script execution.

This patch renames all of the options, but retains the old names as
redundant/duplicate options for backwards-compatibility.

Signed-off-by: Daniel Lenski <email address hidden>

3dd6ec6... by Dan Lenski

rename numerous internal variable names to be protocol-agnostic and general

Rename a large number of internal state variables to make them less
Cisco-specific, and more protocol-agnostic, where applicable. The goal is
to make some of the internal data structures easier to communicate and
understand for new developers/debuggers who may be unfamiliar with the
idiosyncracies' of OpenConnect's internal naming.

IMPORTANT: The names of functions in the libopenconnect API are NOT modified
here, although they might at some point benefit from a similar treatment.

- None of the variables with the prefix cstp_ are actually specific to
  the Cisco SSL tunnel protocol (CSTP). They are generally-applicable
  to SSL/TLS-based tunnels, or to a complete protocol implementation:

    cstp_basemtu → ssl_basemtu
    cstp_cipher → tls_cipher
    cstp_compr → ssl_compr
    cstp_handshake → tls_handshake
    cstp_options → proto_options
    cstp_pkt → tls_pkt

- dtls → udp, in all cases where such variables are not truly specific
  to DTLS:

    DTLS_CONNECTED → UDP_CONNECTED
    DTLS_CONNECTING → UDP_CONNECTING
    DTLS_DISABLED → UDP_DISABLED
    DTLS_NOSECRET → UDP_NOSECRET
    DTLS_SECRET → UDP_SECRET
    DTLS_SLEEPING → UDP_SLEEPING
    dtls_addr → udp_addr
    dtls_attempt_period → udp_attempt_period
    dtls_compr → udp_compr
    dtls_event → udp_event
    dtls_fd → udp_fd
    dtls_local_port → udp_local_port
    dtls_monitored → udp_monitored
    dtls_need_reconnect → udp_need_reconnect
    dtls_options → udp_options
    dtls_pass_tos → udp_pass_tos
    dtls_pkt → udp_pkt
    dtls_state → udp_state
    dtls_times → udp_times
    dtls_tos_current → udp_tos_current
    dtls_tos_optname → udp_tos_optname
    dtls_tos_proto → udp_tos_proto
    new_dtls_started → new_udp_started

- csd → trojan, in all cases where such variables are not truly specific to
  the execution of the Cisco Trojan:

    csd_env trojan_env
    csd_wrapper trojan_wrapper
    csd_user trojan_user
    set_csd_user set_trojan_user
    uid_csd_given uid_trojan_given
    csd_scriptname trojan_scriptname

- oncp_control_queue → outgoing_ssl_queue (this is used by both
  oNCP and Pulse protocols, and will probably be used by PPP-based
  protocols in the future)

Signed-off-by: Daniel Lenski <email address hidden>

0c53ca9... by Dan Lenski

CSD XML tag and nostub are entirely protocol-specific and used in only one place

This patch replaces them with inline functions (modeled after gpst_os_name),
instead of storing them in the global `struct openconnect_info` object.

TODO: further clarify, separate, and consolidate protocol-specific data in
`struct openconnect_info`.

Signed-off-by: Daniel Lenski <email address hidden>

7341032... by Dan Lenski

Merge branch 'more_logging_around_Trojan_script_invocation' into 'master'

more logging around Trojan script invocation (CSD/HIP/TNCC)

See merge request openconnect/openconnect!152

7083a0a... by Dan Lenski

more logging around Trojan script invocation (CSD/HIP/TNCC)

See #203 for a recent example of where it wasn't clear that a problem was
caused by a CSD script being invoked and never returning, due to the lack of
logging.

Signed-off-by: Daniel Lenski <email address hidden>

2f0f0f0... by Dan Lenski

Merge branch 'bugfix_MR_143' into 'master'

bugfix for !143

See merge request openconnect/openconnect!153

dc1f764... by Dan Lenski

fix undefined pointer error from !143

Caught by static analyzer run.

Signed-off-by: Daniel Lenski <email address hidden>