~mamarley/openconnect/+git/gitlab-main:temp-centos6

Last commit made on 2021-02-26
Get this branch:
git clone -b temp-centos6 https://git.launchpad.net/~mamarley/openconnect/+git/gitlab-main

Branch merges

Branch information

Name:
temp-centos6
Repository:
lp:~mamarley/openconnect/+git/gitlab-main

Recent commits

0888fd7... by Dan Lenski

centos6 ppp test flailing

Signed-off-by: Daniel Lenski <email address hidden>

55166c8... by Dan Lenski

ppp-over-tls tests: /etc/ppp script permissions problems

Some CI is still failing because pppd can't successfully execute the
/etc/ppp/* scripts after configuring the interfaces. Let's just move these
out of the way so that pppd won't try to execute them.

Side rant: pppd is the most appallingly bad program in terms of separation
of concerns.

Signed-off-by: Daniel Lenski <email address hidden>

052a7b6... by Dan Lenski

ppp-over-tls test: figured out how to make socat invoke pppd

This should hopefully allow these tests to run without timing race
conditions on all CI platforms.

Signed-off-by: Daniel Lenski <email address hidden>

4f6206d... by Dan Lenski

ppp-over-tls tests: try to keep CentOS 6 CI working, and improve flaky startup of pppd

Even with EPEL, CentOS has an old version of socat which doesn't support the
'rawer' option, so let's use the older 'raw,echo=0' combination to keep it
limping along.

More carefully try to verify that socat and pppd start up and connect to each other:

- Wait for socat to create PTY in 1-second increments, and keep going until PTY
  actually exists (up to 15 seconds).
- Wait for ppp to connect to PTY in 1-second increments, and keep going until pppd
  creates a "UUCP-style lockfile" for the PTY.
- Log how long it takes for the above process to complete (socat and pppd combined
  startup) in the test output.

Signed-off-by: Daniel Lenski <email address hidden>

3848c5a... by Dan Lenski

ppp: add comment about likely meaninglessness of server's LL IPv6 address

Signed-off-by: Daniel Lenski <email address hidden>

bd08007... by Dan Lenski

automatically disable pppd tests if socat or pppd are missing

This way, we can also automatically ENABLE them as soon as they're built into CI images.

Signed-off-by: Daniel Lenski <email address hidden>

3f093b1... by Dan Lenski

unset delay_tunnel_reason as soon as PPP reaches network state

This prevents an unnecessary extra iteration of waiting for PPP negotiation.
Caught via ppp-over-tls test logs.

Signed-off-by: Daniel Lenski <email address hidden>

134033a... by Dan Lenski

clarify un-HDLC logging a bit

Leftover bytes due to concatenated packet shouldn't be reported as part of
the un-HDLC size reduction.

Signed-off-by: Daniel Lenski <email address hidden>

0b0586c... by Dan Lenski

fix nakbuf leak

Signed-off-by: Daniel Lenski <email address hidden>

6561b74... by Dan Lenski

CI: re-enable PPP tests for CentOS7, Fedora, and Ubuntu

Still to-do:
1) Get socat+pppd working in CentOS8 and CentOS6 CI
2) Figure out why PPP tests are so slow (added log retention for 1 week, even on success, in Ubuntu18.04/GnuTLS build)

Signed-off-by: Daniel Lenski <email address hidden>