~mamarley/openconnect/+git/gitlab-main:less_noisy_epoll_and_UDP_sndbuf

Branch merges

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

d930fdc... by Dan Lenski on 2021-08-31

Only log UDP SO_SNDBUF getsockopt() if it differs from intended value

Ping #299. (The increase in UDP sndbuf was added in d4ba1e1d.)

Signed-off-by: Daniel Lenski <email address hidden>

728747d... by Dan Lenski on 2021-08-31

Don't repeatedly call EPOLL_CTL_DEL on same fd

__remove_epoll_fd() should set vpninfo->epoll_fd to -1, otherwise we will
try to remove it repeatedly and get -ENOENT errors. This was inadvertently
omitted in dc86e96e. Resolves #299.

Signed-off-by: Daniel Lenski <email address hidden>

efc3c81... by Dan Lenski on 2021-08-30

Merge branch 'ERR_GET_FUNC_OpenSSL_3.0' into 'master'

Build with OpenSSL 3.0 beta 2 Release Candidate

Closes #289

See merge request openconnect/openconnect!269

c7313bd... by Dimitri Papadopoulos <email address hidden> on 2021-08-16

Build with OpenSSL 3.0 beta 2 Release Candidate

I had forgotten this ERR_GET_FUNC() call in my previous patch !262.

Again, removing calls to ERR_GET_FUNC() will not change anything:

PKCS11_F_PKCS11_LOGIN / ERR_LIB_PKCS11

We check the function code is PKCS11_F_PKCS11_LOGIN right after
calling PKCS11_login().

Signed-off-by: Dimitri Papadopoulos <email address hidden>

0b0d218... by Dan Lenski on 2021-08-11

Merge branch 'lgtm' into 'master'

Fix LGTM alerts in Python code

See merge request openconnect/openconnect!266

2ef70db... by Dan Lenski on 2021-08-11

Merge branch 'ERR_GET_FUNC_OpenSSL_3.0' into 'master'

Build with OpenSSL 3.0 beta 2 Release Candidate

Closes #289

See merge request openconnect/openconnect!262

6d5b07d... by Dan Lenski on 2021-08-11

Only remove ERR_GET_FUNC for OpenSSL v3.0 and newer

This function is removed in OpenSSL 3.0 beta 2, per
https://github.com/openssl/openssl/blob/openssl-3.0.0-beta2/CHANGES.md:

> The ERR_GET_FUNC() function was removed. With the loss of
> meaningful function codes, this function can only cause
> problems for calling applications.

It appears that this function may not have had any useful purpose for a long
time (see
https://gitlab.com/openconnect/openconnect/-/merge_requests/262#note_648720006),
but in the absence of clear documentation or testing, we should limit its
remove to OpenSSL 3.0+ to be on the safe side.

Signed-off-by: Daniel Lenski <email address hidden>

1b3ffa6... by Dan Lenski on 2021-08-10

Use more idiomatic super().__init__() in html.py

Signed-off-by: Daniel Lenski <email address hidden>

29851ce... by Dan Lenski on 2021-08-10

Merge branch 'tests_trailing_space' into 'master'

Remove spurious trailing space

See merge request openconnect/openconnect!261

14505c5... by Dimitri Papadopoulos <email address hidden> on 2021-08-08

LGTM recommendation: Unused local variable

The value assigned to '...' is never used.

https://lgtm.com/rules/6780086/

Signed-off-by: Dimitri Papadopoulos <email address hidden>