~mamarley/openconnect/+git/gitlab-main:install_vpn_opts_allow_no_ip

Last commit made on 2021-10-14
Get this branch:
git clone -b install_vpn_opts_allow_no_ip https://git.launchpad.net/~mamarley/openconnect/+git/gitlab-main

Branch merges

Branch information

Name:
install_vpn_opts_allow_no_ip
Repository:
lp:~mamarley/openconnect/+git/gitlab-main

Recent commits

66ff7e2... by Dan Lenski

Make install_vpn_opts tolerate missing IP addresses on reconnect

Some protocols don't always send IP address(es) in configuration packets in
the event of reconnection/rekey. It should be harmless for OpenConnect to
assume that the address(es) are staying the same when they aren't explicitly
specified as changing.

Signed-off-by: Daniel Lenski <email address hidden>

2437055... by Andreas Gnau

Add parameter to allow specifying no IP install_vpn_opts

NX also uses IPCP for getting its IPv4-IP while all the other connection
parameters are retrieved via HTTP. This increases the number of
protocols that need special treatment in install_vpn_opts to two.
Add a generic parameter `allow_no_ip` to install_vpn_opts which is set
to true when called from F5 and NX, thus keeping the code free of
protocol-specific bits.

[DRL tweaked comments.]

Signed-off-by: Andreas Gnau <email address hidden>
Signed-off-by: Daniel Lenski <email address hidden>

e9092b6... by Dan Lenski

Dump initial oNCP negotiation request if --dump-http-traffic is specified

Joachim Kuebart noted the absence of this output in
https://gitlab.com/openconnect/openconnect/-/merge_requests/271#note_654871352

Signed-off-by: Daniel Lenski <email address hidden>

5ddd857... by Dan Lenski

bugfix openconnect__strchrnul function in compat.c

In e6ce815e112415e8a00cf838bcaf9121be3503de, I claimed…

> GNU strchrnul() is trivial to implement

Nevertheless, I got it wrong: there was an off-by-one error in the case
where the sought character is indeed found.

The strchrnul() function is used in protocol-specific code for both GP and
Fortinet. Fixes #318.

Signed-off-by: Daniel Lenski <email address hidden>

f81c288... by Dan Lenski

Merge branch 'wintun-0.13' into 'master'

Upgrade to Wintun 0.13?

See merge request openconnect/openconnect!264

b8f79ce... by Dan Lenski

Annotate vpnc-script-win.js with a header documenting its exact source revision

By annotating the vpnc-script-win.js included in the Windows installers
with information about the exact source revision, we will ease reporting
and reduce confusion about problems resulting from interactions between
OpenConnect and vpnc-script.

Example of the header added to vpnc-script-win.js:

    // This script matches the version found at https://gitlab.com/openconnect/vpnc-scripts/-/blob/b749c2cadc2f32e2efffa69302861f9a7d4a4e5f/vpnc-script-win.js
    // Updated on 2021-09-24 by Daniel Lenski <email address hidden> ("Ensure that vpnc-script-win.js works even if INTERNAL_IP4_{NETADDR,NETMASK} are unset")
    //

Signed-off-by: Daniel Lenski <email address hidden>

adc0b0c... by Dan Lenski

Fix missing newline in Windows error message

Signed-off-by: Daniel Lenski <email address hidden>

708f38a... by Dan Lenski

Merge branch 'deepsource' into 'master'

Fix DeepSource alerts

See merge request openconnect/openconnect!284

a62dbb0... by Dimitri Papadopoulos <email address hidden>

Fix DeepSource alert

Useless inheritance from `object`

The class is inheriting from `object`, which is implicit under Python 3 ,
hence can be safely removed from bases.

Signed-off-by: Dimitri Papadopoulos <email address hidden>

8677139... by Dimitri Papadopoulos <email address hidden>

Fix DeepSource alert

Logging is not lazy

The logging statement has the call of the form
 logging.(format_string % (format_args...))
For such calls, it is recommended to leave string interpolation to the
logging method itself and be written as
 logging.(format_string, format_args...)
so that the program may avoid incurring the cost of the interpolation
in those cases in which no message will be logged. For more details, see
PEP 282.

Signed-off-by: Dimitri Papadopoulos <email address hidden>