~mamarley/openconnect/+git/gitlab-main:handle_Fortinet_DNS_domains_ASCII_escapes

Last commit made on 2023-08-08
Get this branch:
git clone -b handle_Fortinet_DNS_domains_ASCII_escapes https://git.launchpad.net/~mamarley/openconnect/+git/gitlab-main

Branch merges

Branch information

Name:
handle_Fortinet_DNS_domains_ASCII_escapes
Repository:
lp:~mamarley/openconnect/+git/gitlab-main

Recent commits

75d1091... by Dan Lenski

Update changelog

Signed-off-by: Daniel Lenski <email address hidden>

8042dcd... by Dan Lenski

Handle '\NNN' escapes in Fortinet search domains

See https://gitlab.com/openconnect/openconnect/-/issues/634 for the details.
Basically, some Fortinet VPNs apparently use '\059' (ASCII character 59 is ';')
as a delimiter in their DNS search domains list.

This *could* be handled in a cross-protocol way, as was done earlier in
https://github.com/dlenski/mariadb-server/commit/03eafb41f45d70938cb19820a21165445ff3af14
for the case of [;, ] separators, but it seems too weird and
Fortinet-specific for me to want to do that immediately.

This also modifies `tests/fake-fortinet-server.py` to delimit search domains
using such escapes, as a test/example for OpenConnect to parse.

Signed-off-by: Daniel Lenski <email address hidden>

db3722f... by Audric Schiltknecht <email address hidden>

Fix invalid reset of URL variable in csd-wrapper

The URL variable is constructed from the CSD_HOSTNAME at the beginning of
the script. However, prior to parsing the command line, it was reset to
an empty value.

[DRL: This bug has existed since
https://gitlab.com/openconnect/openconnect/-/commit/cb83e535213ff2132643d2a68c50abc294b43b82,
when I modified the `csd-wrapper.sh` script to parse its `-url` command-line
argument, but forgot to remove the subsequent line `URL=`.]

Signed-off-by: Audric Schiltknecht <email address hidden>

b0034f2... by Dan Lenski

Request help with the interpretation of F5 URIs in the docs

Some F5 VPNs use these to complete authentication and handoff to the
proprietary client, and we currently don't know how to interpret them in a
way that would allow OpenConnect to be used instead.

See https://gitlab.com/openconnect/openconnect/-/issues/639 and
https://lists.infradead.org/pipermail/openconnect-devel/2021-August/005035.html
for further discussion.

Signed-off-by: Daniel Lenski <email address hidden>

9c63c94... by dwmw2

Fix changelog entry for Pulse OS reporting

This was added under v9.12 instead of the HEAD section. Next person to do
that gets to implement a CI test for it :)

Perhaps we should have a policy of adding in reverse chronological order
so that newly-added lines are always immediately below the 'HEAD' title,
which would mean that merging older PRs would *conflict* instead of
silently merging into the older changelog?

Fixes: ff86be7281 ("update changelog")
Signed-off-by: David Woodhouse <email address hidden>

5a9a37a... by Dan Lenski

Fix juniper-auth test

In 57160c9f2673adbbe468db137b28da4187549061, I updated
fake-juniper-server.py to use a "persistent" configuration (as already done
for fake GlobalProtect, Fortinet, F5 servers), but thne I somehow forgot to
update the actual juniper-auth test script accordingly.

Signed-off-by: Daniel Lenski <email address hidden>

9d9a33c... by Dan Lenski

Replace broken link with Wayback Machine link

The article "Why TCP Over TCP Is A Bad Idea" is very useful for explaining
why VPNs perform better when using UDP-based transport (DTLS or ESP) rather
than TCP-based transport (TLS), but unfortunately the original site is no
longer available.

Replace it with a link to the Internet Archive's Waback Machine, specifically
https://web.archive.org/web/20230228035749/http://sites.inka.de/~W1011/devel/tcp-tcp.html

Signed-off-by: Daniel Lenski <email address hidden>

5796277... by Dimitri Papadopoulos <email address hidden>

Fix broken link to Juniper PDF

Signed-off-by: Dimitri Papadopoulos <email address hidden>

0e5a69e... by Dan Lenski

Merge branch 'send_OS_info_to_Pulse_server' into 'master'

OpenConnect should report the client operating system to Pulse servers

See merge request openconnect/openconnect!481

2b61f99... by Dan Lenski

More comments on contents of hard-coded oNCP packets

Signed-off-by: Daniel Lenski <email address hidden>