~mamarley/openconnect/+git/gitlab-main:debug_466

Last commit made on 2022-07-10
Get this branch:
git clone -b debug_466 https://git.launchpad.net/~mamarley/openconnect/+git/gitlab-main

Branch merges

Branch information

Name:
debug_466
Repository:
lp:~mamarley/openconnect/+git/gitlab-main

Recent commits

7ce5a3b... by Dan Lenski

Distinguish XML and non-XML error paths in gpst_xml_or_error

This should help with debugging https://gitlab.com/openconnect/openconnect/-/issues/466

Signed-off-by: Daniel Lenski <email address hidden>

03eafb4... by Dan Lenski

Support [,;] as separators for multiple search domains with all protocols

This should fix https://gitlab.com/openconnect/openconnect/-/issues/433
specifically, as well as prevent any future similar issues for other
protocols.

Supported protocols and servers are extremely inconsistent in how they send
us multiple search domains. Some provide domains via repeating fields which
we glom into a single space-separated string, some provide domains in single
fields which contain ',' or ';' as separators.

Since neither ',' nor ';' is a legal character in a domain name, and since
all known routing configuration scripts support space-separated domains. we
can safely replace these characters with spaces, and thus support all known
combinations.

Further analysis of the status quo at
https://gitlab.com/openconnect/openconnect/-/issues/433#note_950199540.

Signed-off-by: Daniel Lenski <email address hidden>

aba74c2... by Dan Lenski

Merge branch 'man' into 'master'

Man page: fix format

See merge request openconnect/openconnect!390

0670e20... by Dimitri Papadopoulos <email address hidden>

Man page: use bold for option names

Signed-off-by: Dimitri Papadopoulos <email address hidden>
Signed-off-by: Daniel Lenski <email address hidden>

1873384... by Dimitri Papadopoulos <email address hidden>

Man page: remove spurious space before )

Signed-off-by: Dimitri Papadopoulos <email address hidden>

3855699... by Dimitri Papadopoulos <email address hidden>

Man page: fix list of supported protocols

Signed-off-by: Dimitri Papadopoulos <email address hidden>

cf4c5dc... by Dan Lenski

Log more details of unknown Pulse packets

Perhaps there's something useful/interesting lurking in the unknown packets,
like a DPD/keepalive packet, as noted in
https://gitlab.com/openconnect/openconnect/-/issues/456

Signed-off-by: Daniel Lenski <email address hidden>

37b6a79... by Dan Lenski

Clarify purpose/scope of --usergroup option

The name '--usergroup' exists purely for historical/Cisco-specific reasons.
Its function is simply to override the *path* of the URL for the initial
HTTPS request to the server.

Thus 'openconnect --usergroup loginRealm vpn.server.com'
and 'openconnect https://vpn.server.com/loginRealm' are entirely equivalent;
with most front-ends, specifying the URL directly is the only way to set the
path.

Signed-off-by: Daniel Lenski <email address hidden>

8953715... by Dan Lenski

Clarify purpose/scope of --authgroup option

We frequently get questions from users who are unsure of how to
automatically enter an authentication dropdown selection using the command
line client. A recent example:
https://lists.infradead.org/pipermail/openconnect-devel/2022-May/005125.html

The `--authgroup=GROUP` option is specifically designed for this purpose: it can enter
a value into "the right" dropdown/list field on multiple protocols:

- Cisco AnyConnect/ocserv: "authgroup" selection form field
- Juniper: "realm" OR "frmSelectRoles" selection form field
- Pulse: "realm" selection form field
- Fortinet: "realm" selection form field
- F5: "domain" selection form field
- GlobalProtect: "gateway" selection form field (found on the "portal" interface;
  this one actually controls the choice of gateway server)

The functionality of the `--authgroup` option is not as obvious as
it could/should be because the name "authgroup" is Cisco-specific.

This patch improves the `--help` output and openconnect(8) man page to
show that it works with other protocols as well, and mention the names
of the relevant fields for those protocols.

Signed-off-by: Daniel Lenski <email address hidden>

6246bbd... by Dimitri Papadopoulos Orfanos <email address hidden>

Merge branch 'const' into 'master'

Fix constness again in HKDF/HPKE-related functions

See merge request openconnect/openconnect!384