Code review comment for lp:~malizor/update-manager/ppa-changelogs

Revision history for this message
Nicolas Delvaux (malizor) wrote :

I fixed what you suggested:

* Move the try/except block to the calling function, to catch all API errors
* Different messages for different errors (and end them with periods!)
* Check that candidate URI hostname matches ppa.launchpad.net
* Do not use bare excepts
* Use "spphs" instead of the singular form
* Add a missing break
* Add an entry in debian/changelog

« Back to merge proposal