Merge lp:~malizor/software-center/fix-lp1050036 into lp:software-center

Proposed by Nicolas Delvaux on 2012-10-04
Status: Merged
Merged at revision: 3220
Proposed branch: lp:~malizor/software-center/fix-lp1050036
Merge into: lp:software-center
Diff against target: 16 lines (+2/-4)
1 file modified
softwarecenter/ui/gtk3/widgets/labels.py (+2/-4)
To merge this branch: bzr merge lp:~malizor/software-center/fix-lp1050036
Reviewer Review Type Date Requested Status
Michael Vogt 2012-10-04 Approve on 2012-10-05
Review via email: mp+128118@code.launchpad.net

Description of the change

A string encoding issue that lead to a nasty bug on some locals such as French.
It prevented the display of the detail view for packages which require, for example, hardware accelerated OpenGL (including paid apps such as the ones from HIB).

This bug could have been fixed by converting the returned value of the gettext calls to Unicode.
But "✓" and "✘" are quite universal: I did a grep on all po files from the rosetta-i18n-export branch and I found no other translation than the original.

So I propose to drop i18n for these symbols.

To post a comment you must log in.
Michael Vogt (mvo) wrote :

Thanks, looks good and +1 for dropping unneeded i18n

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'softwarecenter/ui/gtk3/widgets/labels.py'
2--- softwarecenter/ui/gtk3/widgets/labels.py 2012-09-10 13:43:05 +0000
3+++ softwarecenter/ui/gtk3/widgets/labels.py 2012-10-04 21:33:23 +0000
4@@ -28,10 +28,8 @@
5 """
6
7 SUPPORTED_SYM = {
8- # TRANSLATORS: symbol for "hardware-supported"
9- 'yes': _(u'\u2713'),
10- # TRANSLATORS: symbol for hardware "not-supported"
11- 'no': '<span foreground="red">%s</span>' % _(u'\u2718'),
12+ 'yes': u'\u2713',
13+ 'no': u'<span foreground="red">\u2718</span>'
14 }
15
16 # TRANSLATORS: this is a substring that used to build the