Merge lp:~malaperle/ubuntu/raring/overlay-scrollbar/lp-789123 into lp:ubuntu/raring/overlay-scrollbar
Proposed by
Marc-Andre Laperle
Status: | Needs review |
---|---|
Proposed branch: | lp:~malaperle/ubuntu/raring/overlay-scrollbar/lp-789123 |
Merge into: | lp:ubuntu/raring/overlay-scrollbar |
Diff against target: |
209 lines (+46/-0) 1 file modified
os/os-scrollbar.c (+46/-0) |
To merge this branch: | bzr merge lp:~malaperle/ubuntu/raring/overlay-scrollbar/lp-789123 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ayatana Scrollbar Team | Pending | ||
Review via email: mp+188376@code.launchpad.net |
Description of the change
Fix stack overflow when a callback contains a bad or null pointer in its parameters (gpointer user_data for example).
From a callback, get_private gets called with a bad pointer as parameter. This makes lookup_private always return a null pointer which makes it call swap_thumb which calls get_private again with the bad pointer and so on.
callback -> get_private -> swap_thumb -> get_private -> swap_thumb -> get_private -> ...
To post a comment you must log in.
Unmerged revisions
- 36. By Marc-Andre Laperle
-
Fix stack overflow (LP: #789123)