lp:~makyo/juju-gui/rel-prep

Created by Madison Scott-Clary on 2013-10-11 and last modified on 2013-10-11
Get this branch:
bzr branch lp:~makyo/juju-gui/rel-prep
Only Madison Scott-Clary can upload to this branch. If you are Madison Scott-Clary please log in for upload directions.

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Madison Scott-Clary
Project:
juju-gui
Status:
Development

Recent revisions

1127. By Madison Scott-Clary on 2013-10-11

AllWatcher changes.

1126. By Benjamin Saller on 2013-10-10

Fix annotations on go backend

Fix annotation roundtrips with go backend
      Splits how we prepare deltas for py/go juju fakebackends
      Change test expectations to merge updateAnnotation calls

  Fix import of constraints
  Fix export of undefined/default values

  Adjust simulator unit count rate of change.

R=benjamin.saller, gary.poster, jeff.pihach
CC=
https://codereview.appspot.com/14485046

1125. By Francesco Banconi on 2013-10-10

Fix links in the unit details view.

Handle the juju-core "port/protocol" ports.
Privilege the HTTPS port if applicable.

Also fixed the z-index of the charm browser tab,
so that when the sidebar and the unit details view
appear together in a narrow browser it is still
possible to close the sidebar.

QA:
- deploy the GUI with this branch in a juju-core env:
  juju bootstrap --debug
  juju deploy juju-gui
  juju set juju-gui juju-gui-source=lp:~frankban/juju-gui/inspector-who
- wait for the unit to be ready;
- visit the juju-gui unit detail view;

You should be able to close the sidebar view.
The GUI address links to the right URL (https://).
The ports link to the right URLs without the trailing "/tcp".

R=jeff.pihach
CC=
https://codereview.appspot.com/14439054

1124. By huwshimi on 2013-10-10

Added bundle details panel icon and visibility

On the bundle details overview I added the charm icon to the charm details panel. I also added showing and hiding of that panel.

R=gary.poster
CC=
https://codereview.appspot.com/14515049

1123. By Jeff Pihach on 2013-10-10

Added the source code tab to bundle details view

R=gary.poster
CC=
https://codereview.appspot.com/14595045

1122. By Jeff Pihach on 2013-10-10

Adds charm icons to bundle token and detail view

R=gary.poster
CC=
https://codereview.appspot.com/14591044

1121. By Madison Scott-Clary on 2013-10-09

Fix upgrade text, remove feature flag

Upgrade service notification matches designs, feature flag for upgrade charm removed.

R=gary.poster, rharding
CC=
https://codereview.appspot.com/14438061

1120. By Richard Harding on 2013-10-09

Prevent direct charm id routes mis-firing.

The routeDirectCharmId is ONLY meant to handle the case of short, id-only urls
"jujucharms.com/precise/mysql". It assumes the viewmode (usually 'sidebar').

A fullscreen url was getting processed except that the viewmode was set to
sidebar. This caused contention between the routeDirectCharmId and the
routeView which would work like this

- routeDirectCharmId: "Render this charm id I found in the url in sidebar mode"
- routeView: "We've rendered crap, but that was sidebar so Render this charm
id found in fullscreen"

--Enter double dispatch

- routeDirectCharmId: "Hmm, we've got crap rendered, but it was fullscreen so
the viewmode has changed. Render this charm id in sidebar"
- routeView: "Stupid sidebar, this clearly says to render it in fullscreen
viewmode. Render it again."

What should happen is that the routeDirectCharmId realizes that the url has
more than a charmId in it and just bails out saying another route (routeView)
will handle it altogether.

QA: Just hit the url in the bug in your local branch and it should work
perfectly without artifacts.

R=matthew.scott
CC=
https://codereview.appspot.com/14441054

1119. By huwshimi on 2013-10-09

Styling for bundle details charm info

This branch styles the charm details panel that appears on the bundle details tab.

To test browse to http://localhost:8888/sidebar/search/bundle/~benji/wiki/5/wiki/:flags:/charmworldv3/?text=wiki and click the visible charm icon.

The panel shows a square before the icon has been clicked. This is because the panel showing/hiding has not been implemented yet. This is also why the close icon currently does nothing.

R=gary.poster
CC=
https://codereview.appspot.com/14483046

1118. By huwshimi on 2013-10-09

Changed recommended charm indicator

Added the new recommended charm indicator to the charm token and charm/bundle details.

Moved the selected token line to the left as per new mockups.

R=rharding, gary.poster
CC=
https://codereview.appspot.com/14526043

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
Stacked on:
lp:juju-gui/experimental
This branch contains Public information 
Everyone can see this information.