lp:~makyo/juju-gui/go-remove-units-1168310

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:juju-gui/experimental at revision 546

Juju GUI Hackers: Pending requested 2013-04-12

Diff: 103 lines (+82/-0)

2 files modified

app/store/env/go.js (+44/-0)
test/test_env_go.js (+38/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1168310: Implement remove_units in GoEnvironment

High

Fix Released

Link a bug report

Related blueprints

544. By Madison Scott-Clary on 2013-04-12

Fix lint

543. By Madison Scott-Clary on 2013-04-12

Added remove_units to go env; tests pass.

542. By Francesco Banconi on 2013-04-12

Fix relation data in service and unit views.

This branch fixes how relation data is handled and
visualized in the service relation view and in the
unit view.

The id used in DOM elements and querystring is now
created using generateSafeDOMId, so that it is safe
to use when the GUI is connected to juju-core.

Also slightly improved generateSafeDOMId: now it uses
a pre-defined alphabetic prefix in order to avoid possible
results starting with a number.

A CSS fix is also included: prevent bootstrap to override
the table row highlighted style, used when we want to
highlight a specific relation in the relations table.

R=teknico, gary.poster
CC=
https://codereview.appspot.com/8703043

541. By Richard Harding on 2013-04-12

Style the browser changelog list.

- Fix the test that mocks out the callback to use ev.halt()

R=j.c.sackett
CC=
https://codereview.appspot.com/8707043

540. By Gary Poster on 2013-04-11

Fix bug 1167967 (hopefully)

This branch attempts to fix the referenced bug. I was unable to duplicate the symptoms locally exactly, but duplicated them closely enough that I am optimistic that these changes address the issue. Regardless, they seem like reasonable changes.

I also fixed a couple of landscape issues I saw with newly created services without annotations.

The aspect of this branch I wonder most if reviewers (particularly Ben) will like is the change to the route url algorithm. If it's not clear why I chose it, I'm happy to discuss my rationale and other options.

Thank you.

R=bcsaller, matthew.scott
CC=
https://codereview.appspot.com/8680043

539. By j.c.sackett on 2013-04-11

Adds "popular" charms to sidebar.

-Another block in sidebar creates the "popular" charm container.
-"Popular" charms also added to cache.
-"Popular" block added to sidebar template.
-Added "popular" to sidebar json test data, and re-pretty-printed it.
-Updated test for the additional charm in cache; although "popular" has two
charms, one of them (cassandra) is also in our "new" category.

R=rharding, jeff.pihach
CC=
https://codereview.appspot.com/8561048

538. By Richard Harding on 2013-04-11

Adjust design per review, add truncate helper

- Per UX reviews adjust some of the design of the browser
- Add a truncate handlebars helper to aid in fitting content nicely

R=j.c.sackett
CC=
https://codereview.appspot.com/8662043

537. By Gary Poster on 2013-04-11

Fix sandbox setconfig and associated test

The sandbox setconfig test was taking over a second--a pretty clear indication that it was waiting on the fake delta stream rather than a direct response. Investigation revealed that the sandbox method was incorrectly using the ASYNCOP helper rather than the OP helper. This small branch fixes the setconfig problem and adjusts the tests. The test is very fast now (not yellow or red in the mocha output).

R=bac, matthew.scott
CC=
https://codereview.appspot.com/8663043

536. By Madison Scott-Clary on 2013-04-11

Trivial: add relation works with touch.

R=gary.poster
CC=
https://codereview.appspot.com/8628044

535. By Francesco Banconi on 2013-04-11

Fix exposed attribute handling in delta stream

This branch fixes the service "exposed" and unit "relation_errors"
attributes handling when the delta comes from juju-core.
The _process_delta function allows for overriding those attrs
in the case a delta stream arrives from PyJuju. The juju-core
handlers, instead, must update model instances with partial changes,
e.g. when handling annotations. This was the cause of the regression.

Also improved the cleanUpEntityTags helper.

R=teknico, gary.poster
CC=
https://codereview.appspot.com/8657043