lp:~makyo/juju-gui/drag-interrupted-1099921

Branch merges

Propose for merging

No branches dependent on this one.

Ready for review for merging into lp:juju-gui/experimental

Juju GUI Hackers: Pending requested 2013-02-01

Diff: 82 lines (+24/-6)

2 files modified

app/views/topology/relation.js (+15/-3)
app/views/topology/service.js (+9/-3)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1099921: Dragging services fails intermittently

High

Fix Released

Link a bug report

Related blueprints

360. By Madison Scott-Clary on 2013-02-01

Merge with trunk, lint+beautify

359. By Madison Scott-Clary on 2013-02-01

Merged with trunk; dragging no longer interrupted in multiple browser windows.

358. By Madison Scott-Clary on 2013-02-01

Dragging no longer interrupted in one browser window.

357. By Madison Scott-Clary on 2013-01-29

Minor - new subordinates now classed properly

This was causing subordinate relation counts to be blank if they were added right after the subordinate was created. Super simple fix.

R=bac, gary.poster
CC=
https://codereview.appspot.com/7227050

356. By Brad Crittenden on 2013-01-29

Add simple test for dragend workaround.

The work-around added to the build relation 'dragend' event handler to prevent
the serviceClick handler from processing and doing the wrong thing is now
tested. An integration test using simulated drags and a click on the service
didn't prove feasible so this unit test is used.

R=benji, gary.poster
CC=
https://codereview.appspot.com/7237053

355. By Madison Scott-Clary on 2013-01-29

Correctly count subordinate relations

Subordinate relations were not being properly counted with the new comparison when it came to new services or relations. This was due to object inequality after a component's update method was called. Comparison switched to service modelIds, and test added.

R=bac, teknico
CC=
https://codereview.appspot.com/7234048

354. By Benji York on 2013-01-29

Use a CSS minifier that doesn't require Java

Don't blink or you'll miss it.

R=bac, matthew.scott, bcsaller
CC=
https://codereview.appspot.com/7228054

353. By Madison Scott-Clary on 2013-01-28

GUI should handle reconnects gracefully.

Previously, the GUI would lose its mind on a reconnect, due to the addition of authentication and not receiving a delta. This has been fixed, and the existing test for connection behavior modified to reflect changes.

R=gary.poster, frankban
CC=
https://codereview.appspot.com/7214047

352. By Benji York on 2013-01-28

Added and refactored tests for ViewportModule

This branch adds some tests and reworks existing tests to have many fewer
dependencies.

This branch also introduces a couple of test helpers that make generating test
doubles easier.

R=matthew.scott, gary.poster
CC=
https://codereview.appspot.com/7196056

351. By Francesco Banconi on 2013-01-28

Remove the unused "units" option. Added tests.

This branch removes the disconnected "units" voice
from the service menu.

Also added some tests for the service module, and
fixed test dependencies so that now the service
module events tests can be run in isolation.

R=teknico, bac
CC=
https://codereview.appspot.com/7237044